Thanks for testing Gale.On 17 August 2013 22:21, Gale Andrews <email@example.com> wrote:
> | From Steve the Fiddle <firstname.lastname@example.org>
> | Wed, 14 Aug 2013 21:40:54 +0100
> | Subject: [Audacity-devel] [Audacity-quality] Align tracks end to end
>> On 14 August 2013 06:00, Steve the Fiddle <email@example.com> wrote:
>> > Just in case anyone was thinking of reviewing my patch, don't bother.
>> > I've started again and will confine the patch to just adding the
>> > "Align End to End" feature.
>> > I've started adding TODO and FIXME comments for the other issues that
>> > have been identified, but I can take them out if preferred.
>> In the absence of a response, I've left the TODO and FIXME comments in place.
>> Much as I dislike repeating work I think this is a useful feature that
>> will benefit many users, so the attached patch adds the option to
>> "Align End to End" but does NOT address the other issues. I have used
>> TODO and FIXME as place-holders so that these issues can be more
>> easily addressed in the future.
> Thanks, Steve. I tested it for a while on Windows. I didn't have any
> problems (with the provisos you list).
> +1 to this being a useful feature in its own right.
> If this is committed I would personally like to see a follow up patch
> * "Align" and "Align and Move" both appear the same in the Undo history.
> * Align commands are "active" even when there is no audio to align.
> * "Align Tracks Together" may push audio entirely behind time zero.
> * "Sync Lock" is incorrectly disabled during Play/Record.
> * "Align Tracks Together" causes nonsensical changes to label tracks.
> * "Align with Cursor" is a duplicate of "Align with Selection Start"
> * The underlined "g" for "Align Together" is not visible.
> * "Align Tracks Together" fails if there is a start time before zero.
> * Incorrect handling of stereo tracks if channels are different lengths.
The bug that prevented "Align Tracks Together" from working when there
are start times before zero should be fixed by
AlignEndToEndMinimal.patch. Because we wanted "Align End to End" and
"Align (Tracks) Together" to be the first two items in the "Align
Tracks" menu it would have been silly to not fix that. Unfortunately
we don't have the separator that we wanted between these two menu
items and the rest, but I can't see any way to do so without moving
these options out of the align Labels array. Perhaps Vaughan can
advise on this?
>> Two problems that I had with using alignLabels array:
>> 1) Regarding the comment "HACK", I could see no other way to get the
>> "Align and Move" menu to work with "Align End to End" and "Align
>> Together" at the top of the "Align" menu. If there is a better way to
>> do this please let me know.
>> 2) I was not able to find a way to put a separator between "Align
>> Together" and "Align with Zero". Is there a way to do that?
>> This patch has been tested on Linux only.
>> > Steve
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> audacity-devel mailing list