Content-Type: multipart/alternative; boundary="------------090106010002090408020206" --------------090106010002090408020206 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Thanks for your input. I wasn't aware of all those differences of size_t on different platforms. Am 06.03.2013 07:46 schrieb Gale (Audacity Team): > Hi Sven > > I tried your patch on Mac OS X 10.8.2 but either in Debug Static > or Release Static I get two errors and one warning when building > in Xcode: > > /Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp: In member function > 'int AudioIO::StartStream(WaveTrackArray, WaveTrackArray, wxArrayLong, > TimeTrack*, double, double, double, AudioIOListener*, bool, double, > double)': > /Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp:1251: error: no > matching function for call to 'min(size_t, unsigned int&)' > /Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp:1252: error: no > matching function for call to 'min(size_t, unsigned int&)' Please change the according lines to: mCaptureRingBufferSecs = 4.5 + 0.5 * std::min(size_t(16), mCaptureMapping.GetCount()); mMinCaptureSecsToCopy = 0.2 + 0.2 * std::min(size_t(16), mCaptureMapping.GetCount()); > /Users/gale/Downloads/audacitysvn/mac/../src/toolbars/DeviceToolBar.cpp: In > member function 'void DeviceToolBar::FillInputChannels()': > /Users/gale/Downloads/audacitysvn/mac/../src/toolbars/DeviceToolBar.cpp:640: > warning: cannot pass objects of non-POD type 'class wxString' through '...'; > call will abort at runtime Thanks to Ragnar - he spotted this could be solved by removing the quotes around the name. Maybe this is even more flexible, since a name in the dropdown looks already different from the numbers and one could include the quotes in the naming in CFG file, if wanted. So please change this line to: mInputChannels->Append(gPrefs->Read(wxString::Format(wxT("/AudioIO/RecordProfile%d/Name"), j), wxString::Format(_("Profile %d"), j)), (void*)(unsigned int) j); I'll create another patch this evening... Sven. --------------090106010002090408020206 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Thanks for your input.
I wasn't aware of all those differences of size_t on different platforms.

Am 06.03.2013 07:46 schrieb Gale (Audacity Team):
Hi Sven 

I tried your patch on Mac OS X 10.8.2 but either in Debug Static
or Release Static I get two errors and one warning when building
in Xcode:

/Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp: In member function
'int AudioIO::StartStream(WaveTrackArray, WaveTrackArray, wxArrayLong,
TimeTrack*, double, double, double, AudioIOListener*, bool, double,
double)':
/Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp:1251: error: no
matching function for call to 'min(size_t, unsigned int&)'
/Users/gale/Downloads/audacitysvn/mac/../src/AudioIO.cpp:1252: error: no
matching function for call to 'min(size_t, unsigned int&)'
Please change the according lines to:
   mCaptureRingBufferSecs = 4.5 + 0.5 * std::min(size_t(16), mCaptureMapping.GetCount());
   mMinCaptureSecsToCopy = 0.2 + 0.2 * std::min(size_t(16), mCaptureMapping.GetCount());

/Users/gale/Downloads/audacitysvn/mac/../src/toolbars/DeviceToolBar.cpp: In
member function 'void DeviceToolBar::FillInputChannels()':
/Users/gale/Downloads/audacitysvn/mac/../src/toolbars/DeviceToolBar.cpp:640:
warning: cannot pass objects of non-POD type 'class wxString' through '...';
call will abort at runtime
Thanks to Ragnar - he spotted this could be solved by removing the quotes around the name. Maybe this is even more flexible, since a name in the dropdown looks already different from the numbers and one could include the quotes in the naming in CFG file, if wanted. So please change this line to:

mInputChannels->Append(gPrefs->Read(wxString::Format(wxT("/AudioIO/RecordProfile%d/Name"), j), wxString::Format(_("Profile %d"), j)), (void*)(unsigned int) j);

I'll create another patch this evening...


Sven.




--------------090106010002090408020206--