auc can be used by people around the world so using
ISO8601 is a good idea as has many advantages and is
easier to understand by people around the world.
Read about this wonderful date format at:
http://www.cl.cam.ac.uk/~mgk25/iso-time.html
Would you apply this patch ?
Most Western Europeans don't understand the cryptic
12-hour format.
Also not sorting digits by order of significance in
dates is difficult to read.
Logged In: NO
--- auc/calendar.c Sun Dec 3 22:35:03 2000
+++ auc/calendar.c Thu Nov 1 15:20:05 2001
@@ -208,7 +208,7 @@
MYSQL_ROW row;
char buf[512];
- snprintf(buf, sizeof(buf), "SELECT
DATE_FORMAT(\"%s\", \"%s\")", date, "%a, %b %d, %Y");
+ snprintf(buf, sizeof(buf), "SELECT
DATE_FORMAT(\"%s\", \"%s\")", date, "%Y-%m-%d");
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return NULL;
--- auc/course.c Sat Sep 29 04:55:10 2001
+++ auc/course.c Thu Nov 1 15:20:46 2001
@@ -937,7 +937,7 @@
char buf[512];
snprintf(buf, sizeof(buf), "SELECT text,
DATE_FORMAT(time, \"%s\") FROM \
- classannc WHERE idstr=\"%s\"", "%m/%d/%y %l:%i %p",
uniquestr);
+ classannc WHERE idstr=\"%s\"", "%Y-%m-%d %H:%M",
uniquestr);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return -1;
--- auc/directory.c Sun Dec 3 22:35:04 2000
+++ auc/directory.c Thu Nov 1 15:14:25 2001
@@ -319,7 +319,7 @@
cgiHeaderContentType("text/html");
snprintf(buf, sizeof(buf), "SELECT class, grp,
DATE_FORMAT(lastlogin, \"%s\") \
- FROM userinfo WHERE uname=\"%s\"", "%a, %d %b %Y,
%l:%i %p", extrapath);
+ FROM userinfo WHERE uname=\"%s\"", "%Y-%m-%d %H:%M",
extrapath);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return 0;
--- auc/discussion.c Sun Dec 3 22:35:04 2000
+++ auc/discussion.c Thu Nov 1 15:19:05 2001
@@ -104,7 +104,7 @@
char buf[1024];
snprintf(buf, sizeof(buf), "SELECT DATE_FORMAT(time,
\"%s\") FROM comments \
- WHERE discid=\"%s\" ORDER BY cid DESC LIMIT 1",
"%m/%d/%y %l:%i %p", discid);
+ WHERE discid=\"%s\" ORDER BY cid DESC LIMIT 1",
"%Y-%m-%d %H:%M", discid);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return;
@@ -127,7 +127,7 @@
snprintf(buf, sizeof(buf), "SELECT
discussions.discid, title, type, subtype, description, \
DATE_FORMAT(time, \"%s\"), hits FROM discussions %s \
- ORDER BY discussions.discid", "%a, %d %b %Y", where);
+ ORDER BY discussions.discid", "%Y-%m-%d %H:%M",
where);
if (mysql_query(db, buf))
aucError(mysql_error(db));
else {
@@ -272,7 +272,7 @@
cgiHeaderContentType("text/html");
snprintf(buf, sizeof(buf), "SELECT uname,
DATE_FORMAT(time,\"%s\"), comment FROM comments \
- WHERE discid=\"%s\" AND cid=\"%s\"", "%a, %d %b %Y,
%l:%i %p", discid, cid);
+ WHERE discid=\"%s\" AND cid=\"%s\"", "%Y-%m-%d
%H:%M", discid, cid);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return -1;
@@ -414,7 +414,7 @@
cgiHeaderContentType("text/html");
snprintf(buf, sizeof(buf), "SELECT discid, title,
type, subtype, description, \
DATE_FORMAT(time, \"%s\"), hits FROM discussions \
- WHERE discid=\"%s\"", "%a, %d %b %Y", extrapath);
+ WHERE discid=\"%s\"", "%Y-%m-%d", extrapath);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return 0;
@@ -471,7 +471,7 @@
snprintf(buf, sizeof(buf), "SELECT uname,
DATE_FORMAT(time,\"%s\"), comment, cid \
FROM comments WHERE discid=\"%s\" \
- ORDER BY cid DESC %s", "%a, %d %b %Y, %l:%i %p",
extrapath, code);
+ ORDER BY cid DESC %s", "%Y-%m-%d %H:%M", extrapath,
code);
if (mysql_query(db, buf)) {
aucError(mysql_error(db));
return 0;
--- auc/files.c Sun Sep 30 22:16:27 2001
+++ auc/files.c Thu Nov 1 15:24:57 2001
@@ -1570,7 +1570,7 @@
aucAuthGetFullName(buf, sizeof(buf), user,
NAME_LINK);
ltime = localtime(&create_time);
- strftime(timestr, sizeof(timestr), "%a, %d
%B %Y, %l:%M %P", ltime);
+ strftime(timestr, sizeof(timestr), "%Y-%m-%d
%H:%M", ltime);
fprintf(output, "<tr><td
colspan=3><blockquote>\n");
if (iswritable)
Logged In: NO
begin-base64 644 auc-cvs20011101_ISO8601.diff
LS0tIGF1Yy9jYWxlbmRhci5jCVN1biBEZWMgIDMgMjI6MzU6MDMgMjAwMAor
KysgYXVjL2NhbGVuZGFyLmMJVGh1IE5vdiAgMSAxNToyMDowNSAyMDAxCkBA
IC0yMDgsNyArMjA4LDcgQEAKIAlNWVNRTF9ST1cgcm93OwogCWNoYXIgYnVm
WzUxMl07CiAKLQlzbnByaW50ZihidWYsIHNpemVvZihidWYpLCAiU0VMRUNU
IERBVEVfRk9STUFUKFwiJXNcIiwgXCIlc1wiKSIsIGRhdGUsICIlYSwgJWIg
JWQsICVZIik7CisJc25wcmludGYoYnVmLCBzaXplb2YoYnVmKSwgIlNFTEVD
VCBEQVRFX0ZPUk1BVChcIiVzXCIsIFwiJXNcIikiLCBkYXRlLCAiJVktJW0t
JWQiKTsKIAlpZiAobXlzcWxfcXVlcnkoZGIsIGJ1ZikpIHsKIAkJYXVjRXJy
b3IobXlzcWxfZXJyb3IoZGIpKTsKIAkJcmV0dXJuIE5VTEw7Ci0tLSBhdWMv
Y291cnNlLmMJU2F0IFNlcCAyOSAwNDo1NToxMCAyMDAxCisrKyBhdWMvY291
cnNlLmMJVGh1IE5vdiAgMSAxNToyMDo0NiAyMDAxCkBAIC05MzcsNyArOTM3
LDcgQEAKIAljaGFyIGJ1Zls1MTJdOwogCiAJc25wcmludGYoYnVmLCBzaXpl
b2YoYnVmKSwgIlNFTEVDVCB0ZXh0LCBEQVRFX0ZPUk1BVCh0aW1lLCBcIiVz
XCIpIEZST00gXAotICAgICAgY2xhc3Nhbm5jIFdIRVJFIGlkc3RyPVwiJXNc
IiIsICIlbS8lZC8leSAlbDolaSAlcCIsIHVuaXF1ZXN0cik7CisgICAgICBj
bGFzc2FubmMgV0hFUkUgaWRzdHI9XCIlc1wiIiwgIiVZLSVtLSVkICVIOiVN
IiwgdW5pcXVlc3RyKTsKIAlpZiAobXlzcWxfcXVlcnkoZGIsIGJ1ZikpIHsK
IAkJYXVjRXJyb3IobXlzcWxfZXJyb3IoZGIpKTsKIAkJcmV0dXJuIC0xOwot
LS0gYXVjL2RpcmVjdG9yeS5jCVN1biBEZWMgIDMgMjI6MzU6MDQgMjAwMAor
KysgYXVjL2RpcmVjdG9yeS5jCVRodSBOb3YgIDEgMTU6MTQ6MjUgMjAwMQpA
QCAtMzE5LDcgKzMxOSw3IEBACiAKIAljZ2lIZWFkZXJDb250ZW50VHlwZSgi
dGV4dC9odG1sIik7CiAJc25wcmludGYoYnVmLCBzaXplb2YoYnVmKSwgIlNF
TEVDVCBjbGFzcywgZ3JwLCBEQVRFX0ZPUk1BVChsYXN0bG9naW4sIFwiJXNc
IikgXAotICAgICAgRlJPTSB1c2VyaW5mbyBXSEVSRSB1bmFtZT1cIiVzXCIi
LCAiJWEsICVkICViICVZLCAlbDolaSAlcCIsIGV4dHJhcGF0aCk7CisgICAg
ICBGUk9NIHVzZXJpbmZvIFdIRVJFIHVuYW1lPVwiJXNcIiIsICIlWS0lbS0l
ZCAlSDolTSIsIGV4dHJhcGF0aCk7CiAJaWYgKG15c3FsX3F1ZXJ5KGRiLCBi
dWYpKSB7CiAJCWF1Y0Vycm9yKG15c3FsX2Vycm9yKGRiKSk7CiAJCXJldHVy
biAwOwotLS0gYXVjL2Rpc2N1c3Npb24uYwlTdW4gRGVjICAzIDIyOjM1OjA0
IDIwMDAKKysrIGF1Yy9kaXNjdXNzaW9uLmMJVGh1IE5vdiAgMSAxNToxOTow
NSAyMDAxCkBAIC0xMDQsNyArMTA0LDcgQEAKIAljaGFyIGJ1ZlsxMDI0XTsK
IAogCXNucHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJTRUxFQ1QgREFURV9G
T1JNQVQodGltZSwgXCIlc1wiKSBGUk9NIGNvbW1lbnRzIFwKLSAgICAgIFdI
RVJFIGRpc2NpZD1cIiVzXCIgT1JERVIgQlkgY2lkIERFU0MgTElNSVQgMSIs
ICIlbS8lZC8leSAlbDolaSAlcCIsIGRpc2NpZCk7CisgICAgICBXSEVSRSBk
aXNjaWQ9XCIlc1wiIE9SREVSIEJZIGNpZCBERVNDIExJTUlUIDEiLCAiJVkt
JW0tJWQgJUg6JU0iLCBkaXNjaWQpOwogCWlmIChteXNxbF9xdWVyeShkYiwg
YnVmKSkgewogCQlhdWNFcnJvcihteXNxbF9lcnJvcihkYikpOwogCQlyZXR1
cm47CkBAIC0xMjcsNyArMTI3LDcgQEAKIAogCXNucHJpbnRmKGJ1Ziwgc2l6
ZW9mKGJ1ZiksICJTRUxFQ1QgZGlzY3Vzc2lvbnMuZGlzY2lkLCB0aXRsZSwg
dHlwZSwgc3VidHlwZSwgZGVzY3JpcHRpb24sIFwKICAgICAgIERBVEVfRk9S
TUFUKHRpbWUsIFwiJXNcIiksIGhpdHMgRlJPTSBkaXNjdXNzaW9ucyAlcyBc
Ci0gICAgICBPUkRFUiBCWSBkaXNjdXNzaW9ucy5kaXNjaWQiLCAiJWEsICVk
ICViICVZIiwgd2hlcmUpOworICAgICAgT1JERVIgQlkgZGlzY3Vzc2lvbnMu
ZGlzY2lkIiwgIiVZLSVtLSVkICVIOiVNIiwgd2hlcmUpOwogCWlmIChteXNx
bF9xdWVyeShkYiwgYnVmKSkKIAkJYXVjRXJyb3IobXlzcWxfZXJyb3IoZGIp
KTsKIAllbHNlIHsKQEAgLTI3Miw3ICsyNzIsNyBAQAogCWNnaUhlYWRlckNv
bnRlbnRUeXBlKCJ0ZXh0L2h0bWwiKTsKIAogCXNucHJpbnRmKGJ1Ziwgc2l6
ZW9mKGJ1ZiksICJTRUxFQ1QgdW5hbWUsIERBVEVfRk9STUFUKHRpbWUsXCIl
c1wiKSwgY29tbWVudCBGUk9NIGNvbW1lbnRzIFwKLSAgICAgIFdIRVJFIGRp
c2NpZD1cIiVzXCIgQU5EIGNpZD1cIiVzXCIiLCAiJWEsICVkICViICVZLCAl
bDolaSAlcCIsIGRpc2NpZCwgY2lkKTsKKyAgICAgIFdIRVJFIGRpc2NpZD1c
IiVzXCIgQU5EIGNpZD1cIiVzXCIiLCAiJVktJW0tJWQgJUg6JU0iLCBkaXNj
aWQsIGNpZCk7CiAJaWYgKG15c3FsX3F1ZXJ5KGRiLCBidWYpKSB7CiAJCWF1
Y0Vycm9yKG15c3FsX2Vycm9yKGRiKSk7CiAJCXJldHVybiAtMTsKQEAgLTQx
NCw3ICs0MTQsNyBAQAogCWNnaUhlYWRlckNvbnRlbnRUeXBlKCJ0ZXh0L2h0
bWwiKTsKIAlzbnByaW50ZihidWYsIHNpemVvZihidWYpLCAiU0VMRUNUIGRp
c2NpZCwgdGl0bGUsIHR5cGUsIHN1YnR5cGUsIGRlc2NyaXB0aW9uLCBcCiAg
ICAgICBEQVRFX0ZPUk1BVCh0aW1lLCBcIiVzXCIpLCBoaXRzIEZST00gZGlz
Y3Vzc2lvbnMgXAotICAgICAgV0hFUkUgZGlzY2lkPVwiJXNcIiIsICIlYSwg
JWQgJWIgJVkiLCBleHRyYXBhdGgpOworICAgICAgV0hFUkUgZGlzY2lkPVwi
JXNcIiIsICIlWS0lbS0lZCIsIGV4dHJhcGF0aCk7CiAJaWYgKG15c3FsX3F1
ZXJ5KGRiLCBidWYpKSB7CiAJCWF1Y0Vycm9yKG15c3FsX2Vycm9yKGRiKSk7
CiAJCXJldHVybiAwOwpAQCAtNDcxLDcgKzQ3MSw3IEBACiAKIAlzbnByaW50
ZihidWYsIHNpemVvZihidWYpLCAiU0VMRUNUIHVuYW1lLCBEQVRFX0ZPUk1B
VCh0aW1lLFwiJXNcIiksIGNvbW1lbnQsIGNpZCBcCiAgICAgICBGUk9NIGNv
bW1lbnRzIFdIRVJFIGRpc2NpZD1cIiVzXCIgXAotICAgICAgT1JERVIgQlkg
Y2lkIERFU0MgJXMiLCAiJWEsICVkICViICVZLCAlbDolaSAlcCIsIGV4dHJh
cGF0aCwgY29kZSk7CisgICAgICBPUkRFUiBCWSBjaWQgREVTQyAlcyIsICIl
WS0lbS0lZCAlSDolTSIsIGV4dHJhcGF0aCwgY29kZSk7CiAJaWYgKG15c3Fs
X3F1ZXJ5KGRiLCBidWYpKSB7CiAJCWF1Y0Vycm9yKG15c3FsX2Vycm9yKGRi
KSk7CiAJCXJldHVybiAwOwotLS0gYXVjL2ZpbGVzLmMJU3VuIFNlcCAzMCAy
MjoxNjoyNyAyMDAxCisrKyBhdWMvZmlsZXMuYwlUaHUgTm92ICAxIDE1OjI0
OjU3IDIwMDEKQEAgLTE1NzAsNyArMTU3MCw3IEBACiAJCQogCQlhdWNBdXRo
R2V0RnVsbE5hbWUoYnVmLCBzaXplb2YoYnVmKSwgdXNlciwgTkFNRV9MSU5L
KTsKIAkJbHRpbWUgPSBsb2NhbHRpbWUoJmNyZWF0ZV90aW1lKTsKLQkJc3Ry
ZnRpbWUodGltZXN0ciwgc2l6ZW9mKHRpbWVzdHIpLCAiJWEsICVkICVCICVZ
LCAlbDolTSAlUCIsIGx0aW1lKTsKKwkJc3RyZnRpbWUodGltZXN0ciwgc2l6
ZW9mKHRpbWVzdHIpLCAiJVktJW0tJWQgJUg6JU0iLCBsdGltZSk7CiAJCWZw
cmludGYob3V0cHV0LCAiPHRyPjx0ZCBjb2xzcGFuPTM+PGJsb2NrcXVvdGU+
XG4iKTsKIAkJCiAJCWlmIChpc3dyaXRhYmxlKQo=
====