Switch from old PCRE to actively maintained PCRE2
advanced tftp server and client
Brought to you by:
khorniszon,
md11
Hi,
atftp (tftpd_pcre.h) is linked to the old PCRE library. That version of PCRE is now at end of life, and is no longer being actively maintained. C.f. https://pcre.org/ and the bug reported in https://bugs.debian.org/1000071 for Debian for more information. I guess we need to switch to the newer version PCRE2 sooner or later.
Best regards, Andi
Latest patch is available here: https://salsa.debian.org/debian/atftp/-/blob/master/debian/patches/pcre2.patch
Hello Andi,
I read your notice and already started investigating how to convert to PCRE2. After some hours/days I found that my programming knowledge is not high enough to manage this on my own.
So I am very pleased and surprised that you did that already and I am really looking forward to test and integrate the results in the next few days!!!!
Greetings / Martin
Hi Martin,
I am still working on the integration into the autoconf/configure build environment. After cleaning up and building in a minimal chroot environment for packaging, I found that PCRE is not enabled because it seems not be detected correctly.
I am still investigating but it looks like I need to learn a bit about autotools and the like first :-)
Best regards, Andi
Hi,
I have managed the detection by autoconf already. I will share my findings here today in the evening (in approx. 5-6 hours) - have no time for this just now. Or better, I open a feature-development-branch in the git here, okay? and commit my stuff, so you can see what I did.
Great, it works here too now. The patch should be up to date now and I uploaded the package, but perhaps your solution is better. Thanks!
I guess this bug can now be closed.
Hey Andi , Martin , i am seeing the similar issue where my pcre2 methods are not getting detected and am seeing" undefined reference to pcre2_match_data_create_from_pattern_'" issues and many others , as the original git has the pcre support https://sourceforge.net/projects/atftp/files/ . I wanted to check how do you guys have resolved this issue in here. I tried to add pcre2.h from https://github.com/php/php-src/blob/master/ext/pcre/pcre2lib/pcre2.h but it didnt worked for me