Menu

#1 snprintf with len=256 into buffer with len=80

1.06
closed
nobody
None
5
2014-05-27
2007-10-07
Dan Horak
No

There is a bug which comes out when atasm is compiled with buffer overflow checking. In function get_expression() from setparse.c there is a snprintf call with max length = 256 into a buffer with length of 80 chars.

The result of running atasm:

./atasm ../tests/testraw.m65
ATasm 1.05 beta (A mostly Mac65 compatible 6502 cross-assembler)
Pass 1: *** buffer overflow detected ***: ./atasm terminated
======= Backtrace: =========
...

A fix is attached.

PS: This is a result of a package preparation for Fedora Linux.

Related

Bugs: #19

Discussion

  • Dan Horak

    Dan Horak - 2007-10-07

    patch to solve buffer overflow in setparse.c

     
  • schmelze

    schmelze - 2014-05-26
    • status: open --> closed
    • Group: --> v1.0 (example)
     
  • schmelze

    schmelze - 2014-05-26

    Fixed in r63, version 1.06

     
  • schmelze

    schmelze - 2014-05-27
    • Group: 1.00 --> 1.06
     

Log in to post a comment.

MongoDB Logo MongoDB