atanks Code changes

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 12:51:10 -0000

This sourceforge editor is driving me nuts... ^^

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 12:50:44 -0000

Description:

Diff:

--- old
+++ new
@@ -13,7 +13,7 @@
 * Fixed a bug that caused the AI to use the first guess on their last attack planning attempt without actually planning it through.
 * Fixed a bug that could cause a segfault when fast-forward-play ends.

-&#39;&#39;Additions:**
+**Additions:**

 * The Makefile got some debugging targets for easier debug mode building.
 * Random number generation has been modernized and was made thread local.

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 12:50:32 -0000

Description:

Diff:

--- old
+++ new
@@ -8,11 +8,12 @@
 * Fixed a bug that allowed AI players to have a ton of amps but no armour and vice versa.
 * Remove C89 style TRUE/FALSE integers where possible.
 * Fixed typo: Swapper costs 4 grand, not 40k.
-* Fixed a bug that caused AI to ignore 90% of the items they might have wanted to save their money on. just to shoot a Riot Bomb anywhere.
+* Fixed a bug that caused AI to ignore 90% of the items they might have wanted to save their money on.
+* Fixed a bug that caused the AI to break off their attack planning early  just to shoot a Riot Bomb anywhere.
 * Fixed a bug that caused the AI to use the first guess on their last attack planning attempt without actually planning it through.
 * Fixed a bug that could cause a segfault when fast-forward-play ends.

-**Additions:**
+&#39;&#39;Additions:**

 * The Makefile got some debugging targets for easier debug mode building.
 * Random number generation has been modernized and was made thread local.
@@ -20,7 +21,8 @@

 **Changes:**

-* Source code is now formatted uniformly using clang-format. performance is non-critical).
+* Source code is now formatted uniformly using clang-format.
+* Got rid of C90 style pointer juggling where possible (aka where performance is non-critical).
 * Bot values have been lowered and the spread between worst and best AI player has been increased. The DEADLY player is also no longer immune to making errors.
 * SDI will no longer shoot a missile down that is going to be repulsed.
 * Some recursive functions have been rewritten to be non.recursive.

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 12:26:15 -0000

Description:

Diff:

--- old
+++ new
@@ -1,17 +1,35 @@
-Hey Jesse,
-I have taken the liberty of upgrading the code vastly, making it C++17 ready, and fixing a handful of bugs on the way. I also split up some of the overly long spaghetti code into maintainable portions.
+**Fixes:**

-There are two more things, however, I&#39;d like to take care of before the merge.
-But I figured it would be a good idea to let you have a look already.
+* Fixed a bug that caused background updates to glitch.
+* Added missing Theft Bomb missile image, that caused an assertion failure whenever someone tried to shoot one.
+* Fixed all g++ and clang-tidy warnings.
+* Fixed a bug where global.surface was being used as height instead of the surface y-coordinate.
+* Fixed a bug in land creation that caused possible crashes.
+* Fixed a bug that allowed AI players to have a ton of amps but no armour and vice versa.
+* Remove C89 style TRUE/FALSE integers where possible.
+* Fixed typo: Swapper costs 4 grand, not 40k.
+* Fixed a bug that caused AI to ignore 90% of the items they might have wanted to save their money on. just to shoot a Riot Bomb anywhere.
+* Fixed a bug that caused the AI to use the first guess on their last attack planning attempt without actually planning it through.
+* Fixed a bug that could cause a segfault when fast-forward-play ends.

-When I have taken care of the following issues, I will write a detailed changelog here.
+**Additions:**

-1) Currently the Bots like to senselessly throw Riot Bombs around, even when it makes absolutely makes no sense and a clear firing path would be open. In the next few days I will try to isolate and tackle this issue.
+* The Makefile got some debugging targets for easier debug mode building.
+* Random number generation has been modernized and was made thread local.
+* Beautified land and moon creation.

-2) Some items are not used at all, like teleporters and the rocket. I&#39;d like to know why and to add (sensible) usage of these items.
+**Changes:**

-Something else: The game crashed whenever the Theft Bomb was chosen, because &#34;missile/31.bmp&#34; does not exist. Do you have it lying around? If not I would &#34;repurpose&#34; the stock image bmp for the Theft Bomb.
-
-Cheers
-
-Sven
+* Source code is now formatted uniformly using clang-format. performance is non-critical).
+* Bot values have been lowered and the spread between worst and best AI player has been increased. The DEADLY player is also no longer immune to making errors.
+* SDI will no longer shoot a missile down that is going to be repulsed.
+* Some recursive functions have been rewritten to be non.recursive.
+* Some &#34;spaghetti-code&#34; style functions have been split up.
+* Many C++17 perks have been made use of where they make sense.
+* Got rid of sscanf(). Everywhere.
+* Decoupled many objects that deserved their own compilation unit.
+* SDI repulsor calculation is now independent from AI level of its owner.
+* Enhance armour/amp/weapon boosting, so that AI players no longer forget what they wanted to buy (but couldn&#39;t) between rounds.
+* The maximum SDI range calculation has been rewritten, and the repulsor shields have been strengthened a bit.
+* AI takes target level and already dealt damage ratios more into account. This stops the bots to get &#34;stuck&#34; on a (mainly human) opponent.
+* AI does not longer know the exact coordinates of their opponent, but &#34;drift&#34; a bit according to their level.

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 11:15:16 -0000

Found and fixed it. Squashed the fix into an earlier commit, though. (It was about knowing when the real lat attempt was going on)

For over 50 rounds the bots did not get "stuck" on attacking me first any more, so people complaining about "never" getting to play should have their well deserved fix now. The bots really could get a bit .. erm... attached.

I'll whip up a ChangeLog soon.

Merge request: Big overhaul and many fixes

Sven Eden — Wed, 09 Aug 2023 10:29:03 -0000

Yeah... your changes made the AI, even the supposedly "DEADLY" one, dumb as rock. (sorry.)

I think I remedied that by a few changes that made the USELESS to DEADLY curve steeper, while adding new error potential and countering situations where bots get "fixed" on one target (mostly human players). And I did not fully revert your changes, the limits are now generally lower and more spread out between USELESS and DEADLY bots.

There is one odd thing I witnessed, a bot just slammed a Death Head senselessly into a steel-cage wall. Out of frustration, I guess, they couldn't get nowhere, but a 30k ordnance is a bit expensive.

Once I have fixed what caused this, I think I am ready for the final "ChangeLog" presentation.

Merge request: Big overhaul and many fixes

Jesse Smith — Tue, 08 Aug 2023 17:11:06 -0000

I checked and I don't have a missle/31.bmp file. I sppose you could toss any appropriate bomb image in there and it'll do the trick.

Something to keep in mind with regards to your point #1 is that the AI isn't supposed to be perfect. With the last release I ended up making some changes to the AI code which both reduced CPU time and made the AI less precise because it was always shooting perfectly, even the low-level bots, which made the game not fun at all. The AI should made some bad choices and mistakes.

Merge request: Big overhaul and many fixes

Sven Eden — Tue, 08 Aug 2023 16:42:12 -0000

I think that's it.
A bit more testing, and if everything is alright, I'll update the description with a (hopefully) complete ChangeLog.

Merge request: Big overhaul and many fixes

Sven Eden — Tue, 08 Aug 2023 08:26:28 -0000

I think the overhaul is almost ready. I haven't seen any stupid shots into walls for a couple of rounds, but will continue to test some more.

Cleanup and fix addUpdateArea() in virtobj.*

Sven Eden — Tue, 01 Aug 2023 11:13:52 -0000

Cleanup and fix addUpdateArea() in virtobj.*
View Changes