Menu

#3 Some suggestions / minor bugs

Components
open
nobody
Test (1)
5
2007-08-13
2007-08-13
No

First of all: It's a great library.

But I've some small hints - related to AfViewers.pas (release 1.04):

- TAfTerminal does not publish property "LineCount"

- In "TAfCustomTerminal.SetOptions" the passed options are overwritten with the default values.

Why? I see no reason to do so!
Here, I commented the first 2 lines out.

- In "TAfCustomLineViewer.KeyDown" the line:

SetFocusedAndSelect(NewFocus, ssShift in Shift);

..is wrong. Correct is:

SetFocusedAndSelect(NewFocus,
((loSelectByShift in FOptions) and
(ssShift in Shift)) or
(not (loSelectByShift in FOptions)));

- In "TAfCustomLineViewer.MouseDown" is another small bug when you want to select without the shift-key:

FMouseDown := True;
FocusByMouse(X, Y, ((loSelectByShift in FOptions) and
(ssShift in Shift)));

..inside the if-condition needs to be changed to:

FMouseDown := True;
if not (loSelectByShift in FOptions) then
SetFocusedAndSelect(MouseToPoint(X, Y), false);
FocusByMouse(X, Y, ((loSelectByShift in FOptions) and
(ssShift in Shift)) or
(not (loSelectByShift in FOptions)) );

Rgds,
Michael

Discussion


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.