|
From: Darren C. <da...@dc...> - 2006-03-06 05:17:57
|
Hi Luke, Thanks for the reply. > The file in question is located in > framework/as2/com/asunit/framework/TestRunner.as > > The TestRunner.push method is called from framework/Assert.as inside of > addTestResult, which is called from the body of every Assert method (like > assertTrue). OK, I see. Yes, it looks like the change should be quite straightforward. For proof-of-concept I'll try just replacing that whole file. (See P.S. for comments/questions on existing code.) > Ideally, you should be able to extend a base class "TestRunner", and then > users could choose where to send output... The File System, Local > Connection, Trace, an XML Socket, SMS, Email, etc... Yes. > My understanding is that there are at least 4 or 5 people interested in this > feature and at least 3 of them seem to be working on it right now. > > Can I get a roll call for those of you that are in fact interested in > getting the AS 2.0 build to support multiple test runners? > > Of those of you that raised your hands how many have already implemented it? > Or are willing to get it implemented? I'm willing to work on an XML sockets version, with a PHP back-end. Darren P.S. http://svn.sourceforge.net/viewcvs.cgi/asunit/trunk/framework/as2/com/asunit/framework/TestRunner.as?view=markup&rev=2 I think the renderTests(arr:Array) function should be changed to renderTests(Void), and then change: lc["addTests"](arr); tests = new Array(); to read: lc["addTests"](tests); tests = new Array(); The reason is simply that this.tests gets reset so passing in anything other than this.tests is dangerous. While there I think renderTests() and getLocalConn() can be changed from public to private: no other classes seem to call them. addSuccess() and addFailure() don't seem to be called from anywhere at all. What are they for, and do they need to be part of the public interface? |