#2 use `printf' instead of `echo'

closed-accepted
nobody
None
5
2001-11-22
2001-08-27
No

$(ASTROSROUCE)/source/Makefile uses `echo -ne'. The
`e' options is GNU echo specific. I suggest using
`printf' over `echo'. A patch is uploaded.

Discussion

  • IKEDA Shigeru

    IKEDA Shigeru - 2001-08-27
     
  • IKEDA Shigeru

    IKEDA Shigeru - 2001-08-27

    Logged In: YES
    user_id=287299

    <pre>
    --- Makefile 2001/08/27 22:27:47 1.1
    +++ Makefile 2001/08/27 22:27:54
    @@ -21,10 +21,10 @@
    touch $@

    resource.h: $(TARGET).rcp ../lib/bar.bmp ../lib/icon.bmp
    ../lib/icong.bmp ../lib/iconc.bmp
    - echo >$@
    + printf "\n" >$@
    $(PILRC) -h $@ $(TARGET).rcp
    - echo -ne '$(APPID)' > APPL0001.bin
    - echo -ne '$(VERSION)\000' > tver0001.bin
    + printf '$(APPID)' > APPL0001.bin
    + printf "$(VERSION)\000" > tver0001.bin

    $(TARGET): $(OBJS) Makefile
    $(CC) $(CFLAGS) $(OBJS) $(TARGET)-sections.ld -o $@
    </pre>

     
  • Jochen Hoenicke

    Jochen Hoenicke - 2001-08-28

    Logged In: YES
    user_id=18252

    I have applied the patch to the CVS.

     
  • Jochen Hoenicke

    Jochen Hoenicke - 2001-08-28
    • milestone: 101892 -->
    • status: open --> open-accepted
     
  • IKEDA Shigeru

    IKEDA Shigeru - 2001-08-28

    Logged In: YES
    user_id=287299

    Astro info 2.3.1 has built on both NetBSD-1.5.1/i386 and
    OpenBSD-2.9/i386 successfully with this modification.

     
  • Jochen Hoenicke

    Jochen Hoenicke - 2001-11-22
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks