From: Lonnie A. <li...@lo...> - 2018-11-02 13:39:31
|
Hi David, I looked over the changes more than once and did not see any cases where a trailing space was needed or intended. Your IFS example is a valid possibility, but we don't have any of those. Anyone, feel free to look over the the Github Commit Compare below. Lonnie > On Nov 2, 2018, at 8:24 AM, David Kerr <Da...@Ke...> wrote: > > Nice piece of cleanup. My first thought was did you check for any cases where a trailing space is actually required. For example > IFS=' > ' > which makes space and newline the separator. I don't know if we have any of those, and if we do it is probably bad practice anyway. > > David > > > On Fri, Nov 2, 2018 at 9:15 AM Lonnie Abelbeck <li...@lo...> wrote: > Hi Devs, > > Yesterday I cleaned-up trailing spaces in our scripts, many years of copy/paste'ing and an old Busybox "vi" auto-indent "feature". > > scripts, remove trailing spaces, cosmetic, no functional change > https://github.com/astlinux-project/astlinux/compare/c7ab5b16f26e...f7d41203769f > > In general this should not effect anyone. > > But, if by chance you maintain a patch referencing the astlinux github repository, these space removals could break patches, PR's, etc. . If that happens, remove such trailing spaces in your custom script changes by using sed "in-place" ... > > $ sed -i 's/ *$//' custom_astlinux_script > > Alternatively, if you are using "vi", search using '/ *$' to find any trailing spaces. > > Lonnie |