From: Lonnie A. <li...@lo...> - 2018-01-07 20:39:53
|
Added ... asterisk, init.d script, add extra default CDR fields... https://github.com/astlinux-project/astlinux/commit/b38ffb22e947ac25a768d13218d448bd7d583b85 Lonnie On Jan 7, 2018, at 9:34 AM, Lonnie Abelbeck <li...@lo...> wrote: > Hi Michael, > > Interesting, Asterisk 11.25.3 properly fills in the following using cdr_adaptive_odbc.so > -- > 'answer' TEXT > 'end' TEXT > 'linkedid' TEXT > 'peeraccount' TEXT > 'sequence' TEXT > -- > Tip -> Use "module reload cdr_adaptive_odbc.so" to apply any SQL table changes. > > I guess it is simpler for users/admins to delete unused columns/fields rather than add them using the SQL-Data tab, so adding these 5 fields by default is probably a good thing. > > BTW, this only effects new installs when /mnt/kd/cdr-sqlite3/cdr-odbc.sqlite3 does not exist. > >> How would you plan on them being added by an administrator? All manual? > > SQL-Data tab -> CDR ODBC -> [table] cdr -> Structure > > There you can add and delete CDR columns/fields . > > Lonnie > > > On Jan 7, 2018, at 1:34 AM, Michael Knill <mic...@ip...> wrote: > >> Thanks Lonnie >> >> I don't see any reason why you wouldn't create all the fields for 11 as well so you don't need to add them later. >> Happy for actual fields created to be customised but it's a bit harder when that have already been created in init.d. >> How would you plan on them being added by an administrator? All manual? >> >> Regards >> Michael Knill >> >> -----Original Message----- >> From: Lonnie Abelbeck <li...@lo...> >> Reply-To: AstLinux Developers Mailing List <ast...@li...> >> Date: Sunday, 7 January 2018 at 3:57 pm >> To: AstLinux Developers Mailing List <ast...@li...> >> Subject: Re: [Astlinux-devel] CDR Table for Asterisk 13 >> >> Hi Michael, >> >> Perfectly clear now, without the default /mnt/kd/cdr-sqlite3/cdr-odbc.sqlite3 containing all the fields, the cdr_adaptive_odbc.conf will skip those missing fields. >> >> So, the missing fields are: >> -- >> 'answer' TEXT >> 'end' TEXT >> 'linkedid' TEXT >> 'peeraccount' TEXT >> 'sequence' REAL >> -- >> agree ? >> all 5 appended at the end of the current fields ? >> >> Hmmm, I wonder if these added fields should also be included for initial Asterisk 11 installations so later upgrades to Asterisk 13 will populate the added fields ? >> >> The drawback is these 5 extra fields, would all be empty in Asterisk 11 and the full "cdr" SQL-Data tab would not be very pretty. >> >> Do Asterisk 13 users always want all 5 extra fields ? Possibly we should simply allow users (administrators) add the fields they want with Asterisk 13 ? >> >> Comments ? >> >> Lonnie >> >> >> >> On Jan 6, 2018, at 9:57 PM, Michael Knill <mic...@ip...> wrote: >> >>> So sorry Lonnie for not being clear. >>> This is when you are logging to sqlight3. You create the database and table on startup in init.d/asterisk if cdr-odbc.sqlite3 is not there. >>> Im thinking however that init.d/asterisk should add the extra fields into the created database table if the Asterisk version is > 12. >>> >>> Regards >>> Michael Knill >>> -----Original Message----- >>> From: Lonnie Abelbeck <li...@lo...> >>> Reply-To: AstLinux Developers Mailing List <ast...@li...> >>> Date: Sunday, 7 January 2018 at 7:11 am >>> To: AstLinux Developers Mailing List <ast...@li...> >>> Subject: Re: [Astlinux-devel] CDR Table for Asterisk 13 >>> >>> Hi Michael, >>> >>> AFAIF, all the CDR logged fields are a part of of you asterisk *.conf files. >>> >>> If not, please explain in the finest detail so I understand. >>> >>> Lonnie >>> >>> >>> >>> On Jan 6, 2018, at 2:04 PM, Michael Knill <mic...@ip...> wrote: >>> >>>> Hi Lonnie >>>> >>>> Unfortunately, because of the change to the way CDR’s are generated, the new fields are important. >>>> Would it be possible in init.d/asterisk to check the Asterisk version and add the extra fields when using >12. >>>> >>>> What do you think? >>>> >>>> Regards >>>> Michael Knill >>>> >>>> Sent from my iPhone so please excuse my brevity. >>>> >>>>> On 7 Jan 2018, at 12:29 am, Lonnie Abelbeck <li...@lo...> wrote: >>>>> >>>>> >>>>>> On Jan 5, 2018, at 9:25 PM, Michael Knill <mic...@ip...> wrote: >>>>>> >>>>>> Hi Devs >>>>>> >>>>>> I have recently found out that a number of Asterisk CDR changes were made in Asterisk 12 including a number of new CDR fields: >>>>>> https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CDR+Specification >>>>>> >>>>>> We will therefore need to update the automatically created cdr schema to add the new fields! >>>>>> >>>>>> Regards >>>>>> Michael Knill >>>>> >>>>> Michael, is this a question or comment ? >>>>> >>>>> Yes the Asterisk CDR innards were changed with Asterisk 12-13, but are basically backward compatible with the Asterisk 11 configs. >>>>> >>>>> Lonnie >> >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Astlinux-devel mailing list >> Ast...@li... >> https://lists.sourceforge.net/lists/listinfo/astlinux-devel >> >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Astlinux-devel mailing list >> Ast...@li... >> https://lists.sourceforge.net/lists/listinfo/astlinux-devel > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Astlinux-devel mailing list > Ast...@li... > https://lists.sourceforge.net/lists/listinfo/astlinux-devel |