Re: [Asterisk-java-users] Patch to DefaultManagerConnection

[Stefan R. <sr...@re...>]

> To be honest, I don't quite understand the purpose of having a public
> and an internal action id. The internal should be enough, providing tha=
t
> it can be used for matching subsequent events.

There are two reasons for that:
1. I don't like A-J silently modifying user objects such as actions when
not strictly necessary.
2. The user's code must know the action id before sendAction(..)
returns. If it doesn't a custom event- or responselistener can only be
informed about the action id after the action has been sent to asterisk.
In this case there is a chance that the user's code misses the event or
response (if it is received before the action id was passed to the
listener). With the user provided action id the listener can be informed
before the action is sent and there is no way to miss anything.

> It probably doesn't do any harm, but I think some additional
> documentation is required on the method to explain its use.

Yeah I will update the docs for set/getActionId.

> Having said that I still suspect that there is something dodgy with
> sendEventGeneratingAction as I've had OriginateCall hang on me.
> I will have a try at reproducing the problem when I have a moment. Mayb=
e
> now that I understand how to use the code base the problem may disappea=
r :)

Ok, if you find a bug i am happy to fix it :)

Based upon your experience with moving AsterFax to 0.3 you think 0.3 is
ready for a release candidate?

=3DStefan

--=20
reuter network consulting
Neusser Str. 110
50760 K=F6ln
Germany
Telefon: +49 221 1305699-0
Telefax: +49 221 1305699-90
E-Mail:  sr...@re...
Jabber:  sr...@ja...