Re: [Asterisk-java-users] Patch to DefaultManagerConnection

[Brett S. <bs...@no...>]

Mis-understanding on my part.

OK, I reverted my code changes to the standard 0.3 code base and set the 
action id explicitly. I had got so caught up in the detail that I didn't 
release that I could set and retrieve the action id.
To be honest, I don't quite understand the purpose of having a public 
and an internal action id. The internal should be enough, providing that 
it can be used for matching subsequent events. The only purpose I can 
image for an externally settable action id is to pass 'User Data' to the 
subsequent events and this is probably a fairly marginal use case.
It probably doesn't do any harm, but I think some additional 
documentation is required on the method to explain its use. I went in 
assuming that setActionId was really a private method (yes I know its 
defined as a public method, but that sometimes just means its users are 
in a different package) and that getActionId would always return a good 
value. When it returned null I assumed that there was a bug and went 
about fixing it :<.

So I'm now using it as intended and all works fine.

Having said that I still suspect that there is something dodgy with 
sendEventGeneratingAction as I've had OriginateCall hang on me.
I will have a try at reproducing the problem when I have a moment. Maybe 
now that I understand how to use the code base the problem may disappear :)

Regards,
Brett.