Re: [Asterisk-java-devel] ManagerEvent uniqueid
Brought to you by:
srt
Menu
▾
▴
Re: [Asterisk-java-devel] ManagerEvent uniqueid
|
From: Enguerrand de R. <eng...@el...> - 2015-07-01 08:42:52
|
Pull request updated as per previous mail ------------------------------------------------------------------------------------ Dipl.-Ing. Enguerrand de Rochefort Softwareentwickler mailto:eng...@el... Tel: +49-241-566266-72 Fax: +49-241-566266-29 -----Ursprüngliche Nachricht----- Von: Enguerrand de Rochefort [mailto:eng...@el...] Gesendet: Mittwoch, 1. Juli 2015 09:50 An: ast...@li... Betreff: Re: [Asterisk-java-devel] ManagerEvent uniqueid Hi Brett thanks for the input, so I'll get rid of the final modifiers. I really only introduced them to simplify the task of identifying the overrides. And I think I'll leave the uniqueid where it is until it actually causes problems for me. It just would have felt clean to move it up as it would have reduced duplicate code... Cheers Enguerrand ------------------------------------------------------------------------------------ Dipl.-Ing. Enguerrand de Rochefort Softwareentwickler mailto:eng...@el... Tel: +49-241-566266-72 Fax: +49-241-566266-29 -----Ursprüngliche Nachricht----- Von: Brett Sutton [mailto:bs...@no...] Gesendet: Mittwoch, 1. Juli 2015 01:52 An: ast...@li... Betreff: Re: [Asterisk-java-devel] ManagerEvent uniqueid Actually just had a chat with one of our devs and we are currently overloading user event setters. On 01/07/15 09:38, Brett Sutton wrote: > Enguerrand, > I can't see any problems with moving the unique id to the manager > event except that perhaps it could be misleading. Misleading in the > sense that I see an event has a unique id when in fact it doesn't. > > I'm also a little hesitant about marking all of the getter/setters as > final. I understand the logic but I'm always reluctant to exclude > others from extending classes. > > An obvious usage of overloading the setter to action another piece of > logic based on what value the setter gets called with. > > What are other peoples thoughts? > > Brett > > On 01/07/15 00:44, Enguerrand de Rochefort wrote: >> Hi all, >> >> I am currently trying to clean up the ManagerEvent class hierarchy a bit. There are many members / getters / setters that are uselessly overridden [1], which is giving me trouble when serializing the events to json with GSon. >> >> I noted that many events have a field uniqueid, but ManagerEvent does not have this field. My gut feeling is that uniqueid can safely be moved to ManagerEvent... can anyone think of a reason not to do that? >> >> Cheers >> Enguerrand >> >> [1] Also see my pull request #64: >> https://github.com/asterisk-java/asterisk-java/pull/64 >> >> >> --------------------------------------------------------------------- >> --------------- >> Dipl.-Ing. Enguerrand de Rochefort >> Softwareentwickler >> mailto:eng...@el... >> Tel: +49-241-566266-72 >> Fax: +49-241-566266-29 >> >> ELARA Leitstellentechnik GmbH Member of Frequentis Group >> Schloss-Rahe-Str. 19a 52072 Aachen Geschäftsführender Gesellschafter: >> Dr.-Ing. Frank Herzog Geschäftsführer: Dipl.-Ing. Hans Werner Güntzel >> Amtsgericht Aachen HRB 17856 St.-Nr.: 201/5956/4218 USt-IdNr.: DE 285 >> 827 521 >> --------------------------------------------------------------------- >> ------------------------ Diese Mail enthaelt vertrauliche und/oder >> rechtlich geschuetzte Informationen. Wenn Sie nicht der richtige >> Adressat sind oder diese E-Mail irrtuemlich erhalten haben, >> informieren Sie bitte sofort den Absender und vernichten Sie diese >> Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser >> Mail ist nicht gestattet. This e-mail may contain confidential and/or >> privileged information. If you are not the intended recipient (or >> have received this e-mail in error) please notify the sender >> immediately and destroy this e-mail. Any unauthorized copying, >> disclosure or distribution of the material in this e- mail is str i > ctly forbidden. >> >> --------------------------------------------------------------------- >> --------- Don't Limit Your Business. Reach for the Cloud. >> GigeNET's Cloud Solutions provide you with the tools and support that >> you need to offload your IT needs and focus on growing your business. >> Configured For All Businesses. Start Your Cloud Today. >> https://www.gigenetcloud.com/ >> _______________________________________________ >> Asterisk-java-devel mailing list >> Ast...@li... >> https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel >> > > -- S. Brett Sutton Ph: 1300 NOOJEE (1300 666 533) Noojee Telephony Solutions - On Demand Contact Centres Solutions www.noojee.com.au ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Asterisk-java-devel mailing list Ast...@li... https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel ELARA Leitstellentechnik GmbH Member of Frequentis Group Schloss-Rahe-Str. 19a 52072 Aachen Geschäftsführender Gesellschafter: Dr.-Ing. Frank Herzog Geschäftsführer: Dipl.-Ing. Hans Werner Güntzel Amtsgericht Aachen HRB 17856 St.-Nr.: 201/5956/4218 USt-IdNr.: DE 285 827 521 --------------------------------------------------------------------------------------------- Diese Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e- mail is strictly forbidden. ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Asterisk-java-devel mailing list Ast...@li... https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel ELARA Leitstellentechnik GmbH Member of Frequentis Group Schloss-Rahe-Str. 19a 52072 Aachen Geschäftsführender Gesellschafter: Dr.-Ing. Frank Herzog Geschäftsführer: Dipl.-Ing. Hans Werner Güntzel Amtsgericht Aachen HRB 17856 St.-Nr.: 201/5956/4218 USt-IdNr.: DE 285 827 521 --------------------------------------------------------------------------------------------- Diese Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e- mail is strictly forbidden. |
