Re: [Asterisk-java-devel] Live and getVersion() issue

[Stefan R. <ste...@re...>]

Hi Thomas,

>  I have reported this issue in JIRA and uploaded a patch. The URL is:
> http://jira.reucon.com/browse/AJ-1

Thanks for you patch, I've applied it to svn and resolved AJ-130 for 1.0.0.

> * Is correct to define a new private static final String
> SHOW_VERSION_1_6_COMMAND?

Yep that's fine.

> * The added private field Asterisk coreVersion, should be named this way
> or maybe something like branchReleaseVersion?

I don't think we need it at all since we can just get it from
eventConnection.getVersion() and don't have to store it twice. For now
I've removed it.

> * In the documentation of the new method getVersion of the Manager
> component, the 'since' field should be 1.0?

In the future we will always use three digit version numbers so the
version that will contain your fix is 1.0.0, hence @since 1.0.0.

When referencing a static field/constant you should just use
Class.FIELD, e.g. AsteriskVersion.ASTERISK_1_6 instead of
someInstance.FIELD.

=Stefan

-- 
reuter network consulting
Neusser Str. 110
50760 Koeln
Germany
Telefon: +49 221 1305699-0
Telefax: +49 221 1305699-90
E-Mail:  ste...@re...
Jabber:  ste...@re...
WWW:     http://www.reucon.com

Steuernummern 215/5140/1791 USt-IdNr. DE220701760