Thread: [Asterisk-java-devel] Get Option documentation error

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

I've found an error in the AGI GetOption method. The timeout is
documented as being in seconds when it is actually in milliseconds.

Regards,
Brett

Brett Sutton wrote:
> I've found an error in the AGI GetOption method. The timeout is
> documented as being in seconds when it is actually in milliseconds.

Thanks. I've fixed the javadoc and changed the datatype from int to long.

=Stefan

OK, thanks.

One comment on the data types for methods such as 'setTimeout' is that
it would be nice to have both version (int and long). I notice that you
deprecated an int version of setTimeout, I would rather we had both, it
just saves one extra character :)

setTimeout(30000)
rather than
setTimeout(30000L)

don't spend too much time thinking about it though.

Stefan Reuter wrote:
> Brett Sutton wrote:
>   
>> I've found an error in the AGI GetOption method. The timeout is
>> documented as being in seconds when it is actually in milliseconds.
>>     
>
> Thanks. I've fixed the javadoc and changed the datatype from int to long.
>
> =Stefan
>
>   
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Asterisk-java-devel mailing list
> Ast...@li...
> https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel
>   

Brett Sutton wrote:

> I notice that you
> deprecated an int version of setTimeout, I would rather we had both, it
> just saves one extra character :)
> 
> setTimeout(30000)
> rather than
> setTimeout(30000L)
> 
> don't spend too much time thinking about it though.

I agree that ints would probably be just fine for durations in milli
seconds in this context. I try to have all milliseconds in long though
so it is more clear that they are millis. Maybe stupid but at least
somehow consistent...

=Stefan

Stefan Reuter wrote:
> Brett Sutton wrote:
> 
>> I notice that you
>> deprecated an int version of setTimeout, I would rather we had both, it
>> just saves one extra character :)

Uh I just noticed that as long as we don't make the int version
deprecated the long version of course takes a long as well as an int. So
removing the deprected int version is probably a better choise even for
backwards compatibility.
Do you remember the class that contains the deprecated setTimeout method?

=Stefan

I think it was AgiOperations.

Stefan Reuter wrote:
> Stefan Reuter wrote:
>   
>> Brett Sutton wrote:
>>
>>     
>>> I notice that you
>>> deprecated an int version of setTimeout, I would rather we had both, it
>>> just saves one extra character :)
>>>       
>
> Uh I just noticed that as long as we don't make the int version
> deprecated the long version of course takes a long as well as an int. So
> removing the deprected int version is probably a better choise even for
> backwards compatibility.
> Do you remember the class that contains the deprecated setTimeout method?
>
> =Stefan
>
>   
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Asterisk-java-devel mailing list
> Ast...@li...
> https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel
>   