asterisk-java-devel

[Asterisk-java-devel] Implement togglePaused method for AsteriskQueueMember

[Pau T. C. <pta...@ru...>]

Hi!

I've created a new issue (AJ-145) with changes implementing a togglePaused() 
method on AsteriskQueueMember interface.

More info on issue comments.

Thanks!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] Implement togglePaused method for AsteriskQueueMember

[Pau T. C. <pta...@ru...>]

El Thursday 05 June 2008 15:11:30 Pau Tallada Crespí va escriure:
> Hi!
>
> I've created a new issue (AJ-145) with changes implementing a
> togglePaused() method on AsteriskQueueMember interface.
>
> More info on issue comments.
>
> Thanks!

Hi!

I've implemented an improved version for this functionality.
Now there are 4 more methods:
 - pause
 - unpause
 - pauseAll
 - unpauseAll

I've created a new issue AJ-146 with diff atached.

Thanks!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] Implement togglePaused method for AsteriskQueueMember

[Stefan R. <ste...@re...>]

Hi,

Would it make sense to have two methods like set/getPaused instead of
pause and unpause?

=Stefan

Pau Tallada Crespí wrote:
> El Thursday 05 June 2008 15:11:30 Pau Tallada Crespí va escriure:
>> Hi!
>>
>> I've created a new issue (AJ-145) with changes implementing a
>> togglePaused() method on AsteriskQueueMember interface.
>>
>> More info on issue comments.
>>
>> Thanks!
> 
> Hi!
> 
> I've implemented an improved version for this functionality.
> Now there are 4 more methods:
>  - pause
>  - unpause
>  - pauseAll
>  - unpauseAll
> 
> I've created a new issue AJ-146 with diff atached.
> 
> Thanks!
> 


-- 
reuter network consulting
Neusser Str. 110
50760 Koeln
Germany
Telefon: +49 221 1305699-0
Telefax: +49 221 1305699-90
E-Mail:  ste...@re...
Jabber:  ste...@re...
WWW:     http://www.reucon.com

Steuernummern 215/5140/1791 USt-IdNr. DE220701760

Re: [Asterisk-java-devel] Implement togglePaused method for AsteriskQueueMember

[Pau T. C. <pta...@ru...>]

El Wednesday 11 June 2008 00:24:46 Stefan Reuter va escriure:
> Hi,
>
> Would it make sense to have two methods like set/getPaused instead of
> pause and unpause?
>
> =Stefan
>

I'm not very good at naming methods... :P

So, what if I reimplement methods like this?

 - void setPaused(boolean): sets paused status on current queue
 - boolean getPaused(): return paused state for this queue
 - void setPausedAll(boolean): sets paused state on all queues

If you like this naming, i could reupload an updated diff.
What do you think about it?

Regards,

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] Implement togglePaused method for AsteriskQueueMember

[Pau T. C. <pta...@ru...>]

El Wednesday 11 June 2008 08:45:47 Pau Tallada Crespí va escriure:
> El Wednesday 11 June 2008 00:24:46 Stefan Reuter va escriure:
> > Hi,
> >
> > Would it make sense to have two methods like set/getPaused instead of
> > pause and unpause?
> >
> > =Stefan
>
> I'm not very good at naming methods... :P
>
> So, what if I reimplement methods like this?
>
>  - void setPaused(boolean): sets paused status on current queue
>  - boolean getPaused(): return paused state for this queue
>  - void setPausedAll(boolean): sets paused state on all queues
>
> If you like this naming, i could reupload an updated diff.
> What do you think about it?
>
> Regards,

Hi!

I've attahed a new diff on AJ-146 with the new naming convention applied.

Thanks!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting