Thread: [Asterisk-java-devel] retrieve Agents list from AsteriskQueue

Brought to you by: srt

asterisk-java-devel

[Asterisk-java-devel] retrieve Agents list from AsteriskQueue

From: Pau T. C. <pta...@ru...> - 2008-02-15 14:13:10

Hi!

A few days ago, some people raised on asterisk-java-user list the question 
whether its possible to retrieve the list of AsteriskAgents associated with 
an AsteriskQueue. 

If I'm not wrong, the agentId from an Agent and the location of a 
QueueMemberEntry are equivalent, in the case of Agents.

We are developing an open-source callcenter status viewer, and to correctly 
view the status of a Queue, we would surely need its Agents.

If this functionality could be implemented, how would be the best route to 
take? 

Thank you for your advice!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] retrieve Agents list from AsteriskQueue

From: Stefan R. <ste...@re...> - 2008-02-15 14:24:18

Attachments: signature.asc

Pau Tallada Crespí wrote:
> If this functionality could be implemented, how would be the best route to 
> take? 

I would like to add a getAgent() method to the QueueMemberEntry or a
getQueueMemberEntry() to the Agent - or both.
Which way would be the best for a user of Asterisk-Java?

=Stefan

-- 
reuter network consulting
Neusser Str. 110
50760 Koeln
Germany
Telefon: +49 221 1305699-0
Telefax: +49 221 1305699-90
E-Mail:  ste...@re...
Jabber:  ste...@re...
WWW:     http://www.reucon.com

Steuernummern 215/5140/1791 USt-IdNr. DE220701760

Re: [Asterisk-java-devel] retrieve Agents list from AsteriskQueue

From: Pau T. C. <pta...@ru...> - 2008-02-18 08:20:25

El Friday 15 February 2008 15:24:05 Stefan Reuter va escriure:
> Pau Tallada Crespí wrote:
> > If this functionality could be implemented, how would be the best route
> > to take?
>
> I would like to add a getAgent() method to the QueueMemberEntry or a
> getQueueMemberEntry() to the Agent - or both.
> Which way would be the best for a user of Asterisk-Java?
> 
I suppose both would be useful.
I'll start implementing it now against latest snapshot.

Thanks!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] retrieve Agents list from AsteriskQueue

From: Pau T. C. <pta...@ru...> - 2008-02-18 11:58:52

Attachments: asterisk-java.diff

El Monday 18 February 2008 09:19:56 Pau Tallada Crespí va escriure:
> El Friday 15 February 2008 15:24:05 Stefan Reuter va escriure:
> > Pau Tallada Crespí wrote:
> > > If this functionality could be implemented, how would be the best route
> > > to take?
> >
> > I would like to add a getAgent() method to the QueueMemberEntry or a
> > getQueueMemberEntry() to the Agent - or both.
> > Which way would be the best for a user of Asterisk-Java?
>
> I suppose both would be useful.
> I'll start implementing it now against latest snapshot.
>
> Thanks!

Implemented and tested.
Summary of changes:

 - New method to AsteriskServer.java:

     /**
      * Return the agent with specified location, if exists
      * 
      * @param location
      * @return the agent with this location, or null if not exists.
      */
     AsteriskAgent getAgentByAgentId(String location);


 - Implemented getAgentByAgentId on AsteriskServerImpl.java:

     public AsteriskAgent getAgentByAgentId(String location) {
         return agentManager.getAgentByAgentId(location);
     }


 - Exported getAgentByAgentId on DefaultAsteriskServer.java:

     public AsteriskAgent getAgentByAgentId(String location) {
         return impl.getAgentByAgentId(location);
     }


 - New method to AsteriskQueueMember.java:

     /**
      * Returns the agent associated to this entry.
      * 
      * @return the agent associated to this entry,
      *         or null if is not an agent.
      */
     AsteriskAgent getAgent();


 - Implement getAgent on AsteriskQueueMemberImpl.java:

     public AsteriskAgent getAgent() {
         return getServer().getAgentByAgentId(this.getLocation());
     }


I'm attaching a diff. Please, comment.

Thanks!

-- 
Pau Tallada Crespí

RunSolutions
  Open Source IT Consulting

Re: [Asterisk-java-devel] retrieve Agents list from AsteriskQueue

From: Stefan R. <ste...@re...> - 2008-02-26 01:58:15

Attachments: signature.asc

Thanks!

I've created http://jira.reucon.org/browse/AJ-121 for this and will look
at it if I have some spare time.

=Stefan

Pau Tallada Crespí wrote:
> El Monday 18 February 2008 09:19:56 Pau Tallada Crespí va escriure:
>> El Friday 15 February 2008 15:24:05 Stefan Reuter va escriure:
>>> Pau Tallada Crespí wrote:
>>>> If this functionality could be implemented, how would be the best route
>>>> to take?
>>> I would like to add a getAgent() method to the QueueMemberEntry or a
>>> getQueueMemberEntry() to the Agent - or both.
>>> Which way would be the best for a user of Asterisk-Java?
>> I suppose both would be useful.
>> I'll start implementing it now against latest snapshot.
>>
>> Thanks!
> 
> Implemented and tested.
> Summary of changes:
> 
>  - New method to AsteriskServer.java:
> 
>      /**
>       * Return the agent with specified location, if exists
>       * 
>       * @param location
>       * @return the agent with this location, or null if not exists.
>       */
>      AsteriskAgent getAgentByAgentId(String location);
> 
> 
>  - Implemented getAgentByAgentId on AsteriskServerImpl.java:
> 
>      public AsteriskAgent getAgentByAgentId(String location) {
>          return agentManager.getAgentByAgentId(location);
>      }
> 
> 
>  - Exported getAgentByAgentId on DefaultAsteriskServer.java:
> 
>      public AsteriskAgent getAgentByAgentId(String location) {
>          return impl.getAgentByAgentId(location);
>      }
> 
> 
>  - New method to AsteriskQueueMember.java:
> 
>      /**
>       * Returns the agent associated to this entry.
>       * 
>       * @return the agent associated to this entry,
>       *         or null if is not an agent.
>       */
>      AsteriskAgent getAgent();
> 
> 
>  - Implement getAgent on AsteriskQueueMemberImpl.java:
> 
>      public AsteriskAgent getAgent() {
>          return getServer().getAgentByAgentId(this.getLocation());
>      }
> 
> 
> I'm attaching a diff. Please, comment.
> 
> Thanks!
> 
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Asterisk-java-devel mailing list
> Ast...@li...
> https://lists.sourceforge.net/lists/listinfo/asterisk-java-devel


-- 
reuter network consulting
Neusser Str. 110
50760 Koeln
Germany
Telefon: +49 221 1305699-0
Telefax: +49 221 1305699-90
E-Mail:  ste...@re...
Jabber:  ste...@re...
WWW:     http://www.reucon.com

Steuernummern 215/5140/1791 USt-IdNr. DE220701760