Hi Dominique,
> However, in day to day usage, I've found some annoying
> details :
> - No constructors in Actions, this makes it tedious and error prone to
> construct new actions. Ideally I would like to have a pair of
> constructors that take into account the main usage patterns.
Yep that is a valid enhancement. Feel free to submit patches for
additional "convenience" contructors.
> - No real toString methods on events (makes it difficult when writting
> logs).
Yes, I think there is even a note in the sources about that.
We must provide some generic toString method based on reflection in
ManagerEvent to follow the design of Asterisk-Java.
Do you want to provide a patch for that, too?
> - No argument checking on actions, some values for actions are illegal
> and could be checked for nullity or incorrectness.
Here i am not completely sure what to do. Genereally I think it is not a
good idea to duplicate error checking logic that belongs to Asterisk
itself. So if you send a bogous Action to Asterisk it should return an
error. Otherwise we might run into a maintainance nightmare due to
ongoing changes in Asterisk.
> Those are just some suggestion that would make writing code easier for
> me. Others might find them useless. If their is interest in those
> changes, I'm willing to provide patches.
See my notes above. I always welcome patches :)
Just post them here and we can discuss them in detail.
> Anyway, this library is great work. Thanks again to those who
> contributed to it.
Thanks for using it :)
Cheers,
Stefan
|
