Menu
▾
▴
#32 move the defintion of ClonePtr<T>::del(T * ptr)
Please move the defintion of ClonePtr<T>::del(T * ptr)
from clone_ptr-t.hpp to clone_ptr.hpp.
Currently the symbol is left undefined in speller_impl.obj
and speller.obj. Moving the def into the class definition
resolves the problem.
I wish there was a better solution and I'm open to
suggestions.
A patch is attached.
diff -u from setterg
Logged In: YES
user_id=6591
Try including "clone_ptr-t.hpp" in those modules.
Logged In: YES
user_id=700091
It clone_ptr-t.hpp is already included. Please consider this a
second reqest.
diff -ubwrN from setterg
Logged In: YES
user_id=700091
This patch has been open for some time. I checked again.
Without the change, there are unresolved externals from the
above modules, and they do include clone_ptr-t.hpp.
I built aspell with static library with the modified code with
cygwin successfully. The diff I'm attaching is with command:
diff -ubwrN
Logged In: YES
user_id=6591
Could you try moving all of clone_ptr-t.hpp into
clone_ptr.hpp and see what happens. If that works I will
remove clone_ptr-t.hpp like I did for copy_ptr-t.hpp.
Logged In: YES
user_id=700091
Changed per your suggestion.
btw,
How about I submit a patch to exchange rhs and lhs in the
assign function? It works as it its, it just looks funny.
diff -ubwrN from setterg
Patch as accepted
Logged In: YES
user_id=6591
When submitting a new patch the patch should be against the
base source before any other pataches: it should not be
required for me to first apply aspell5.diff THAN aspell7.diff.
Also please remeber to remove your date annonations and
indent properly.
Attached is the patch as accept. I also swapped rhs and
lhs. I tend to get the right and left backwards.
Logged In: YES
user_id=6591
The attached patch did not include the change to sgml.cpp.
This is fixed in CVS, however, Sorry about that.