Automatic CC feature duplicates email addresses

Sending GitHub PRs to the Git mailing list

Brought to you by: ashba22

#310 Automatic CC feature duplicates email addresses

Status: open

Owner: nobody

Labels: None

Updated: 2020-09-29

Created: 2020-09-02

Creator: Anonymous

Private: No

Originally created by: phil-blain

In https://github.com/gitgitgadget/git/pull/714, both Peff and Brian replied twice to my patch, and the new GGG automatic CC feature that adds a "cc:" footer to the PR description added their email twice.

Also, probably the PR author themself need not be added to the CC list if they answer to their own series.

@dscho @webstech

Discussion

Anonymous - 2020-09-02

Originally posted by: dscho

the new GGG automatic CC feature that adds a "cc:" footer to the PR description added their email twice.

Hmm. It should avoid that, of course... And I thought that https://github.com/gitgitgadget/gitgitgadget/pull/297/files#diff-be774741832b606f27bf194081322cedR111-R113 made it so? @phil-blain if you have time to investigate, that would be nice...

Also, probably the PR author themself need not be added to the CC list if they answer to their own series.

Right. However, I do not really know that we have an easy way to look that up? Your GitHub profile does not list a public email, for example, so I don't really know how GitGitGadget would know that a certain email address refers to you...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-09-02

Originally posted by: webstech

One of the edits of the PR description converted all \n to \r\n so the original cc: was not found. This caused the second set of cc: to be added.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-09-02

Originally posted by: phil-blain

I think that's GitHub following web standard conventions to use \r\n in text fields...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-09-02

Originally posted by: webstech

Sorry about that. I had got used to GGG converting them to \n internally.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-09-28

Originally posted by: webstech

Also, probably the PR author themself need not be added to the CC list if they answer to their own series.

Right. However, I do not really know that we have an easy way to look that up? Your GitHub profile does not list a public email, for example, so I don't really know how GitGitGadget would know that a certain email address refers to you...

PR [#323] corrects this in the case where the GitHub profile has a matching public email.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-09-29

Originally posted by: dscho

Shouldn't we already start with this internal mapping of GitHub handles to full email information? I am thinking of extending the allowed users list from a mere array to a map (or is it already a map? clicketyclick nope, it's still an array).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.