#35 Building XMMS2 plugin fails with

[Drei Eck]

When I run make asap-xmms2, it fails with
libxmms_asap.c:109:19: error: expected declaration specifiers or ‘...’ before string constant
and other errors:

xmms2/libxmms_asap.c:109:19: error: expected declaration specifiers or ‘...’ before string constant
  109 | XMMS_XFORM_PLUGIN("asap",
      |                   ^~~~~~
xmms2/libxmms_asap.c:110:9: error: expected declaration specifiers or ‘...’ before string constant
  110 |         "ASAP decoder", ASAPInfo_VERSION,
      |         ^~~~~~~~~~~~~~
In file included from xmms2/libxmms_asap.c:27:
./asap.h:150:26: error: expected declaration specifiers or ‘...’ before string constant
  150 | #define ASAPInfo_VERSION "5.3.0"
      |                          ^~~~~~~
xmms2/libxmms_asap.c:110:25: note: in expansion of macro ‘ASAPInfo_VERSION’
  110 |         "ASAP decoder", ASAPInfo_VERSION,
      |                         ^~~~~~~~~~~~~~~~
xmms2/libxmms_asap.c:111:9: error: expected declaration specifiers or ‘...’ before string constant
  111 |         "Another Slight Atari Player decoder",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xmms2/libxmms_asap.c:112:9: error: expected declaration specifiers or ‘...’ before ‘xmms_asap_setup’
  112 |         xmms_asap_setup);
      |         ^~~~~~~~~~~~~~~
xmms2/libxmms_asap.c:93:17: warning: ‘xmms_asap_setup’ defined but not used [-Wunused-function]
   93 | static gboolean xmms_asap_setup(xmms_xform_plugin_t *xform_plugin)
      |                 ^~~~~~~~~~~~~~~
make: *** [xmms2/xmms2.mk:14: libxmms_asap.so] Error 1

Installed xmms2: 0.9.2 (including /usr/include/xmms2/xmms/-files).
GCC version: 13.1.1 20230429

[Piotr Fusik]

Looks like a breaking change in xmms2.
Both my Ubuntu 22.04 and FC37 have xmms2 0.8 and I released asap-xmms2 this February.

I will accept a patch that fixes this without breaking the two mentioned OSes.