Piotr Fusik committed [adbdb1] on Code

[doc] No wildcards on Windows.

Piotr Fusik committed [870624] on Code

[doc] Document the WAV to D15/D8 conversion.

Piotr Fusik committed [2b4158] on Code

[setup] Shorten labels to available space.

Piotr Fusik committed [69fca0] on Code

[setup] Narrow the associations for AIMP.

Piotr Fusik committed [e63467] on Code

[setup] "Open with".

Piotr Fusik committed [fc481d] on Code

[seek] Don't unmute on rewind.

Piotr Fusik committed [8b11e8] on Code

[shellex] Fix installer error 1603.

Piotr Fusik committed [cd15aa] on Code

[setup] Associate SAP with foobar2000.

Piotr Fusik committed [aab47e] on Code

[swift] Fix "Fatal error: Negative value is not representable".

Piotr Fusik committed [95c991] on Code

[swift] Enable color diagnostics.

Piotr Fusik committed [7b7dac] on Code

[doc] Update for win64 packages.

Piotr Fusik committed [27f458] on Code

[shellex] sf feature #16 Handle all registry entries and propdesc registration from DLL (un)registration.

Piotr Fusik committed [4a7b8c] on Code

[opencl] Add progress messages.

Piotr Fusik modified a comment on ticket #16

I still don't understand your preference for regsvr32 over an installer, but here it is: https://asap.sourceforge.net/asap-8.0.0-ALPHA1-win64.zip The Explorer plugin is ASAPShellEx.dll + ASAPShellEx.propdesc which must live next to one another. regsvr32 error 80004005 means no admin priviledges, 80070002 means no propdesc file.

Piotr Fusik modified ticket #16

Have 64-bit Windows download as .zip

Piotr Fusik posted a comment on ticket #16

I still don't understand your preference for regsvr32 over an installer, but here it is: asap.sourceforge.net/asap-8.0.0-ALPHA1-win64.zip The Explorer plugin is ASAPShellEx.dll + ASAPShellEx.propdesc which must live next to one another. regsvr32 error 80004005 means no admin priviledges, 80070002 means no propdesc file.

Piotr Fusik committed [c6a77d] on Code

[opencl] Free resources early.

Piotr Fusik committed [11e7ae] on Code

Revert "[opencl] Refactor with CL_Buffer."

Piotr Fusik committed [4d5844] on Code

[opencl] Refactor with CL_Buffer.

Piotr Fusik committed [e89f4a] on Code

[opencl] Refactor std::string -> std::vector<char>.

Piotr Fusik committed [b69686] on Code

[opencl] Convert in parallel.

Piotr Fusik committed [13e707] on Code

[opencl] Convert all subsongs.

Piotr Fusik posted a comment on ticket #46

C:\jac\system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(2813,24): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(4448,22): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss o Fixed now.

Piotr Fusik committed [1ef907] on Code

[fu] sf bug #46 Avoid MSVC warnings.

Piotr Fusik committed [64dc6b] on Code

[wasap] Fix WM_COPYDATA return value per doc.

Piotr Fusik committed [c756a9] on Code

[wasap] Handle media keys.

Piotr Fusik posted a comment on ticket #45

Strange. Are the .SAP files in C:\TEMP identical to the source files?

Piotr Fusik posted a comment on ticket #46

C:\jac\system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(2813,24): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(4448,22): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss o I will handle these. For now, just don't pass filenames consisting of over two billion characters. ;) C:\jac\system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(3991,10):...

Peter Dell posted a comment on ticket #45

That's my preference from the 80s. Single user computer, so TEMP is not somewhere in the user profile, but there. Environment variables are set up like this: TEMP=C:\TEMP TMP=C:\TEMP When I trigger the diff, two .sap files are created there. But they are .SAP files, not text files,

Peter Dell posted a comment on ticket #46

I've added the _CRT_SECURE_NO_WARNINGS; define the project and the "unsafe" warnings are gone. But these two are still there and look valid to me: C:\jac\system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(2813,24): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data 1>C:\jac\system\Windows\Programming\Repositories\RASTER-Music-Tracker\src\asap.c(3991,10): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the...

Piotr Fusik modified ticket #46

warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.

Piotr Fusik posted a comment on ticket #46

Ok, I fixed some buffer overflows with malicious long filenames. MSVC may still complain about "unsafe" functions, but I don't care.

Piotr Fusik committed [390ca2] on Code

[wasap] sf bug #46 Fix buffer overflows with very long filenames.

Piotr Fusik committed [485e99] on Code

[wasap] Remove UNICODE support.

Piotr Fusik committed [ce7ede] on Code

[doc] Credit the STIMER bug report.

Piotr Fusik modified ticket #46

warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.

Piotr Fusik posted a comment on ticket #46

This is not a bug. MSVC's warning says "may be unsafe". For many years, MSVC did not implement C99 - one had to stick to C89. Then they push for using these C11 functions which provide dubious safety - you need to pass the number of available characters. I switched from MSVC to MinGW many years ago. Since you have already MSYS2 (for perl), installing MinGW GCC is as easy as: pacman -S make mingw-w64-i686-gcc mingw-w64-x86_64-gcc Then: make win32/wasap.exe

Peter Dell created ticket #46

warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead.

Piotr Fusik modified ticket #22

Windows Explorer extension doesn't work?

Piotr Fusik posted a comment on ticket #22

I believe this is fixed now.

Piotr Fusik committed [aec970] on Code

[win64] Build WASAP, asapscan, asapscan, sap2txt for x64.

Piotr Fusik committed [e2af70] on Code

[setup] win64.msi contains everything needed for x64 Windows.

Piotr Fusik committed [d94888] on Code

[release] "make dist" includes win64.zip.

Piotr Fusik committed [5079dd] on Code

[foobar2000] Simplify the build.

Piotr Fusik committed [d6587b] on Code

[win32] Merge 32-bit and 64-bit build rules.

Piotr Fusik committed [834625] on Code

[asapconv] Refactor converting WAV to D15/D8.

Piotr Fusik committed [38c3f5] on Code

[asapconv] Convert WAV to D15/D8.

Piotr Fusik committed [4aff29] on Code

[asapconv] Start error messages with the filename.

Piotr Fusik committed [679f4f] on Code

[d15] Play D15/D8 samples.

Piotr Fusik modified ticket #17

Use dedicated "Date" attribute instead of"Year" in Explorer Plugin

Piotr Fusik posted a comment on ticket #17

Done and it's editable. The UI label is "SAP Date", because Windows provides a "Date" property (seems to be same as "Date modified") and you'd see two "Date"s when add a column.

Piotr Fusik committed [01a5a9] on Code

[shellex] sf feature #17 Add the "SAP Date" property.

Piotr Fusik committed [e4dd4a] on Code

[release] sf feature #16 win64.zip package.

Piotr Fusik committed [594508] on Code

[setup] Install the foobar2000 plugin in home dir instead of Program Files.

Piotr Fusik committed [a47a00] on Code

[doc] Describe how to display subsong numbers in foobar2000.

Piotr Fusik modified ticket #16

Have 64-bit Windows download as .zip

Piotr Fusik committed [d6d46b] on Code

[doc] Bump the copyright year.

Piotr Fusik modified ticket #35

Building XMMS2 plugin fails with

Piotr Fusik posted a comment on ticket #35

I could only add the FC format. The other formats start with FF FF bytes which makes them misdetected as MP3 by the "mad" plugin and after "mad" fails, ASAP is not given a chance. How to use XMMS2: xmms2 add NINJA.FC xmms2 play Starting xmms2d first is optional, but useful to see the logs. xmms2d -v gives more logs. For testing, use a *.FC file (from https://asap.sourceforge.net/examples.zip), as XMMS2's "gme" plugin provides a partial (inferior to ASAP) support for the SAP format.

Piotr Fusik committed [a9d681] on Code

[xmms2] Add the FC format.

Piotr Fusik committed [dec75a] on Code

[xmms2] sf bug #35 Fix "Failed to find plugin header".

Piotr Fusik modified ticket #35

Building XMMS2 plugin fails with

Piotr Fusik posted a comment on ticket #35

I got XMMS2 playing under Fedora 43. The sound is "choking", also on MP3s, but that might be because I'm running it in VirtualBox. I looked at ASAP's plugin source and realized it only supports *.SAP. :) I'll try to add the other formats.

Drei Eck posted a comment on ticket #35

I actually cannot start xmms2d either, it aborts for me. So I cannot test further, either. I actually just do this for "completeness" in packaging: Arch Linux AUR package "asap-chiptunes-player-git". Just for reference: My failure of starting xmms2d: INFO in core: ../src/xmms/log.c:50: Initialized logging system :) 13:39:47 INFO in core: ../src/xmms/ipc.c:981: IPC listening on 'unix:///tmp/xmms-ipc-[username]'. 13:39:47 ERROR in core: ../src/xmms/collsync.c:486: Could not restore collections from...

Piotr Fusik posted a comment on ticket #35

With this patch --- a/xmms2/libxmms_asap.c +++ b/xmms2/libxmms_asap.c @@ -108,6 +108,7 @@ static gboolean xmms_asap_setup(xmms_xform_plugin_t *xform_plugin) #ifdef XMMS_XFORM_PLUGIN_DEFINE // xmms2-devel 0.9.x +#define XMMS_PLUGIN_DESC_SYMBOL_NAME XMMS_PLUGIN_DESC XMMS_XFORM_PLUGIN_DEFINE("asap", "ASAP decoder", ASAPInfo_VERSION, "Another Slight Atari Player decoder", the error message of xmms2d goes away. But I still don't know how to play a file?

Drei Eck posted a comment on ticket #35

When I start xmms2d, I get an error about the plugin: 20:43:05 ERROR in core: ../src/xmms/plugin.c:394: Failed to find plugin header in /usr/lib/xmms2/libxmms_asap.so Full output of xmms2d: INFO in core: ../src/xmms/log.c:50: Initialized logging system :) 20:46:12 INFO in core: ../src/xmms/ipc.c:981: IPC listening on 'unix:///tmp/xmms-ipc-felics'. 20:46:12 ERROR in core: ../src/xmms/plugin.c:394: Failed to find plugin header in /usr/lib/xmms2/libxmms_asap.so 20:46:12 ERROR in core: ../src/xmms/collsync.c:486:...

Piotr Fusik posted a comment on ticket #16

Yes, the installer makes more registry entries that the DLL registration. This includes the entries for the Property page. Why unzip and run regsvr32 if you can just run the installer? What do you mean by a "portable" installation?

Piotr Fusik posted a comment on ticket #45

Also, is your issue just for malformed files or can't you diff any changes? I'm concerned that your error message says C:\TEMP. I don't have this directory on my disk.

Piotr Fusik posted a comment on ticket #45

I'm using the same TortoiseSVN version as you and ASAP 7.0.0 on Windows 11 24H2.

Piotr Fusik posted a comment on ticket #45

I removed fix-brk.bat from the ASMA repo. I don't reproduce any error message after copying the file you attached over asma/Unknown/Rock_1.sap. See the attached screenshot. What exactly did you do? MSYS2 perl (and other tools) can be run directly from the Windows command prompt. That's how I usually use it. I rarely use the bash and I never ever use the MSYS2 terminal.

Peter Dell posted a comment on ticket #18

Good solution, thanks.

Peter Dell modified a comment on ticket #45

fix-brk is a quick-and-dirty single-use tool for ASMA. No, I'm not going to maintain or document it. :) The I'd suggest to just remove it from the repo. Please attach the broken Rock_1.sap file for tests. See below. The root cause of your problems is that you installed a wrong perl on Windows, I've removed my previous Perl installation and use MYSYS2 now. What confuses me is that I now have a bash, but the scripts are ".bat" files?

Peter Dell modified a comment on ticket #45

fix-brk is a quick-and-dirty single-use tool for ASMA. No, I'm not going to maintain or document it. :) The I'd suggest to just remove it from the repo. Please attach the broken Rock_1.sap file for tests. See below. The root cause of your problems is that you installed a wrong perl on Windows, I've removed my previous Perl installation and use MYSYS2 now. What confuses me is that I now have a bash, but the scripts are ".bat" file?

Peter Dell posted a comment on ticket #45

I've removed my previous Perl installation and use MYSYS2 now. What confuses me is that I now have a bash, but the scripts are ".bat" file?

Piotr Fusik modified ticket #45

Tortoise Diff: The file C:\TEMP\Rock_1.sap-rev798.svn001.tmp.sap is not a valid text file!

Piotr Fusik posted a comment on ticket #45

Please attach the broken Rock_1.sap file for tests.

Piotr Fusik modified ticket #45

Tortoise Diff: The file C:\TEMP\Rock_1.sap-rev798.svn001.tmp.sap is not a valid text file!

Piotr Fusik posted a comment on ticket #45

fix-brk is a quick-and-dirty single-use tool for ASMA. No, I'm not going to maintain or document it. :) The root cause of your problems is that you installed a wrong perl on Windows, which uses CRLFs instead of LFs. My fix-brk wasn't prepared for that. Having LFs on all systems makes things easier. I use perl from https://www.msys2.org - after the installer is finished, run pacman -S perl. I use MSYS2 for tools like GCC, GNU Make, Python, Node.js. Now the only problem in ASAP is the poor reporting...

Piotr Fusik modified ticket #18

Have current version and "future" milestones

Piotr Fusik posted a comment on ticket #18

I configured the trackers to have N/A as the only "milestone", like I did before for Bugs.

Peter Dell posted a comment on ticket #45

Additional remark: my "checksap" reported the modified file as corrupted. If think the logic in the script incorrectly matches here.

Peter Dell created ticket #19

Edit STIL information in WASAP Dialog

Peter Dell created ticket #45

Tortoise Diff: The file C:\TEMP\Rock_1.sap-rev798.svn001.tmp.sap is not a valid text file!

Peter Dell posted a comment on ticket #16

Addition: I ran the win64.msi now also on the machine where the property pages didn't work and now they work.

Peter Dell created ticket #18

Have current version and "future" milestones

Peter Dell created ticket #17

Use dedicated "Date" attribute instead of"Year" in Explorer Plugin

Peter Dell created ticket #16

Have 64-bit Windows download as .zip

Piotr Fusik modified ticket #44

ASAP 7.0.0 - Missing export form RMT format

Piotr Fusik posted a comment on ticket #44

Fixed in Git. Thanks!

Piotr Fusik committed [98ba88] on Code

[sap] sf bug #44 Fix no RMT extraction.

Peter Dell created ticket #44

ASAP 7.0.0 - Missing export form RMT format

Piotr Fusik committed [4eaad1] on Code

[xmplay] Fix all RMT instrument names to be number 000.

Piotr Fusik committed [1fdcf9] on Code

[md1] Enable in C#.

Piotr Fusik committed [4a3d6b] on Code

[d15] Allow garbage bytes in the file.

Piotr Fusik committed [c14ab2] on Code

[release] 7.0.0.

Piotr Fusik created a blog post

ASAP 7.0.0 released

ASAP - Another Slight Atari Player released /asap/7.0.0/foo_asap-7.0.0.fb2k-component

ASAP - Another Slight Atari Player released /asap/7.0.0/asap-vlc-7.0.0-1.x86_64.rpm

ASAP - Another Slight Atari Player released /asap/7.0.0/asap-xmms2_7.0.0-1_amd64.deb

ASAP - Another Slight Atari Player released /asap/7.0.0/asap-xmms2-7.0.0-1.x86_64.rpm