Re: [Arpix-devel] GnomeZip ready for release

[Hongli L. <ho...@te...>]

On Sat, 03 Feb 2001 16:27:49 Simo Sorce wrote:
> Hongli Lai wrote:
> > 
> > Please test it a little and send me bug reports if you find any.
> > 
> > There's one critical bug in LibGarp.
> > When I try to open a file not supported by LibGarp, it will execute an
> > infinite loop and eat up all your memory if you don't CTRL+C it.
> > Could somebody look at it?
> > 
> I think I've fixed it.
> 
> There were a couple of bugs in garp-zip.c and garp-formats.c

Like I said: I already fixed it!
But it seems that you have found another bug ^_^


> garp-zip: if the ziplib returned the need for multiple disk or last disk
> the app cycled endlessly tring to feed the same invalid file name
> instead of exiting!!

I haven't actually seen anybody using multispanning zipfiles before.
So I don't think this is a critical bug.

> garp-formats: missed the test to be sure an extension was found. If a
> filename without extension were passed, than the routine uncorrectly
> reported garp_zip_new as handler instead of null!!

Fixed.


> code: I think I have still problems with sourceforge cvs (other cvs work
> fine for me), it seem they decided user idra does not need a home :(
> so I will send you the patch over the list

Thanks.
Only garp-zip.c patch was accepted.