arpix-devel

Re: [Arpix-devel] Ziplib path bug

[Giovanni C. <val...@li...>]

On 14 Feb 2001 19:36:31 +0100, Simo Sorce wrote:
> Hongli Lai wrote:
> > 
> > Ziplib only extracts to the work directory.
> > I've added a workaround in GarpZip using g_get_current_dir() and chdir()
> > Simo, could you fix this bug?

Maybe we can keep this workaround as a rule. I think that handling
extraction directory is a garp-[zip|tar|tgz] issue, not
[zip|tar|tgz]lib's. But if you think otherwise, I think I can add a
tl_extractfiletodir() function to tarlib.

> > 
> > BTW, you could also take a look at tarlib's extraction code on how to
> > create block devices and FIFOs.
> 
> These things are on my todo list in first position, unfortunately I'm
> really busy these days as I'm releasing a product form my employee.
> 

Il'be busy too. I don't think I'll have mush spare time before the end
of February.


    Giovanni

-- 
Bart:  Conosco un sito dove le scimmie fanno le cosacce.
Homer: Hu-hu! Scimmie!

Re: [Arpix-devel] Ziplib path bug

[Simo S. <sim...@ti...>]

Giovanni,
do not send html formatted mails please.
Use text only!

-- 
sim...@ti...
http://www.geocities.com/SiliconValley/9757

Re: [Arpix-devel] Ziplib path bug

[Hongli L. <ho...@te...>]

On Thu, 15 Feb 2001 09:21:14 Giovanni Corriga wrote:
> Maybe we can keep this workaround as a rule. I think that handling
> extraction directory is a garp-[zip|tar|tgz] issue, not
> [zip|tar|tgz]lib's. But if you think otherwise, I think I can add a
> tl_extractfiletodir() function to tarlib.

The current workaround is by setting the working directory while
extracting.
But this kind of workaround is not threadsafe.
I planned pthread support in some later version of GnomeZip,
so I want everything to be more or less threadsafe.
Imagine extraction a file to one directory, while using another
window (of the same app) to extract some other file to some
other directory.
Imagine GarpArchive 1 sets the working directory to /foo,
then the pthread lib gives the control to GarpArchive 2.
GarpArchive 2's chdir() code has already been executed beforem\,
so it extracts. But because the working directory has been
altered by GarpArchive 1, it would extract to the wrong dir.
See the problem?

Re: [Arpix-devel] Ziplib path bug

[Simo S. <sim...@ti...>]

Hongli Lai wrote:
> 
> On Thu, 15 Feb 2001 09:21:14 Giovanni Corriga wrote:
> > Maybe we can keep this workaround as a rule. I think that handling
> > extraction directory is a garp-[zip|tar|tgz] issue, not
> > [zip|tar|tgz]lib's. But if you think otherwise, I think I can add a
> > tl_extractfiletodir() function to tarlib.
> 
> The current workaround is by setting the working directory while
> extracting.
> But this kind of workaround is not threadsafe.
> I planned pthread support in some later version of GnomeZip,
> so I want everything to be more or less threadsafe.
> Imagine extraction a file to one directory, while using another
> window (of the same app) to extract some other file to some
> other directory.
> Imagine GarpArchive 1 sets the working directory to /foo,
> then the pthread lib gives the control to GarpArchive 2.
> GarpArchive 2's chdir() code has already been executed beforem\,
> so it extracts. But because the working directory has been
> altered by GarpArchive 1, it would extract to the wrong dir.
> See the problem?
> 
This problem may arise anyway also if we put the code in libgarp.
What you need is a consistent locking system for system wide variables
and a per thread
variabile set for the variabile the are related only to a thread.

-- 
sim...@ti...
http://www.geocities.com/SiliconValley/9757

Re: [Arpix-devel] Ziplib path bug

[Hongli L. <ho...@te...>]

On Fri, 16 Feb 2001 10:39:28 Simo Sorce wrote:
> This problem may arise anyway also if we put the code in libgarp.
> What you need is a consistent locking system for system wide variables
> and a per thread
> variabile set for the variabile the are related only to a thread.

I think you misunderstood me.
In this case, using a locking system would "lock too much".
The current method is to extract a file to the working directory:
f = fopen("file.zip", "w");
fwrite (f, some_data);
fclose (f);

What I want is to change ziplib/tarlib's API to something like this:
void zlextract(gchar *extract_to, gchar *file_to_extract)
{
    gchar *fn = g_strdup_printf ("%s/%s", extract_to, file_to_extract);

    f = fopen (fn, "w");
    fwrite (f, some_data);
    fclose (f);
}