#508 Crash in xadmaster.library on x86_64

[Matthias Rustler]

xadmaster.library crashes on x86_64.

When started from UNARC:

#0  0x0000000041d9f929 in xadAddClients (xadMasterBase=0x417ddc10, clients=0x41800ba000000000, add_flags=4) at /home/mazze/projects/fullaros/aros-src/contrib/libs/xad/portable/./clientfunc.c:570
#1  0x0000000041d9ddf8 in InitClients (xadMasterBase=0x417ddc10) at /home/mazze/projects/fullaros/aros-src/contrib/libs/xad/portable/amiga/xadmaster_init.c:92
#2  0x0000000041d9e12d in Init (xadMasterBase=0x417ddc10) at /home/mazze/projects/fullaros/aros-src/contrib/libs/xad/portable/amiga/xadmaster_init.c:154
#3  0x0000000041dede93 in set_call_libfuncs (set=0x418082e0, order=1, test_fail=1, libbase=0x417ddc10) at /home/mazze/projects/fullaros/aros-src/compiler/libinit/./libinit.c:42
#4  0x0000000041d9d5d3 in xadmaster_InitLib (xadMasterBase=0x417ddc10, segList=0x41d9d3f4, sysBase=0x41002820) at /home/mazze/projects/fullaros/aros-linux-x86_64-dbg/bin/linux-x86_64/gen/contrib/libs/xad/portable/xadmaster_start.c:314
#5  0x000000005f4169a4 in Exec_17_InitResident (resident=0x41def9a0 <xadmaster_ROMTag>, segList=0x41d9d3f4, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/rom/exec/./initresident.c:129
#6  0x000000005f4af2d9 in __inline_Exec_InitResident (__arg1=0x41def9a0 <xadmaster_ROMTag>, __arg2=0x41d9d3f4, __SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-linux-x86_64-dbg/bin/linux-x86_64/AROS/Development/include/inline/exec.h:151
#7  0x000000005f4afcf0 in LDInit (seglist=0x41d9d3f4, list=0x41002b10, resname=0x417f8830 "xadmaster.library", SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/rom/lddemon/./lddemon.c:205
#8  0x000000005f4afda9 in CallLDInit (seglist=0x41d9d3f4, list=0x41002b10, resname=0x417f8830 "xadmaster.library", DOSBase=0x411695c0, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/rom/lddemon/./lddemon.c:233
#9  0x000000005f4b0212 in LDRequestObject (libname=0x417f8830 "xadmaster.library", version=13, dir=0x5f4b2201 "libs", list=0x41002b10, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/rom/lddemon/./lddemon.c:413
#10 0x000000005f4b03df in Dos_0_OpenLibrary (libname=0x417f8830 "xadmaster.library", version=13, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/rom/lddemon/./lddemon.c:477
#11 0x00000000417f5ea8 in __inline_Exec_OpenLibrary (__arg1=0x417f8830 "xadmaster.library", __arg2=13, __SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-linux-x86_64-dbg/bin/linux-x86_64/AROS/Development/include/inline/exec.h:1302
#12 0x00000000417f5f10 in _set_open_libraries_list (list=0x417f91c8, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./libraries.c:44
#13 0x00000000417f791d in __startup_initexit (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./initexitsets.c:57
#14 0x00000000417f7aea in ___startup_entries_next (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./programentries.c:26
#15 0x00000000417f71f0 in __startup_stdiowin (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./stdiowin.c:47
#16 0x00000000417f7aea in ___startup_entries_next (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./programentries.c:26
#17 0x00000000417f7847 in __startup_fromwb (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./fromwb.c:47
#18 0x00000000417f7aea in ___startup_entries_next (SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/autoinit/./programentries.c:26
#19 0x00000000417f0727 in __startup_entry (argstr=0x41192830 "\n", argsize=1, SysBase=0x41002820) at /home/mazze/projects/fullaros/aros-src/compiler/startup/startup.c:79

Crash happens in line
if (xc->xc_MasterVersion > XADMASTERVERSION) continue;

(gdb) p xc
$25 = (const struct xadClient ) 0x41800ba000000000
(gdb) p xc
Cannot access memory at address 0x41800ba000000000

[Matthias Rustler]

Fixed by:
https://github.com/aros-development-team/contrib/commit/c7fd4f4139c17410a5dcdcdba48009847a11bd7e