#2 Unix socket support

closed-fixed
nobody
Ario (11)
5
2011-04-09
2009-08-06
No

This patch add unix socket support for Ario. If the host given by the user starts with '.' or '/', the host is considered as a unix socket path.
This feature is only added if WIN32 is undefined and MPD_NO_UNIX is undefined too.
I hope this will be useful for your project.

Discussion

  • Marc Pavot

    Marc Pavot - 2009-08-23

    Hello,

    Thanks for this patch but limpclient.c/h in Ario sources is only a copy of master libmpdclient from MPD project.

    I don't know libmpclient code well enough to accept or refuse your patch so could you please first propose it to MPD team? If they think you code is safe and useful, I will include it in Ario.

    Thanks,
    Marc

     
  • Alexandre Défossez

    I've just download the libmpdclient sources and the current version already supports UNIX sockets. However, the version you're using seems pretty old and the structure of the lib had completly changed. The new API is not compatible with the one you're using. My patch is useless if you choose to use the latest version of libmpdclient. But this will require some work as most of the names have changed, in fact the naming convention has changed (for example, mpd_sendStatusCommand becomes mpd_send_status).

     
  • Marc Pavot

    Marc Pavot - 2009-09-27

    New API of libmpdclient is not finalized so I won't miigrate Ario right now.

    I can accept you patch but please first fix the following warnings before:
    lib/libmpdclient.c: In function 'mpd_connect':
    lib/libmpdclient.c:172: warning: assignment from incompatible pointer type
    lib/libmpdclient.c: In function 'mpd_newConnection':
    lib/libmpdclient.c:170: warning: array subscript is above array bounds

    Thanks,
    Marc

     
  • Alexandre Défossez

    Ok, I'll try to during the next holiday (I currently don't have time to do this because of my studies).

     
  • Marc Pavot

    Marc Pavot - 2011-04-09
    • status: open --> closed-fixed
     
  • Marc Pavot

    Marc Pavot - 2011-04-09

    This patch is not useful anymore (Ario migrated to new version of libmpdclient)

    Thanks anyway.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks