To be more precise, it is the function "ario_lyrics_letras_parse_file", in which the "< / p >" indicates the end of the lyrics, if I got that right. letras must have changed something.
Now ario only gets the first verse or the part of the lyric which ends with "< / p >". I had a look in the actual html code and think it would be better to end with "
".
Unfortunately the line
end = strstr (begin, "< div id = \" banner \" >")
instead of
end = strstr (begin, "< / p > ")
causes a segmentation fault on calling "ario_util_convert_from_iso8859".
Any thoughts?
Henning
Last edit: Henne 2014-05-15
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
To be more precise, it is the function "ario_lyrics_letras_parse_file", in which the "< / p >" indicates the end of the lyrics, if I got that right. letras must have changed something.
Now ario only gets the first verse or the part of the lyric which ends with "< / p >". I had a look in the actual html code and think it would be better to end with "
Unfortunately the line
end = strstr (begin, "< div id = \" banner \" >")
instead of
end = strstr (begin, "< / p > ")
causes a segmentation fault on calling "ario_util_convert_from_iso8859".
Any thoughts?
Henning
Last edit: Henne 2014-05-15
You have to just comment the conversion-to-utf-8 section (I think the file is yet encoded as utf-8 and therefore causes issues).
I attached the fix for this bug.
Attached is a more robust patch. Optional is the replacement of the letras domain with http://letras.mus.br/