#445 friend achievement category

closed-fixed
None
2011-02-10
2011-01-29
No

add friend achievement category which is about being friendly, i.e. no pvp for a long time, helping all the children, finding all the lost people. moved susi achievement into the more general one of helping children. make sure quest related achievements get notified on finishing quest, even if not in pure quest category

still need to add the no-pvp and good karma achievements to this. not tested fully yet, but cvs is down and want to save code

Discussion

  • Katie Russell

    Katie Russell - 2011-01-29
     
  • Katie Russell

    Katie Russell - 2011-01-29

    the condition for the seven cherubs was wrong as it doesnt get set to done:

    // Meet Angels (any of the cherubs)
    new ChatCondition() {
    public boolean fire(final Player player, final Sentence sentence, final Entity entity) {
    if (!player.hasQuest("seven_cherubs")) {
    return false;
    }
    final String npcDoneText = player.getQuest("seven_cherubs");
    final String[] done = npcDoneText.split(";");
    final int left = 7 - done.length;
    return left < 0;
    }
    })));

     
  • Katie Russell

    Katie Russell - 2011-01-29

    or if we could have an instance of the quest it's the isCompleted method. checking for the children quests now

     
  • Katie Russell

    Katie Russell - 2011-01-29

    an update, additional to the previous patch

     
  • Katie Russell

    Katie Russell - 2011-01-29

    added an update to the patch (use them both, in order) : Fix quest completed checks on quests which didn't have canonical completion. Added karma achievement

     
  • Katie Russell

    Katie Russell - 2011-02-10

    Thanks for the patch.
    It has been applied to cvs trunk.

     
  • Katie Russell

    Katie Russell - 2011-02-10
    • assigned_to: nobody --> kymara
    • status: open --> closed-fixed
     


Anonymous

Cancel  Add attachments