#313 TODO fix

closed-rejected
None
2009-11-22
2009-11-21
yoriy
No

I checked, code without "null" work as with it.

Discussion

  • yoriy

    yoriy - 2009-11-21
     
  • Katie Russell

    Katie Russell - 2009-11-22

    The null is needed as this means public chat. null gets passed to param1, and the text to param2. If you compared what had happened to the game event log for before and after the change you'd have seen it was not wanted:
    +----------+---------------------+--------+-------+--------+----------------------+
    | id | timedate | source | event | param1 | param2 |
    +----------+---------------------+--------+-------+--------+----------------------+
    | 12062397 | 2009-11-22 12:35:33 | kymara | chat | | 16 !me makes a test |
    +----------+---------------------+--------+-------+--------+----------------------+
    1 row in set (0.00 sec)

    Now apply your patch and see what the change is. I believe it will show:

    +----------+---------------------+--------+-------+--------+----------------------+
    | id | timedate | source | event | param1 | param2 |
    +----------+---------------------+--------+-------+--------+----------------------+
    | 12062397 | 2009-11-22 12:35:33 | kymara | chat | 16 !me makes a test | |
    +----------+---------------------+--------+-------+--------+----------------------+
    1 row in set (0.00 sec)

    which is quite different

     
  • Katie Russell

    Katie Russell - 2009-11-22
    • assigned_to: nobody --> kymara
    • status: open --> closed-rejected
     


Anonymous

Cancel  Add attachments