From: SourceForge.net <no...@so...> - 2012-04-08 22:46:54
|
Bugs item #3308856, was opened at 2011-05-28 14:04 Message generated for change (Comment added) made by bluelads99 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3308856&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: monsterdhal (monsterdhal) Assigned to: Nobody/Anonymous (nobody) Summary: [Stendhal] Producers can ask to come back in the past Initial Comment: When I came back to Joshua while having a full bag and regardless trying to make a new order, he asked me to come back in the past: [22:53] <monsterdhal> hi [22:53] <Joshua> Welcome back! I'm done with your order. But right now you cannot take the gold bars. Come back when you have space. [22:53] <monsterdhal> cast 3 [22:53] <Joshua> I still haven't finished your last order. Come back in -2 weeks! ---------------------------------------------------------------------- >Comment By: bluelads (bluelads99) Date: 2012-04-08 15:46 Message: Ci-Dev also reported this at #3515570 including: [23:37] <Ci-Dev> hi [23:37] <Xoderos> Welcome back! I'm done with your order. But right now you cannot take the pieces of iron. Come back when you have space. [23:37] <Ci-Dev> cast [23:37] <Xoderos> I still haven't finished your last order. Come back in -1 weeks! How to repeat: - have nugget of iron ore and wood in inventory - have NO iron in inventory - fill inventory with other stuff - have finished casted pieces of iron - try to cast more (see above) ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2012-02-15 04:26 Message: I will look at this for before the release of 1.00, with clear lists on how to reproduce it it should be possible to fix :) ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2012-02-15 04:25 Message: Jdstroy also reported this at #3477293 with this message: NPCs produce a nonsense message when the following conditions are true: - The player has completed a production quest with an NPC - The player's inventory is full - The player has no stackable items produced by the production quest - The player initiates a conversation with the same NPC - The player attempts to continue production ---------------------------------------------------------------------- Comment By: bluelads (bluelads99) Date: 2011-08-11 15:58 Message: Same for me. I'll set the priority a bit up. Greetings Bluelads4 ---------------------------------------------------------------------- Comment By: Martin Fuchs (martinfuchs) Date: 2011-05-28 15:05 Message: The problem is located in this code snippet of ProducerAdder.java: /* Player says the production trigger word but the NPC is already producing items for that player */ engine.add( ConversationStates.ATTENDING, behaviour.getProductionActivity(), new QuestActiveCondition(QUEST_SLOT), false, ConversationStates.ATTENDING, null, new ChatAction() { public void fire(final Player player, final Sentence sentence, final EventRaiser npc) { // TODO: check - can the StateRemainingTimeAction be used here? npc.say("I still haven't finished your last order. Come back in " + behaviour.getApproximateRemainingTime(player) + "!"); } }); I think there should be added a condition of "isOrderReady(player)" to check, the order is not yet ready to be delivered. Otherwise the error message should be for example "You did not yet fetch your last order.". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=3308856&group_id=1111 |