#3865 website: looks bad on IE

closed-fixed
nobody
Website (125)
6
2009-02-28
2008-07-06
No

Discussion

  • dsaavedra

    dsaavedra - 2008-09-18

    its also present on the main page, not only the hall of fame, maybe its something related with the main.css ?

     
  • dsaavedra

    dsaavedra - 2008-09-24

    I have been looking a little bit at this bug and i have found one way to make it look better in IE, but it doesnt work with firefox:
    (halloffame.php)
    <div style="position: relative; width: 32%">
    <div style="position:relative; left: 20%; top: -10%; width: 33%">
    <div style="position: relative; left: 40%; top: -20%; width: 33%">

    On each of the divs that hold the best players that go down the best player box. Also on the best player box the size of the picture of the player should be changed:
    (halloffame.css)
    .bordered_image {
    border: 1px black solid;
    width: 90px;
    height: 128px;
    margin-right: 4px;
    margin-bottom: 4px;
    }

    Use 90px instead of 96.

    Maybe create .css files specific for IE?

     
  • Katie Russell

    Katie Russell - 2008-10-20

    how adaptable will this change be to adding extra columns? i mean will the number (3) of columns be hardcoded in in a complicated way?

    just incase we ever get round to adding things like the dm score column!

    Thanks :)

     
  • dsaavedra

    dsaavedra - 2008-10-21

    "how adaptable will this change be to adding extra columns? i mean will the
    number (3) of columns be hardcoded in in a complicated way?

    just incase we ever get round to adding things like the dm score column!

    Thanks :)"

    I think ill take a better look at this bug, because indeed the solution i gave is just a quick fix, we need something better.

     
  • dsaavedra

    dsaavedra - 2008-10-21

    Ok, much better solution:

    Add this to index.php and all files of the stendhal_website project that are standalone (as in, they are requested by the client and they start the generation of the final html page sent to the client).

    <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">

    That fixes almost everything i think. (will try more)

    If you are curious...
    http://webdesign.about.com/cs/doctype/a/aaquirksmode.htm

     
  • dsaavedra

    dsaavedra - 2008-10-21

    K, i have added a patch with the change to the patch tracker, just try it and commit if you want :-P

     
  • Katie Russell

    Katie Russell - 2009-02-28
    • status: open --> closed-fixed
     
  • Katie Russell

    Katie Russell - 2009-02-28

    Thank you your patch worked great (it was applied some time back but the person who applied it didnt close this bug) have attached new screenshot (cropped)
    File Added: c7ec9c950368f16038cd032f94cb8da8.png

     

Anonymous
Anonymous

Cancel  Add attachments