#2578 Stendhal: after death, wrong level is displayed

closed-fixed
nobody
None
6
2007-05-17
2006-09-07
No

After a player dies the new level is supposed to be
displayed in the text box. As far as I recall, this
worked correctly in 0.51. However in 0.52 (not sure
about 0.53) the new level message is usually wrong.
I.e. it'll say 'xx has died, xx's new level is 41',
which was xx's old level, and really xx will have
dropped to 40.

Discussion

  • GreyKnight

    GreyKnight - 2006-10-04

    Logged In: YES
    user_id=1612846

    If I'm reading this correctly, the problem is that
    RPEntity::onDead() wants to have the old value of the dead
    person's XP for calculating XP reward for the killer, then
    it invokes the update that produces this erroneous message,
    *then* the rest of Player::onDead() is executed, lowering
    the XP value. I propose that XP be updated *before* the call
    to super.onDead() (that is, RPEntity::onDead()), and we
    adjust the XP reward calculations to take that into account.
    That is, every getXP() in RPEntity::onDead() should be
    multiplied by 10/9 (since the XP reduction is currently
    10%). I shall post a patch to this effect later.

     
  • GreyKnight

    GreyKnight - 2006-10-05

    Logged In: YES
    user_id=1612846

    This should be fixed by patch 1570890

     
  • Katie Russell

    Katie Russell - 2006-11-09

    Logged In: YES
    user_id=1560922

    When I last died, in version 0.55, There was no 'new level'
    message at all. However my health points remained at the
    value they had been before death (1030, incidentally, I was
    lvl 93) - yet in reality I had dropped to level 89 or 90, as
    the next XP I earned gave a message saying 'kymara reaches
    level 90', and my HP changed to 1000 which is correct for a
    level 90 character. Unfortunately I did not perform 'Look'
    straight after death to see if I was 89 (and one point away
    from 90) or 90 (but the system hadn't told me that yet).
    This is quite confusing, can someone look into it again please?

     
  • Katie Russell

    Katie Russell - 2006-11-09
    • priority: 5 --> 6
     
  • Nobody/Anonymous

    Logged In: NO

    As of 0.58, after a person dies there level remains the same (HP and all) until they gain XP from any source.

     
  • Miguel Angel Blanch Lardin

    Logged In: YES
    user_id=3949
    Originator: NO

    Is this one fixed?

     
  • Miguel Angel Blanch Lardin

    • status: open --> pending-fixed
     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks