From: RefuX Z. <re...@ya...> - 2002-02-06 23:31:23
|
Just finished adding JUNIT tests to the Ant scripts. A couple of Questions/Points 1. Allot of the unit tests require various property files in the Module property directory. Currently I just copy over the needed prop files, unit test and then delete them. However the problem is that changes to the generic property files can now break the unit tests. The solution is to store all the required properties in the module property dir, the bad side of that is if some property file format changes then there are lots of files that need to be updated! Anyways, its works fine the way it is. Just wondering if there is some consensus for doing it another way? 2. From running the Unit tests I found a problem in PropertyTreeManagerImpl. Basically it boils down to a inconsistency in how the Property directory is defined. With PropertyTreeManagerImpl the PropertyDir is set in the constructor, but in the BasicPropertyBuilder which PropertyTreeManagerImpl calls it was using the PropertyProvider to load the Properties, however PropertyProvider uses the System property "arch4j.property.directory" to look for Properties. So the BasicPropertyBuilder wasn't able to find the file referred to by PropertyTreeManagerImpl. This issue was easy enuf to fix/patch, however maybe thought needs to be given as to if PropertyTreeManagerImpl allows its dir to be set in the constructor. 3. For some reason with all the files in CVS, every single line is terminated with \r\r\n which basically gives double line spacing to every file when viewed in Netbeans and various merge tools. I wrote a little prog that strips out the \r\r and the files look fine. So I need to check in EVERYTHING (woo!). Should I be checking in under any specific branch or anything like that? I guess this is an Al question. Thats all folks! __________________________________________________ Do You Yahoo!? Send FREE Valentine eCards with Yahoo! Greetings! http://greetings.yahoo.com |