[Bug report] Hi, have a patch for some php notice

Brought to you by: kshamaa

[Bug report] Hi, have a patch for some php notice

Forum: Help

Creator: Denis Chenu

Created: 2014-01-22

Updated: 2022-03-19

Denis Chenu - 2014-01-22

Hi,

Again for LimeSurvey, not sure the patch is OK. Can not really control.

I made a fork, you can see the patch here:
https://github.com/Shnoulle/Ar-PHP/commit/29cfb1ecea738f34ff9770b6a3b5af659272e245

The bug was seen on official LimeSUrvey version under some condition in specific arabic survey.
The patch was tested in same condition.

Thanks,
Denis

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Khaled Al-Shamaa - 2022-03-19

Dear Denis,

Thanks for your help! Please use the latest version of this Ar-PHP library that is available here:
https://github.com/khaled-alshamaa/ar-php

I will be happy to collaborate with the LimeSurvey developer team to replace the old ar-php version 3.6.0 that LimeSurvey currently used by adding the following line into your composer.json file in the "require" section:
"khaled.alshamaa/ar-php": "^6.2",

You can get some implementation hints from here:
https://github.com/bagisto/bagisto/blob/bf1c3f21af912800ffad5dcf68b9a486af0f6c81/packages/Webkul/Admin/src/Http/Controllers/Sales/InvoiceController.php#L159

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.