Menu

#21 Include guards don't conform to #define style

0.8
closed
Alex
style (1)
2013-07-25
2013-04-18
Alex
No

Example:
FILE_pugg_KERNEL_H
According to the C++ Programming Style Guidelines, it should be entirely upper case.


Fix: [287e07]
Guards are now in format PUGG_ in all upper case, with directory denominators and dots as underscores.

Related

Commit: [287e07]
Wiki: Release 0.8

Discussion

  • Alex

    Alex - 2013-04-18
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,5 +1,3 @@
     Example:
    -
         FILE_pugg_KERNEL_H
    -
     According to the [C++ Programming Style Guidelines](http://geosoft.no/development/cppstyle.html#Include Files), it should be entirely upper case.
    
     
  • Alex

    Alex - 2013-05-08
    • labels: --> style
     
  • Alex

    Alex - 2013-05-16
    • Dependancy: --> 0.8
     
  • Alex

    Alex - 2013-05-16

    This must be kept on hold until all other 0.8 bugs are closed so no funny merges need to be done.

     
  • Alex

    Alex - 2013-05-16
    • status: open --> wait-depend
     
  • Alex

    Alex - 2013-07-11
    • status: wait-depend --> accepted
     
  • Alex

    Alex - 2013-07-25
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,7 @@
     Example:
         FILE_pugg_KERNEL_H
     According to the [C++ Programming Style Guidelines](http://geosoft.no/development/cppstyle.html#Include Files), it should be entirely upper case.
    +
    +------
    +Fix: [287e07]
    +Guards are now in format PUGG_<path> in all upper case, with directory denominators and dots as underscores.
    
    • status: accepted --> closed
    • assigned_to: Alex
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.