[Appsunit-develop] [cvscommit] project/src/net/sourceforge/appsunit/environment DbSession.java, 1.
Status: Beta
Brought to you by:
jancumps
|
From: Jan C. <jan...@us...> - 2006-11-30 21:38:55
|
Update of /cvsroot/appsunit/project/src/net/sourceforge/appsunit/environment In directory sc8-pr-cvs11.sourceforge.net:/tmp/cvs-serv30688/environment Modified Files: DbSession.java AppsSession.java Log Message: Checkstyle cleanup. Index: AppsSession.java =================================================================== RCS file: /cvsroot/appsunit/project/src/net/sourceforge/appsunit/environment/AppsSession.java,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** AppsSession.java 30 Nov 2006 21:06:11 -0000 1.5 --- AppsSession.java 30 Nov 2006 21:38:54 -0000 1.6 *************** *** 37,40 **** --- 37,41 ---- * @TODO replace literal value insertion by parameter binding. */ + @SuppressWarnings("net.sourceforge.pmd.rules.UnusedLocalVariableRule") public static void logon(final Connection connection, final String user, final String responsibility, final String application) *************** *** 89,92 **** --- 90,97 ---- // call the fnd_global api to log on to the apps + int userColumn = 1; + int respColumn = userColumn + 1; + int appColumn = respColumn + 1; + CallableStatement cstmt = null; cstmt = connection.prepareCall( *************** *** 96,103 **** + ", resp_appl_id => ?" + ", security_group_id => null)}"); ! cstmt.setInt(1, usr); ! cstmt.setInt(2, rsp); ! cstmt.setInt(3, appl); ! try { // the first call somethimes fails. --- 101,108 ---- + ", resp_appl_id => ?" + ", security_group_id => null)}"); ! cstmt.setInt(userColumn, usr); ! cstmt.setInt(respColumn, rsp); ! cstmt.setInt(appColumn, appl); ! try { // the first call somethimes fails. Index: DbSession.java =================================================================== RCS file: /cvsroot/appsunit/project/src/net/sourceforge/appsunit/environment/DbSession.java,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** DbSession.java 30 Oct 2006 11:07:59 -0000 1.5 --- DbSession.java 30 Nov 2006 21:38:54 -0000 1.6 *************** *** 49,53 **** * @throws java.lang.Exception Exceptions are not caught. * They will be passed to the caller. ! * @TODO: parameterize nls settings */ @SuppressWarnings("net.sourceforge.pmd.rules.CloseResource") --- 49,53 ---- * @throws java.lang.Exception Exceptions are not caught. * They will be passed to the caller. ! * TODO: parameterize nls settings */ @SuppressWarnings("net.sourceforge.pmd.rules.CloseResource") *************** *** 92,97 **** throw e; } ! ! if (connection == null ) { throw new NullPointerException("Database connection is null."); } --- 92,97 ---- throw e; } ! ! if (connection == null) { throw new NullPointerException("Database connection is null."); } |