Menu

Export ordinals are incorrect in APNG patch

Main Forum
2024-02-24
2024-02-26
  • Clinton Ingram

    Clinton Ingram - 2024-02-24

    Howdy @maxst,

    Thanks for maintaining this patch.

    I've been using the other APNG patch for a while, but it hasn't been updated in a few versions, and I thought I'd give this one a try. I'm getting build errors, however.

    This patch does not update the ordinals for DLL exports in png.h correctly since the addition of png_get_eXIf_1 and png_set_eXIf_1, resulting in a mismatch with the ordinals defined in symbols.def (which was updated).

    Specifically, the PNG_EXPORT lines from 401 to 464 in the patch need to have the ordinals increased by 2. Interestingly, PNG_EXPORT_LAST_ORDINAL on line 477 was updated correctly.

    Can you fix that for the 1.6.43 patch?

     
  • Max Stepin

    Max Stepin - 2024-02-26

    Thanks for letting me know! Fixed in 1.6.43

     

Log in to post a comment.