[Apc-aa-coders] getting rid of register globals

[Michael M. <mi...@gn...>]

Hi

just wanted to check whether this is the right way to do this.

I have changed:

include/util.php3

function shtml_query_string() {
    global $QUERY_STRING_UNESCAPED, $REDIRECT_QUERY_STRING_UNESCAPED, 
$REQUEST_URI;
    // there is problem (at least with $QUERY_STRING_UNESCAPED), when
    // param=a%26a&second=2 is returned as param=a\\&a\\&second=2 - we can't
    // expode it! - that's why we use $REQUEST_URI, if possible

    if(!ini_get('register_globals')) {
        $ret_string = ($_SERVER['REQUEST_URI'] AND 
strpos($_SERVER['REQUEST_URI'],'?')) ?
                            
substr($_SERVER['REQUEST_URI'],strpos($_SERVER['REQUEST_URI'], '?')+1) :
                      ( 
isset($_SERVER['REDIRECT_QUERY_STRING_UNESCAPED'])    ?
                            
stripslashes($_SERVER['REDIRECT_QUERY_STRING_UNESCAPED']) :
                            
stripslashes($_SERVER['QUERY_STRING_UNESCAPED']) );
        return magic_strip($ret_string);
    }
    $ret_string = ($REQUEST_URI AND strpos($REQUEST_URI, '?')) ?
                            substr($REQUEST_URI, 
strpos($REQUEST_URI, '?')+1) :
                  ( isset($REDIRECT_QUERY_STRING_UNESCAPED)    ?
                            stripslashes($REDIRECT_QUERY_STRING_UNESCAPED) :
                            stripslashes($QUERY_STRING_UNESCAPED) );
    // get off magic quotes
    return magic_strip($ret_string);
}

I guess there's other places where I should look - especially in the admin but 
this seems to make views work

mimo