[Apc-aa-coders] Minor bug fix f_r

[Marek T. <ma...@gn...>]

Hi,
I've fixed a small bug in f_r - RSS tag. It can take parameters (although it's not documented), but wouldn't unalias the first one
when it starts with "{". I've sent it to cvs.

# diff item.php3 item.php3-
605a606
>
637a639
>
638a641
>
646,647c649,651
<     if (strpos($p[0],"{") !== false) // It can't be a field, must be expandable
<       {return $this->RSS_restrict(strtr( $this->unalias($p[0]), '#/', ':/'),500) ;}
---
>
>     if (strpos($p[0],"{")) // It can't be a field, must be expandable
>       return $this->RSS_restrict(strtr( $this->unalias($p[0]), '#/', ':/'),500) ;



> -----Original Message-----
> From: apc...@li...
> [mailto:apc...@li...]On Behalf Of Mitra
> Sent: 3. ledna 2004 9:13
> To: apc...@li...
> Subject: [Apc-aa-coders] Obscure bug with aliases coming from wrong
> slice
>
>
> I've been tracking down a weird bug with aliases coming from the wrong slice.
>
> I'm doing for example view.php3?vid=47&cmd[47]=x-47-8823
>
> This works fine, even though View 47 is defined in one slice, and
> item 8823 is found in another (the slices have almost identical
> structure).
>
> BUT ......
>
> The headline _#HDLNLINK
> is expanded according to the definitions in the slice where view 47
> is defined and NOT in the slice where item 8823 is defined.
>
> This seems like the wrong behavior i.e. the Alias is a property of
> the slice which is a property of the ITEM
>
> I can't figure out exactly what is going on - its somewhere in the
> interaction between itemview->get_output and item-unalias, where
> $CurItem is built artificially, rather than being a real item.
>
>   I have never been able to figure out this part of the code - and
> cant' quite understand why the "item" class isn't left cleanly as
> being based on the item and its slice rather than also what we want
> to do with it .
>
> Is this correct behavior - if not then maybe someone (Honza?) who
> understands itemview.php3 can fix it?
>
> I don't care that much, now I know the bug is there i can work around
> it. Its really only going to hit big sites which have a number of
> almost identical slices.  In fact, I only hit it because I was
> editing the aliases in one of the slices and couldn't figure out why
> the output was still using the old definition.
>
> - Mitra
>
> --
> Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
> home 02-6684-8096  mobile 0414-648-722  office 02-6684-6182
> Byron Community Knowledge Management Project www.byronkm.com
>
> Life is a Mystery to be Lived, not a Problem to be Solved
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IBM Linux Tutorials.
> Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
> Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
> Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
> _______________________________________________
> Apc-aa-coders mailing list
> Apc...@li...
> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>