From: Mitra <mi...@ea...> - 2003-05-12 22:25:47
|
Yes - agreed it is not as important, the problem with caching having the right slice id is however crucial, because otherwise the data can change, but the cache delivers the OLD value. This was how I spotted the bug, I was changing data, and the view wasn't changing. - Mitra At 5:23 PM +0200 12/5/03, Honza Malik wrote: >Your solution with changing slice_id for itemview is good. There should >be the slice_id of slice, where items are stored and not the one, where >view definition is stored. > >In fact, the itemview caching is not so important, now, because most of >the cases should be catched be view caching (which is on higher level - >so quicker). > > Honza > >On Ne, 2003-05-11 at 16:04, Mitra wrote: >> Honza >> >> I've found what looks like a bug in caching, >> >> get_output_cached stores in the cache based on $this->slice_info->id >> >> BUT ..... >> >> if it is called from GetViewFromDB, which has been called with a >> view_param containing slice_id, then this slice_info->id still refers >> to the slcie where the View was DEFINED, not to the >> View_param/slice_id >> >> The easiest fix, is to set slice_info->id to that in view_param, any >> other fix would be a bit harder to figure out. >> >> Any idea if this will break anything? it seems to work, but I'm not >> 100% certain, so I haven't committed it to CVS. >> >> - Mitra >> >> >> -- >> Mitra Technology Consulting - www.mitra.biz - mi...@mi... >> 02-6684-8096 or 0414-648-722 >> >> Life is a Mystery to be Lived, not a Problem to be Solved >> >> >> >> ------------------------------------------------------- >> Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara >> The only event dedicated to issues related to Linux enterprise solutions >> www.enterpriselinuxforum.com >> >> _______________________________________________ >> Apc-aa-coders mailing list >> Apc...@li... >> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders >> > > > > >------------------------------------------------------- >Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara >The only event dedicated to issues related to Linux enterprise solutions >www.enterpriselinuxforum.com > >_______________________________________________ >Apc-aa-coders mailing list >Apc...@li... >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-722 Life is a Mystery to be Lived, not a Problem to be Solved |