[Apc-aa-coders] Who broke my code?

[Jakub A. <jak...@se...>]

Hi,

someone broke my code in mail.php3, function send_mail_from_table. My
own code was commented out and the function new_unalias_recurent was
there instead. But the parameters to this function were all bad and it
was not working in the cycle as it should and so on.

Why? Who? Not that it was so much damage, I only deleted the changes and
returned to my code. But it is strange because the changes were really
so incorrect.

Jakub

This is the broken state:

    if (is_array ($aliases)) {
/*
        // I don't know how to work with unaliasing. Thus I try to
pretend
        // having an item. 
        reset ($aliases);
        while (list ($alias, $translate) = each ($aliases)) {
            // I create the "columns"
            $cols[$alias][0] = array (
                "value" => $translate,
                "flag" => FLAG_HTML);
            // and "aliases" 
            $als [$alias] = array ("fce"=>"f_h", "param"=>$alias);
        }
        $item = new Item ("", $cols, $als, "", "" ,"");
*/
        while (list ($key, $value) = each ($record)) 
#            $record[$key] = $item->unalias ($value);
	    $level = 0; $maxlevel = 0;
	    $record[$key] = new_unalias_recurent($value, "", $level,
$maxlevel, null, null, $aliases);
    }