apc-aa-coders — Discussion only useful to active developers.

[Apc-aa-coders] Re: [Apc-aa-general] CVS updates for zids

[Mitra <mi...@mi...>]

At 6:08 PM +0100 22/1/03, Honza Malik wrote:
>Hi Mitra,
>
>    thans for the changes, it is step forward. A few comments:
>
>1) I fixed small bug in zids->shortids() - check CVS

Thanks - I guess none of my test views are using short ids!

>2) You are using array_slice, array_map functions which are implemented
>only in PHP4 (array_map PHP 4 >=3D 4.0.6). So far we use only PHP3
>functions in AA. Maybe is the time to change, but we have at least ask
>apc-aa-general.

I'll ask.

If necessary, maybe there are equivalents of any PHP4 functions we 
are using, for example an implementation of array_map written in 
PHP3, that we could conditionally include?

>
>3) Your assumption that packed ids are EXACTLY 16 characters long (and
>unpacked are EXACTLY 32 characters long) is unfortunately wrong. I can't
>say you why - we generate the ids by new_id() function, but in our
>database are packed ids for item 16 (in 91907 items), 15 (366) and 14
>(4) characters long.

Strange - because new_id uses "md5" which has to return 128 bits.

I wonder if these were ids which generated a leading ascii zero, the 
ratios look reasonable for this, i.e. 919007/366 =3D 251, which is 
close to a one in 256 chance, i.e. something that occurred when 8 
bits (2^8=3D256) all were zero.    This makes sense if we assume that 
md5 returns a number which the ereg in new_id casts as a string, and 
so ignores the leading zero.

I've fixed zids.php3 to allow 12..16 character packed ids, and 24..32 
long, but this could break my tagged ids. I've also fixed 
util.php3.new_id to only return a string of exactly 16 chars.


>
>4) You wrote:
>>  The main reason for doing this was to add tagged ids, i.e. being able
>>  to have a field in a record that includes an extra piece of
>>  information to type a link, for example the existing related_sel.php3
>>  adds an 'x','y' or 'z' for the direction of the link (although this
>>  doesn't seem to be used anywhere at the moment!).
>
>It is good idea of tagged ids.

Thanks - I'm building a site now that uses them.

>On the other hand the 'x', 'y' and 'z' in
>related_sel.php3 is not exactly the same as tagged ids - it is never
>writen to the database. We add 'x', ... just as information to
>StoreItem() function (see insert_fnc_ids() in include/itemfunc.php3 -
>there  ut is used). In this function we remove 'x', ... and to the
>database we store untagged item ids!


This is what I keep asking (unanswered) questions about. In 
related_sel.php3 you have three buttons "Add" "Add Mutual" "Add 
Backward" which add "x", "y" or "z", if you add the result as an id 
then its is stripped, but if you add it as text it is stored, but 
doesn't seem to be used anywhere, and didn't work with related views! 
So why were the three buttons put in if the code doesn't use them, or 
was this some project that never got finished.

I don't care too much ... except that I've been trying very hard not 
to break code, that I couldn't figure out how it could ever be used!

>
>5) In zids.php3 you wrote:
>
>function id_t2l(&$str) {
>#TODO: Look online for quicker way to substr last 32 chars - mitra
>         if (ereg("(.*)([0-9a-f]{32})",$str,$parts))
>                 return $parts[2];
>
>The quicker way is: substr($str, -32), but see 3)

Ok - I'll make this 24..32, and I guess we can't use tags that end in 
a hex character [0-9a-f)

- Mitra


>On =DAt, 2003-01-21 at 07:48, Mitra wrote:
>>  Some big changes  on the CVS version.
>>
>>  DO NOT DOWNLOAD ON LIVE SERVERS YET
>  >
>  > The big change is the id encapsulation discussed on here a couple of
>  > weeks ago. I've added a class "zids" which encapsulates an array of
>  > ids.
>  >
>  > Basically the way it works is to store the ids in whatever format
>>  they are supplied in, and then has methods to convert and return them
>>  in the format needed, so for example it can be initialized with
>>  packed ids, and then return long ids.
>>
>>  The main reason for doing this was to add tagged ids, i.e. being able
>  > to have a field in a record that includes an extra piece of
>>  information to type a link, for example the existing related_sel.php3
>>  adds an 'x','y' or 'z' for the direction of the link (although this
>>  doesn't seem to be used anywhere at the moment!).
>>
>>  In case you are interested I need the tagged ids for a project where
>>  I want to flag businesses based on criteria (organic, community
>>  supporter etc)  but want to have a value (good, medium, bad) on each
>>  link.
>>
>>  I've changed code to use this class in places where I need it, its
>>  generally applicable so gradually I'll change code as I work in
>>  different places.  Because of the way the zids class is written, the
>>  tagged ids won't effect any code not designed to handle them because
>>  they'll be converted to long or quoted etc ids in those places.
>>
>>  The code also includes other methods for working on ids or collection
>>  of ids, for example there is a "sqlin()" method which returns a
>>  string like 'item.id IN ("12345","6778")'
>>
>>  Because this code makes changes in lots of places, its possible I've
>>  broken something that I haven't been able to test. Please email me
>>  and I'll make rapid fixes.
>>
>>  One other change I've made is to add a global variable that works
>>  like $debug, but just gives warnings on places that something strange
>>  is noticed , for example trying to unpack an id which is already
>>  unpacked.  I encourage the use of this flag to help track errors,
>>  without generating warnings for users.
>>
>>  It would be great if people with non-active installations could test
>>  this, i.e. people for whom finding a bug won't muck up a live server!
>>
>>  Note the CVS version also includes Jakub's system-wide  m_gettext
>>  changes, so that is another reason to download and test on a non-live
>>  installation.
>>
>>  I'll be happy to take bug reports and treat them as a priority to get
>>  them fixed.
>>
>>  - Mitra
>>
>>
>>  01/21/03 - code rule changes
>>            - added global flag $errcheck like $debug but generates
>>  warnings on str
>>  angeness
>>            - added zids.php3 to encapsulate id management including:
>>              * adds support for tagged ids in many places (not all yet)
>>              ** If related item window field set to store text, it will
>>  cleanly ed
>>  it these
>>              *** More changes to related item window coming
>>              * duplicates pack_id and unpack_id to pack_id128 and
>>  unpack_id128 whi
>>  ch check type
>>            - commented out require of  _lang.php3 files from config.php3
>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Scholarships for Techies!
>Can't afford IT training? All 2003 ictp students receive scholarships.
>Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more.
>www.ictp.com/training/sourceforge.asp
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] default_fnc_variable

[Jakub A. <jak...@se...>]

I found a function default_fnc_variable() in itemfunc.php3 for Default
field value added by Ram Prasad on 05-March-2002. This is a bad
function. It returns ANY global variable the name of which you give as
parameter. 

Ram, what did you need this function for? Let's correct it to return
only one of allowed variables or delete it.

Jakub

Re: [Apc-aa-coders] Alerts

[Honza M. <hon...@ec...>]

Jakub is rewriting Alerts module, so it is not working, now. Please wait
for new version of alerts.

   Honza 

On St, 2003-01-22 at 18:03, Ram Prasad wrote:
> Hi
> 
> We updated apc-aa and I am unable to find the alert configuration
> options. Am I missing something or is Alert configuration missing in the
> current version ?
> 
> - Ram
> 
> Ram Prasad. P
> http://www.megalinux.net
>  
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Scholarships for Techies!
> Can't afford IT training? All 2003 ictp students receive scholarships.
> Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more.
> www.ictp.com/training/sourceforge.asp
> _______________________________________________
> Apc-aa-coders mailing list
> Apc...@li...
> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
> 

[Apc-aa-coders] Alerts

[Ram P. <ra...@pa...>]

Hi

We updated apc-aa and I am unable to find the alert configuration
options. Am I missing something or is Alert configuration missing in the
current version ?

- Ram

Ram Prasad. P
http://www.megalinux.net
 

[Apc-aa-coders] Re: [Apc-aa-general] CVS updates for zids

[Honza M. <hon...@ec...>]

Hi Mitra,

   thans for the changes, it is step forward. A few comments:

1) I fixed small bug in zids->shortids() - check CVS

2) You are using array_slice, array_map functions which are implemented
only in PHP4 (array_map PHP 4 >=3D 4.0.6). So far we use only PHP3
functions in AA. Maybe is the time to change, but we have at least ask
apc-aa-general.

3) Your assumption that packed ids are EXACTLY 16 characters long (and
unpacked are EXACTLY 32 characters long) is unfortunately wrong. I can't
say you why - we generate the ids by new_id() function, but in our
database are packed ids for item 16 (in 91907 items), 15 (366) and 14
(4) characters long.

4) You wrote:
> The main reason for doing this was to add tagged ids, i.e. being able=20
> to have a field in a record that includes an extra piece of=20
> information to type a link, for example the existing related_sel.php3=20
> adds an 'x','y' or 'z' for the direction of the link (although this=20
> doesn't seem to be used anywhere at the moment!).

It is good idea of tagged ids. On the other hand the 'x', 'y' and 'z' in
related_sel.php3 is not exactly the same as tagged ids - it is never
writen to the database. We add 'x', ... just as information to
StoreItem() function (see insert_fnc_ids() in include/itemfunc.php3 -
there  ut is used). In this function we remove 'x', ... and to the
database we store untagged item ids!

5) In zids.php3 you wrote:

function id_t2l(&$str) {
#TODO: Look online for quicker way to substr last 32 chars - mitra
        if (ereg("(.*)([0-9a-f]{32})",$str,$parts))
                return $parts[2];

The quicker way is: substr($str, -32), but see 3)

   Honza


On =DAt, 2003-01-21 at 07:48, Mitra wrote:
> Some big changes  on the CVS version.
>=20
> DO NOT DOWNLOAD ON LIVE SERVERS YET
>=20
> The big change is the id encapsulation discussed on here a couple of=20
> weeks ago. I've added a class "zids" which encapsulates an array of=20
> ids.
>=20
> Basically the way it works is to store the ids in whatever format=20
> they are supplied in, and then has methods to convert and return them=20
> in the format needed, so for example it can be initialized with=20
> packed ids, and then return long ids.
>=20
> The main reason for doing this was to add tagged ids, i.e. being able=20
> to have a field in a record that includes an extra piece of=20
> information to type a link, for example the existing related_sel.php3=20
> adds an 'x','y' or 'z' for the direction of the link (although this=20
> doesn't seem to be used anywhere at the moment!).
>=20
> In case you are interested I need the tagged ids for a project where=20
> I want to flag businesses based on criteria (organic, community=20
> supporter etc)  but want to have a value (good, medium, bad) on each=20
> link.
>=20
> I've changed code to use this class in places where I need it, its=20
> generally applicable so gradually I'll change code as I work in=20
> different places.  Because of the way the zids class is written, the=20
> tagged ids won't effect any code not designed to handle them because=20
> they'll be converted to long or quoted etc ids in those places.
>=20
> The code also includes other methods for working on ids or collection=20
> of ids, for example there is a "sqlin()" method which returns a=20
> string like 'item.id IN ("12345","6778")'
>=20
> Because this code makes changes in lots of places, its possible I've=20
> broken something that I haven't been able to test. Please email me=20
> and I'll make rapid fixes.
>=20
> One other change I've made is to add a global variable that works=20
> like $debug, but just gives warnings on places that something strange=20
> is noticed , for example trying to unpack an id which is already=20
> unpacked.  I encourage the use of this flag to help track errors,=20
> without generating warnings for users.
>=20
> It would be great if people with non-active installations could test=20
> this, i.e. people for whom finding a bug won't muck up a live server!
>=20
> Note the CVS version also includes Jakub's system-wide  m_gettext=20
> changes, so that is another reason to download and test on a non-live=20
> installation.
>=20
> I'll be happy to take bug reports and treat them as a priority to get=20
> them fixed.
>=20
> - Mitra
>=20
>=20
> 01/21/03 - code rule changes
>           - added global flag $errcheck like $debug but generates=20
> warnings on str
> angeness
>           - added zids.php3 to encapsulate id management including:
>             * adds support for tagged ids in many places (not all yet)
>             ** If related item window field set to store text, it will=20
> cleanly ed
> it these
>             *** More changes to related item window coming
>             * duplicates pack_id and unpack_id to pack_id128 and=20
> unpack_id128 whi
> ch check type
>           - commented out require of  _lang.php3 files from config.php3

RE: [Apc-aa-coders] Conflicts with new CVS version - and suggested fixes

[Mitra <mi...@mi...>]

Ok - I fixed this one in my last CVS update,

- Mitra


At 11:19 AM +1100 21/1/03, Mitra wrote:
>No - that isn't what I meant
>
>Your code is fine, but due to the way config.php3 is different on 
>everyone's system then the CVS update won't work for anyone with a 
>different language than you.
>
>The problem is with
>
>/*
># Language: uncomment one language  file
>require ($GLOBALS[AA_INC_PATH] . "en_common_lang.php3");  # English
># require ($GLOBALS[AA_INC_PATH] . "cz_common_lang.php3");  # Czech
># require ($GLOBALS[AA_INC_PATH] . "es_common_lang.php3");  # Spanish
># require ($GLOBALS[AA_INC_PATH] . "sk_common_lang.php3");  # Slovak
># require ($GLOBALS[AA_INC_PATH] . "de_common_lang.php3");  # Deutsch
># require ($GLOBALS[AA_INC_PATH] . "ro_common_lang.php3");  # Romanian
># require ($GLOBALS[AA_INC_PATH] . "ja_common_lang.php3");  # Japan
>*/
>
>
>After your changes, the require of "en_common_lang.php3" won't work any more.
>
>The fix is to comment out the entire section, that should work with 
>merging into most people's config.php3
>
>- Mitra
>
>
>
>At 4:49 PM +0100 20/1/03, Jakub Adamek wrote:
>>Mitra,
>>
>>I hope you mean DEFAULT_LANG_FILE. This setting is used with
>>mini-gettext much like it was before with language constants. There is
>>no problem with it.
>>
>>There is only one new $XMGETTEXT_DESTINATION_DIR variable in
>>config.php3, which is important only when you update language files,
>>i.e. not all superadmins must set it.
>>
>>Jakub
>>
>>>  -----Original Message-----
>>>  From: apc...@li...
>>>  [mailto:apc...@li...] On Behalf Of Mitra
>>>  Sent: Saturday, January 18, 2003 8:58 AM
>>>  To: apc...@so...
>>>  Subject: [Apc-aa-coders] Conflicts with new CVS version - and
>>>  suggested fixes
>>>
>>>
>>>  Jakub
>>>
>>>  I've done a CVS update from your mgettext version.
>>>
>>>  I successfully merged your changes with mine. I have NOT committed my
>>>  changes yet, I don't think my code is stable enough for that,
>>>  although its running fine on my site.
>>>
>>>  There is one  problem I've seen - apart from the missing
>>>  files you mentioned.
>>>
>>>  config.php3 contains an include for the main language file you are
>>>  using, which no longer exists. Which file is included will of course
>>>  vary from machine to machine.
>>>
>>>  I suggest commenting out that part of the config.php3, that way your
>>>  change should merge cleanly with whatever each site has locally.
>>>
>>>  - Mitra
>>>
>>>
>>>  --
>>>  Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
>>>  02-6684-8096  or 0414-648-0722
>>>
>>>  Life is a Mystery to be Lived, not a Problem to be Solved
>>>
>>>
>>>
>>>  -------------------------------------------------------
>>>  This SF.NET email is sponsored by: Thawte.com - A 128-bit
>>>  supercerts will
>>>  allow you to extend the highest allowed 128 bit encryption to
>>>  all your
>>>  clients even if they use browsers that are limited to 40 bit
>>  > encryption.
>>  > Get a guide
>>  > here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
>>  > _______________________________________________
>>  > Apc-aa-coders mailing list
>>  > Apc...@li...
>>  > https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>>>
>>
>>
>>
>>-------------------------------------------------------
>>This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
>>are you planning your Web Server Security? Click here to get a FREE
>>Thawte SSL guide and find the answers to all your  SSL security issues.
>>http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
>>_______________________________________________
>>Apc-aa-coders mailing list
>>Apc...@li...
>>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>
>
>--
>Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
>02-6684-8096  or 0414-648-0722 
>
>Life is a Mystery to be Lived, not a Problem to be Solved


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] alias parsing - scroller

[Mitra <mi...@mi...>]

Did you see my second message - that  I've fixed it and checked it into CVS .

Can you try and install from CVS and try that but  ....

Please install to a test version, the current CVS build has lots of 
changes and may have other bugs - the ones in the changes I've made 
I'll fix as a matter of urgency, but I can't guarrantee it will work 
on your live system

- Mitra


At 10:23 AM +0100 21/1/03, Norbert Brazda wrote:
>From: "Mitra" <mi...@mi...>
>>  Please could you send me a URL where you get this problem, the
>>  simpler the better - e.g. if youi have nested views, then the URL of
>>  the inner view where it happens would be good.
>
>Here is the URL:
>http://changenet.sk/aa/view.php3?vid=251
>
>
>This is top html definition in that view:
>===
><br>
>===
>
>This is odd record definition in that view:
>===
>_#PUB_DATE | _#CREATED#<br>
>{alias:xxx.....:f_b:link_only.......:hl_href.........:?section={switch({category.......3})Spravodajstvo-spravy:spr:Spravodajstvo-tlacove:spr:Spravodajstvo-dokumenty:spr:Spravodajstvo-monitor:spr:Publicistika-forum:forum:Publicistika-rozhovor:forum:Publicistika-analyza:forum:Publicistika-profil:forum:Publicistika-komentar:forum}:headline........::class=headline:}
><br>
>_#RELFOPRE _#ABSTRACT
>{switch({disc_app........})[1-9][0-9]*:
><br>{alias::f_b:hl_href.........:hl_href.........:?&section=forum:[Reakcie#: 
><b>_#D_APPCNT</b>]:full_text.......::1}
>}
><br><br>
>===
>
>This is bottom html definition in that view:
>===
><br>
><span class=menu>
>{scroller:&nbsp;&nbsp;::class="menu"}
></span>
>===
>
>
>
>norobert
>br...@ch...
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by:
>SourceForge Enterprise Edition + IBM + LinuxWorld http://www.vasoftware.com
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] alias parsing - scroller

[Norbert B. <br...@ch...>]

From: "Mitra" <mi...@mi...>
> Please could you send me a URL where you get this problem, the=20
> simpler the better - e.g. if youi have nested views, then the URL of=20
> the inner view where it happens would be good.

Here is the URL:
http://changenet.sk/aa/view.php3?vid=3D251


This is top html definition in that view:
=3D=3D=3D
<br>
=3D=3D=3D

This is odd record definition in that view:
=3D=3D=3D
_#PUB_DATE | _#CREATED#<br>=20
{alias:xxx.....:f_b:link_only.......:hl_href.........:?section=3D{switch(=
{category.......3})Spravodajstvo-spravy:spr:Spravodajstvo-tlacove:spr:Spr=
avodajstvo-dokumenty:spr:Spravodajstvo-monitor:spr:Publicistika-forum:for=
um:Publicistika-rozhovor:forum:Publicistika-analyza:forum:Publicistika-pr=
ofil:forum:Publicistika-komentar:forum}:headline........::class=3Dheadlin=
e:}
<br>
_#RELFOPRE _#ABSTRACT
{switch({disc_app........})[1-9][0-9]*:
<br>{alias::f_b:hl_href.........:hl_href.........:?&section=3Dforum:[Reak=
cie#: <b>_#D_APPCNT</b>]:full_text.......::1}
}
<br><br>
=3D=3D=3D

This is bottom html definition in that view:
=3D=3D=3D
<br>
<span class=3Dmenu>
{scroller:&nbsp;&nbsp;::class=3D"menu"}
</span>
=3D=3D=3D



norobert
br...@ch...

[Apc-aa-coders] m_gettext, is it complete now?

[Mitra <mi...@mi...>]

Jakub

Is the m_gettext conversion complete?

The reason I'm asking is that I'm finding strings in the code such as

L_OFFLINE_ERR_BEGIN

that are still there in the current CVS  version, although their 
definitions have disappeared.

- Mitra

-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] RE: [Apc-aa-general] Mgettext in place

[Mitra <mi...@mi...>]

Could you edit the FAQ item you just changed and put the location of 
the language files that need translating.

- Mitra


At 5:31 PM +0100 20/1/03, Jakub Ad=E1mek wrote:
>Just wanted to mention a small change in the misc/mgettext scripts.
>Added the lang_list variable. Helps when updating only one language. You
>won't notice it.
>
>jakub
>
>>  -----Original Message-----
>>  From: apc...@li...
>>  [mailto:apc...@li...] On Behalf
>>  Of Jakub Adamek
>>  Sent: Friday, January 17, 2003 6:51 PM
>>  To: apc...@li...
>>  Subject: RE: [Apc-aa-general] Mgettext in place
>>
>>
>>  I am sorry, I forgot to send the new language files to CVS
>>  and thus all
>>  slices appear in English now. I will send the files on Monday.
>>
>>  Jakub
>>
>>  > -----Original Message-----
>>  > From: apc...@li...
>>  > [mailto:apc...@li...] On Behalf
>>  > Of Jakub Ad=E1mek
>>  > Sent: Friday, January 17, 2003 11:48 AM
>>  > To: apc...@li...
>>  > Subject: [Apc-aa-general] Mgettext in place
>>  >
>>  >
>>  > Hi all,
>>  >
>>  > I have made the big change and moved all AA scripts to using
>>  > the mini-gettext language environment.
>>  > I hope everything will work. If you made any changes in old
>>  > type language files, please send them to me and I will merge
>>  > them into the new language files.
>>  >
>>  > Jakub
>>  >
>>  > Here is a part of the CHANGES log:
>>  >
>>  > 01/17/03 - changed name loginform.html to loginform.inc, the
>>  > name was nonsense (jakub) 01/17/03 - BIG CHANGE: moved the
>>  > complete AA to mgettext (jakub)
>>  >             * see documentation in include/lang/readme.html and
>>  > misc/mgettext/*
>>  >             * Finished the scripts in misc/mgettext and
>>  > include/mgettext.php3
>>  >             * In almost every script: All language constants
>>  > replaced by
>>  > _m() calls
>>  >             * All language files include/??_????_lang.php3 removed.
>  > >             * Updated language files in include/lang.
>  > >             * Added new item into config.php3:
>  > > $XMGETTEXT_DESTINATION_DIR
>  > >             * Updated doc/install-5.html
>  > >             * Added menu item AA admin / xmgettext
>>  >             * changed global variables in constants.php3 to
>>  > function calls
>>  >             * changed include/init_page.php3 to use mini-gettext
>>  >             * changed slice.php3 to use the
>>  > ??_output_lang.inc language file
>>  >             * changed admin/param_wizard.php3 to use the
>>  > ??_param_wizard.inc language file           
>>  >
>>  >
>>  >
>>  > -------------------------------------------------------
>>  > This SF.NET email is sponsored by: Thawte.com
>>  > Understand how to protect your customers personal information
>>  > by implementing SSL on your Apache Web Server. Click here to
>>  > get our FREE Thawte Apache
>>  > Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
>>  > _______________________________________________
>>  > apc-aa-general mailing list apc...@li...
>>  > https://lists.sourceforge.net/lists/listinfo/apc-aa-general
>>  >
>>
>>
>>
>>  -------------------------------------------------------
>>  This SF.NET email is sponsored by: Thawte.com - A 128-bit
>>  supercerts will
>>  allow you to extend the highest allowed 128 bit encryption to
>>  all your
>>  clients even if they use browsers that are limited to 40 bit
>>  encryption.
>>  Get a guide
>>  here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
>>  _______________________________________________
>>  apc-aa-general mailing list
>>  apc...@li...
>>  https://lists.sourceforge.net/lists/listinfo/apc-aa-general
>>
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
>are you planning your Web Server Security? Click here to get a FREE
>Thawte SSL guide and find the answers to all your  SSL security issues.
>http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

RE: [Apc-aa-coders] Conflicts with new CVS version - and suggested fixes

[Mitra <mi...@mi...>]

No - that isn't what I meant

Your code is fine, but due to the way config.php3 is different on 
everyone's system then the CVS update won't work for anyone with a 
different language than you.

The problem is with

/*
# Language: uncomment one language  file
require ($GLOBALS[AA_INC_PATH] . "en_common_lang.php3");  # English
# require ($GLOBALS[AA_INC_PATH] . "cz_common_lang.php3");  # Czech
# require ($GLOBALS[AA_INC_PATH] . "es_common_lang.php3");  # Spanish
# require ($GLOBALS[AA_INC_PATH] . "sk_common_lang.php3");  # Slovak
# require ($GLOBALS[AA_INC_PATH] . "de_common_lang.php3");  # Deutsch
# require ($GLOBALS[AA_INC_PATH] . "ro_common_lang.php3");  # Romanian
# require ($GLOBALS[AA_INC_PATH] . "ja_common_lang.php3");  # Japan
*/


After your changes, the require of "en_common_lang.php3" won't work any more.

The fix is to comment out the entire section, that should work with 
merging into most people's config.php3

- Mitra



At 4:49 PM +0100 20/1/03, Jakub Adamek wrote:
>Mitra,
>
>I hope you mean DEFAULT_LANG_FILE. This setting is used with
>mini-gettext much like it was before with language constants. There is
>no problem with it.
>
>There is only one new $XMGETTEXT_DESTINATION_DIR variable in
>config.php3, which is important only when you update language files,
>i.e. not all superadmins must set it.
>
>Jakub
>
>>  -----Original Message-----
>>  From: apc...@li...
>>  [mailto:apc...@li...] On Behalf Of Mitra
>>  Sent: Saturday, January 18, 2003 8:58 AM
>>  To: apc...@so...
>>  Subject: [Apc-aa-coders] Conflicts with new CVS version - and
>>  suggested fixes
>>
>>
>>  Jakub
>>
>>  I've done a CVS update from your mgettext version.
>>
>>  I successfully merged your changes with mine. I have NOT committed my
>>  changes yet, I don't think my code is stable enough for that,
>>  although its running fine on my site.
>>
>>  There is one  problem I've seen - apart from the missing
>>  files you mentioned.
>>
>>  config.php3 contains an include for the main language file you are
>>  using, which no longer exists. Which file is included will of course
>>  vary from machine to machine.
>>
>>  I suggest commenting out that part of the config.php3, that way your
>>  change should merge cleanly with whatever each site has locally.
>>
>>  - Mitra
>>
>>
>>  --
>>  Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
>>  02-6684-8096  or 0414-648-0722
>>
>>  Life is a Mystery to be Lived, not a Problem to be Solved
>>
>>
>>
>>  -------------------------------------------------------
>>  This SF.NET email is sponsored by: Thawte.com - A 128-bit
>>  supercerts will
>>  allow you to extend the highest allowed 128 bit encryption to
>>  all your
>>  clients even if they use browsers that are limited to 40 bit
>  > encryption.
>  > Get a guide
>  > here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
>  > _______________________________________________
>  > Apc-aa-coders mailing list
>>  Apc...@li...
>>  https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>>
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
>are you planning your Web Server Security? Click here to get a FREE
>Thawte SSL guide and find the answers to all your  SSL security issues.
>http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] alias parsing - scroller

[Mitra <mi...@mi...>]

Norbert

Please could you send me a URL where you get this problem, the 
simpler the better - e.g. if youi have nested views, then the URL of 
the inner view where it happens would be good.

- Mitra


At 1:28 PM +0100 20/1/03, Norbert Brazda wrote:
>It seems that there is error in paring of aliases for scroller in 
>views. We use latest CVS version of AA.
>
>I have this string:
>     {scroller:  ::class="menu"}
>in my view definition and it is not parsed, but just displayed in 
>the output html code.
>
>
>
>
>Norbert Brazda
>br...@ch...
>tel: 0905-729359
>
>ChangeNet  - informacny servis o obcianskej spolocnosti
>Mlynske nivy 41, 821 09  Bratislava, Slovakia
>tel/fax: 02-55560026, eMail: in...@ch...
>http://www.changenet.sk
>
>SPAJAME LUDI, KTORI MENIA SVET
>
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
>are you planning your Web Server Security? Click here to get a FREE
>Thawte SSL guide and find the answers to all your  SSL security issues.
>http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] RE: [Apc-aa-general] Mgettext in place

[<jak...@se...>]

Just wanted to mention a small change in the misc/mgettext scripts.
Added the lang_list variable. Helps when updating only one language. You
won't notice it.

jakub

> -----Original Message-----
> From: apc...@li...=20
> [mailto:apc...@li...] On Behalf=20
> Of Jakub Adamek
> Sent: Friday, January 17, 2003 6:51 PM
> To: apc...@li...
> Subject: RE: [Apc-aa-general] Mgettext in place
>=20
>=20
> I am sorry, I forgot to send the new language files to CVS=20
> and thus all
> slices appear in English now. I will send the files on Monday.
>=20
> Jakub
>=20
> > -----Original Message-----
> > From: apc...@li...=20
> > [mailto:apc...@li...] On Behalf=20
> > Of Jakub Ad=E1mek
> > Sent: Friday, January 17, 2003 11:48 AM
> > To: apc...@li...
> > Subject: [Apc-aa-general] Mgettext in place
> >=20
> >=20
> > Hi all,
> >=20
> > I have made the big change and moved all AA scripts to using=20
> > the mini-gettext language environment.=20
> > I hope everything will work. If you made any changes in old=20
> > type language files, please send them to me and I will merge=20
> > them into the new language files.
> >=20
> > Jakub
> >=20
> > Here is a part of the CHANGES log:
> >=20
> > 01/17/03 - changed name loginform.html to loginform.inc, the=20
> > name was nonsense (jakub) 01/17/03 - BIG CHANGE: moved the=20
> > complete AA to mgettext (jakub)
> >             * see documentation in include/lang/readme.html and
> > misc/mgettext/*
> >             * Finished the scripts in misc/mgettext and=20
> > include/mgettext.php3
> >             * In almost every script: All language constants=20
> > replaced by
> > _m() calls
> >             * All language files include/??_????_lang.php3 removed.
> >             * Updated language files in include/lang.
> >             * Added new item into config.php3:=20
> > $XMGETTEXT_DESTINATION_DIR
> >             * Updated doc/install-5.html
> >             * Added menu item AA admin / xmgettext
> >             * changed global variables in constants.php3 to=20
> > function calls
> >             * changed include/init_page.php3 to use mini-gettext
> >             * changed slice.php3 to use the=20
> > ??_output_lang.inc language file
> >             * changed admin/param_wizard.php3 to use the
> > ??_param_wizard.inc language file           =20
> >=20
> >=20
> >=20
> > -------------------------------------------------------
> > This SF.NET email is sponsored by: Thawte.com
> > Understand how to protect your customers personal information=20
> > by implementing SSL on your Apache Web Server. Click here to=20
> > get our FREE Thawte Apache=20
> > Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
> > _______________________________________________
> > apc-aa-general mailing list apc...@li...
> > https://lists.sourceforge.net/lists/listinfo/apc-aa-general
> >=20
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.NET email is sponsored by: Thawte.com - A 128-bit=20
> supercerts will
> allow you to extend the highest allowed 128 bit encryption to=20
> all your=20
> clients even if they use browsers that are limited to 40 bit=20
> encryption.=20
> Get a guide=20
> here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
> _______________________________________________
> apc-aa-general mailing list
> apc...@li...
> https://lists.sourceforge.net/lists/listinfo/apc-aa-general
>=20

RE: [Apc-aa-coders] Conflicts with new CVS version - and suggested fixes

[<jak...@se...>]

Mitra,

I hope you mean DEFAULT_LANG_FILE. This setting is used with
mini-gettext much like it was before with language constants. There is
no problem with it.

There is only one new $XMGETTEXT_DESTINATION_DIR variable in
config.php3, which is important only when you update language files,
i.e. not all superadmins must set it.

Jakub

> -----Original Message-----
> From: apc...@li... 
> [mailto:apc...@li...] On Behalf Of Mitra
> Sent: Saturday, January 18, 2003 8:58 AM
> To: apc...@so...
> Subject: [Apc-aa-coders] Conflicts with new CVS version - and 
> suggested fixes
> 
> 
> Jakub
> 
> I've done a CVS update from your mgettext version.
> 
> I successfully merged your changes with mine. I have NOT committed my 
> changes yet, I don't think my code is stable enough for that, 
> although its running fine on my site.
> 
> There is one  problem I've seen - apart from the missing 
> files you mentioned.
> 
> config.php3 contains an include for the main language file you are 
> using, which no longer exists. Which file is included will of course 
> vary from machine to machine.
> 
> I suggest commenting out that part of the config.php3, that way your 
> change should merge cleanly with whatever each site has locally.
> 
> - Mitra
> 
> 
> -- 
> Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
> 02-6684-8096  or 0414-648-0722
> 
> Life is a Mystery to be Lived, not a Problem to be Solved
> 
> 
> 
> -------------------------------------------------------
> This SF.NET email is sponsored by: Thawte.com - A 128-bit 
> supercerts will
> allow you to extend the highest allowed 128 bit encryption to 
> all your 
> clients even if they use browsers that are limited to 40 bit 
> encryption. 
> Get a guide 
> here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
> _______________________________________________
> Apc-aa-coders mailing list
> Apc...@li...
> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
> 

[Apc-aa-coders] alias parsing - scroller

[Norbert B. <br...@ch...>]

It seems that there is error in paring of aliases for scroller in views. =
We use latest CVS version of AA.=20

I have this string:
    {scroller:  ::class=3D"menu"}=20
in my view definition and it is not parsed, but just displayed in the =
output html code.




Norbert Brazda
br...@ch...
tel: 0905-729359

ChangeNet  - informacny servis o obcianskej spolocnosti
Mlynske nivy 41, 821 09  Bratislava, Slovakia
tel/fax: 02-55560026, eMail: in...@ch...
http://www.changenet.sk

SPAJAME LUDI, KTORI MENIA SVET

Re: [Apc-aa-coders] Changes: site module, edititem,

[Mitra <mi...@mi...>]

Hmmm -

This is a good point,

One alternative would be to add the AA_CP_Session to the cache string,

Even if this is not sufficient, this is something we need to do.

What do you think?

- Mitra


At 10:50 AM +0100 20/1/03, Honza Malik wrote:
>I found another, much more serious problem in this - caching.
>
>If I update an item on such page (you can test on FAQ), then new page is
>generated from database and my AA_CP_Session id is added. BUT, this page
>is CACHED (internaly in AA for both - slice.php3 as well as for
>view.php3), so EVERYONE who is going to the page obtain the page from
>cache WITH MY SESSION ID.
>
>I think we really have to remove export AA_CP_Session ids outside of
>Admin interface.
>
>    Honza
>
>On Ne, 2003-01-12 at 22:11, Mitra wrote:
>>  Its a good point, I was trying to think of security holes in it.
>>
>>  I think this is a bit of a non-worry for a number of reasons.
>>  1: Most browsers don't send referer URLs any more - really annoying
>>  when you are trying to track things down.
>>  2: The hacker would have to be on a site you linked to, and react
>>  within three hours.
>>
>>  I just don't see this as a big security hole.
>>
>>  - Mitra
>>
>>
>>  At 10:05 PM +0100 12/1/03, Honza Malik wrote:
>>  >On Ne, 2003-01-12 at 02:08, Mitra wrote:
>>  >>  The biggest change is that _#EDITITEM should now work in most cases
>>  >>  outside of the admin interface, with the user being prompted for a
>>  >>  userid/password and then returned back to where they came from.
>>  >
>>  >It's nice. Thanks Mitra.
>>  >
>>  >Just one note: It's not secure to add AA_CP_Session to urls outside of
>>  >AA Admin interface (like in FAQ). If there is any link to any other
>>  >webpage (in FAQ), it is possible to get your session id (AA_CP_Session)
>>  >from 'Referer' field. With this id (or url) you are able to access AA
>>  >admin pages without login (for 3 hours, when session id expires).
>>  >
>>  >I would probably prefer to create the link without the session id (with
>>  >f_e) as default (so users have to log in on every item edit) and then
>>  >maybe create optional f_e for those admins, who knows about this problem
>  > >and don't care. At least we have to mention it in the FAQ.
>  > >
>  > >What you think?
>  > >
>  > >    Honza
>  > >
>  > >>  - Mitra
>  > >>
>  > >>
>>  >>
>>  >>  01/12/02 - changed site module to go to prior sibling when deleting
>>  >>  rather than parent
>>  >>  01/12/02 - added default $item=null to new_unalias_recurent to allow
>>  >>  calling from site module without warnings
>>  >>  01/12/02 - fixed adding AA_CP_Session to url in site module AAPage
>>  >>  where it is already there.
>>  >>  01/12/02 - changes to allow _#EDITITEM to be used outside of 
>>admin interface
>>  >>  01/12/02 - combined several ways of redirecting to a URL into common
>>  >>  function go_return_or_url
>>  >
>>  >
>>  >
>>  >-------------------------------------------------------
>>  >This SF.NET email is sponsored by:
>>  >SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
>>  >http://www.vasoftware.com
>>  >_______________________________________________
>>  >Apc-aa-coders mailing list
>>  >Apc...@li...
>>  >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>>
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
>are you planning your Web Server Security? Click here to get a FREE
>Thawte SSL guide and find the answers to all your  SSL security issues.
>http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] Expanding multi value fields inside {}

[Mitra <mi...@mi...>]

Hi

Should it be possible to expand multi-value fields inside {}

So that for example a view can include

{view.php3?vid=123&cmd[123]=x-123-{relation.......1}}

On my installation it only returns the first value,

its possible I broke something, I thought this used to work, but 
maybe only inside the f_v parameters, where typically it is "_#this"

I'm going to fix to have the same behavior, i.e. where a field is 
multi-value it will return all of them strung together with "-", this 
means using f_h in the string expansion. f_h is fairly simple so that 
seems ok.

- Mitra

-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] Changes: site module, edititem,

[Honza M. <hon...@ec...>]

I found another, much more serious problem in this - caching.

If I update an item on such page (you can test on FAQ), then new page is
generated from database and my AA_CP_Session id is added. BUT, this page
is CACHED (internaly in AA for both - slice.php3 as well as for
view.php3), so EVERYONE who is going to the page obtain the page from
cache WITH MY SESSION ID. 

I think we really have to remove export AA_CP_Session ids outside of
Admin interface.

   Honza

On Ne, 2003-01-12 at 22:11, Mitra wrote:
> Its a good point, I was trying to think of security holes in it.
> 
> I think this is a bit of a non-worry for a number of reasons.
> 1: Most browsers don't send referer URLs any more - really annoying 
> when you are trying to track things down.
> 2: The hacker would have to be on a site you linked to, and react 
> within three hours.
> 
> I just don't see this as a big security hole.
> 
> - Mitra
> 
> 
> At 10:05 PM +0100 12/1/03, Honza Malik wrote:
> >On Ne, 2003-01-12 at 02:08, Mitra wrote:
> >>  The biggest change is that _#EDITITEM should now work in most cases
> >>  outside of the admin interface, with the user being prompted for a
> >>  userid/password and then returned back to where they came from.
> >
> >It's nice. Thanks Mitra.
> >
> >Just one note: It's not secure to add AA_CP_Session to urls outside of
> >AA Admin interface (like in FAQ). If there is any link to any other
> >webpage (in FAQ), it is possible to get your session id (AA_CP_Session)
> >from 'Referer' field. With this id (or url) you are able to access AA
> >admin pages without login (for 3 hours, when session id expires).
> >
> >I would probably prefer to create the link without the session id (with
> >f_e) as default (so users have to log in on every item edit) and then
> >maybe create optional f_e for those admins, who knows about this problem
> >and don't care. At least we have to mention it in the FAQ.
> >
> >What you think?
> >
> >    Honza
> >
> >>  - Mitra
> >>
> >>
> >>
> >>  01/12/02 - changed site module to go to prior sibling when deleting
> >>  rather than parent
> >>  01/12/02 - added default $item=null to new_unalias_recurent to allow
> >>  calling from site module without warnings
> >>  01/12/02 - fixed adding AA_CP_Session to url in site module AAPage
> >>  where it is already there.
> >>  01/12/02 - changes to allow _#EDITITEM to be used outside of admin interface
> >>  01/12/02 - combined several ways of redirecting to a URL into common
> >>  function go_return_or_url
> >
> >
> >
> >-------------------------------------------------------
> >This SF.NET email is sponsored by:
> >SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
> >http://www.vasoftware.com
> >_______________________________________________
> >Apc-aa-coders mailing list
> >Apc...@li...
> >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
> 

Re: [Apc-aa-coders] slice.php3 - leading x's

[Honza M. <hon...@ec...>]

leading 'x' is used for slices.php3 url parameter items[ids], where ids
are long ids plus added leading 'x' - just like:

items[x5462876e8ab29ac95462876e8ab29ac9]=1&items[x65ac876e8a555b29543ea76e8ab29a34]=1

the leading x is necessary for php in order it interprets index as
string and not number.

The usage of items[] parameter you can see on:

http://ecomonitor.cz/clanky.shtml?conds%5B1%5D%5Bpublish_date....%5D=1&conds%5B1%5D%5Bvalue%5D=1%2F20%2F2002&conds%5B1%5D%5Boperator%5D=d%3A%3E%3D

The format string for the display is something like:

<input type="checkbox" name="items[x_#ITEM_ID#]">_#PUB_DATE - 
<b><a href=_#HDLN_URL>_#SOURCE##: _#HEADLINE</a></b><br>

I updated FAQ to be more clear for items[ids] parameter:
   http://apc-aa.sourceforge.net/faq/?debug=1#218 

   Honza


On Po, 2003-01-20 at 03:14, Mitra wrote:
> In slice.php3 around line 311 there is a place where it strips the 
> first character from a value got from $items
> 
> What I can't figure out, is how the x got there, since the parameters 
> to slice don't specify that id's have to have a leading "x"
> 
> Any ideas?
> 
> - Mitra

[Apc-aa-coders] m_gettext bug - no wizard lang files

[Mitra <mi...@mi...>]

The lang files are missing for the wizzard,

If you have this problem, then until Jakub uploads them, comment out 
the "exit" at line 61 of mgettext.php3

- Mitra

-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] slice.php3 - leading x's

[Mitra <mi...@mi...>]

In slice.php3 around line 311 there is a place where it strips the 
first character from a value got from $items

What I can't figure out, is how the x got there, since the parameters 
to slice don't specify that id's have to have a leading "x"

Any ideas?

- Mitra

-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] Coding Standards

[Mitra <mi...@mi...>]

OK so while we are making coding standards ...

Outside of a class definition it is best not to access its member 
variables directly, so for example don't do
auth->auth[$uid]
The reason is that it makes it hard to change the internal data 
representation, which is a part of the reason behind using classes.

Instead create a function in the class that returns what you are 
looking for, and think ahead - i.e. the worst thing you can do is 
just to create access functiosn like "function get_auth()". This just 
adds overhead with no useful encapsulation, instead create useful 
functions like "function is_authorised($uid)"

I suggest these coding standards should be in the doc directory and 
pointed to in the FAQ.
- Mitra


At 10:53 PM +0100 18/1/03, Honza Malik wrote:
>Hello,
>
>    I think now is the time to define some coding standards for
>ActionApps. It help us to have the code as readable as possible for
>everyone. Most of the following rules comes from php PEAR standard:
>http://pear.php.net/manual/en/standards.php
>Most important rules on tne top:
>
>
>- use UNIX end of lines (use \n and never windows \r\n)
>      If we mix both modes, the CVS diffs are unusefull
>
>- Indent 4 spaces, with no tabs
>      Do not use Tabs or use 'insert Tabs as spaces' option of your text
>      editor. Most of the editors (like Jedit or HomeSite) allows it.
>      Then the code will look good in any editor.
>
>- use <?php open tag
>      Do not use any other shorted version like <?, .. There are some
>      problems on some Apache configurations with <?...
>
>- comments should follow phpDoc standard
>      See http://phpdocu.sourceforge.net/
>      Use /*  */ and // for comments, not #
>
>- control structures should look like
>      if ((condition1) || (condition2)) {
>          commands;
>      } else {
>          commands;
>      }
>      Open brace at the end of line
>      if, while, ... separated by space (it is not function call)
>
>- function($var1, $var2=true)
>      No space between function name and open brace allow us easier find
>      the function in the code
>
>- 80 characters wide
>      Try to write the code 80 characters wide, if possible
>
>- quote strings in indexes
>      Allways qoute strings like 'name' in $arr['name'] or $db->f('name')
>      although current PHP do not need it
>
>- use $_GET, $POST, and $_SERVER
>      Use mentioned superglobal arrays to access variables from forms ...
>
>- use return true; instead of return(true);
>      Return is the statement, not a function
>
>- When you commiting changes into CVS, allways update CHANGES file and
>   send a note to apc...@so...
>
>- Document new feature in the FAQ (http://apc-aa.sourceforge.net/faq/)
>   and in the code
>
>- If it is possible, create an example of new feature on Sourceforge
>   installation of AA
>
>- If you changing database structure (adding table, ...), you should
>   update doc/aadb.sql as well as sqlupdate.php3 script
>
>- Before you are going to code some new feature, let us know about,
>   please (apc...@so...)
>
>
>-------------
>I know the current code do not strictly follows mentioned rules, but
>from this time it will ....... hopefully
>
>     Honza
>
>
>
>-------------------------------------------------------
>This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts will
>allow you to extend the highest allowed 128 bit encryption to all your
>clients even if they use browsers that are limited to 40 bit encryption.
>Get a guide here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
>_______________________________________________
>Apc-aa-coders mailing list
>Apc...@li...
>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722 

Life is a Mystery to be Lived, not a Problem to be Solved

Re: [Apc-aa-coders] Don't use tabs and Windows line end

[Mitra <mi...@mi...>]

OK - we can all use spaces in future

But .....

Could I request that we DO NOT make changes across all the files at 
the moment, both Jakub (mgettext) and I (ids) are working on many 
files, and if someone makes any system wide layout changes it is 
going to make merging changes really difficult, we can start doing it 
when we have a stable version again.

- Mitra


At 10:56 PM +0100 18/1/03, Honza Malik wrote:
>Hi Mitra,
>
>    we really do not use tabs. If some tabs are in the code, it is
>mistake and should be replaced. If it is possible, do not use it, please
>(for me the code with 8-spaces tabs is hard to read too).
>
>    Honza
>
>
>On P=E1, 2003-01-17 at 23:17, Mitra wrote:
>>  Jakub
>>
>>  Might it be better just to use standard - i.e. 8 character - tab
>>  widths?  I think that's what most of the source is using now, and a
>>  quick grep finds tabs in 275 of the 378  files in APC.
>>
>>  - Mitra
>>
>>
>>  At 11:16 AM +0100 17/1/03, Jakub Ad=E1mek wrote:
>>  >Please don't use tabs in any sources nor in the CHANGES file. I have
>>  >just found a misformed text in CHANGES due to another tab width than I
>>  >am using.
>>  >
>>  >Set "insert Tabs as spaces" and "indent by using spaces" or similar
>>  >options in your editors. The text are than much better to share.
>>  >
>>  >And I repeat: always use \n Unix line ends (this means you cannot use
>>  >Notepad to edit the files in Windows), CVS can't handle the difference
>>  >between \n and \r\n and hopefully now all files are with \n only.
>>  >
>>  >Jakub
>>  >
>>  >
>>  >
>>  >-------------------------------------------------------
>>  >This SF.NET email is sponsored by: Thawte.com
>>  >Understand how to protect your customers personal information by 
>>implementing
>>  >SSL on your Apache Web Server. Click here to get our FREE Thawte Apache
>>  >Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en
>>  >_______________________________________________
>>  >Apc-aa-coders mailing list
>>  >Apc...@li...
>  > >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders
>  >


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved

[Apc-aa-coders] Coding Standards

[Honza M. <hon...@ec...>]

Hello,

   I think now is the time to define some coding standards for
ActionApps. It help us to have the code as readable as possible for
everyone. Most of the following rules comes from php PEAR standard:
http://pear.php.net/manual/en/standards.php
Most important rules on tne top:


- use UNIX end of lines (use \n and never windows \r\n)
     If we mix both modes, the CVS diffs are unusefull

- Indent 4 spaces, with no tabs
     Do not use Tabs or use 'insert Tabs as spaces' option of your text
     editor. Most of the editors (like Jedit or HomeSite) allows it.
     Then the code will look good in any editor.

- use <?php open tag
     Do not use any other shorted version like <?, .. There are some
     problems on some Apache configurations with <?...

- comments should follow phpDoc standard
     See http://phpdocu.sourceforge.net/
     Use /*  */ and // for comments, not #

- control structures should look like
     if ((condition1) || (condition2)) {
         commands;
     } else {
         commands;
     }
     Open brace at the end of line
     if, while, ... separated by space (it is not function call)

- function($var1, $var2=true) 
     No space between function name and open brace allow us easier find
     the function in the code

- 80 characters wide
     Try to write the code 80 characters wide, if possible

- quote strings in indexes
     Allways qoute strings like 'name' in $arr['name'] or $db->f('name')
     although current PHP do not need it

- use $_GET, $POST, and $_SERVER
     Use mentioned superglobal arrays to access variables from forms ...

- use return true; instead of return(true);
     Return is the statement, not a function

- When you commiting changes into CVS, allways update CHANGES file and
  send a note to apc...@so...

- Document new feature in the FAQ (http://apc-aa.sourceforge.net/faq/)
  and in the code 

- If it is possible, create an example of new feature on Sourceforge
  installation of AA

- If you changing database structure (adding table, ...), you should
  update doc/aadb.sql as well as sqlupdate.php3 script

- Before you are going to code some new feature, let us know about,
  please (apc...@so...)


-------------
I know the current code do not strictly follows mentioned rules, but
from this time it will ....... hopefully

    Honza

RE: [Apc-aa-coders] Conflicts with new CVS version - and suggested fixes

[Ram P. <ra...@pa...>]

Sorry all. Wrong message. ( generated by some auto reply program)

- Ram
-----Original Message-----
From: apc...@li...
[mailto:apc...@li...] On Behalf Of Ram
Prasad
Sent: Saturday, January 18, 2003 3:55 PM
To: 'Mitra'; apc...@so...
Subject: RE: [Apc-aa-coders] Conflicts with new CVS version - and
suggested fixes


You were late .. I had to go to for lunch.. Lets meet today again...

-----Original Message-----
From: apc...@li...
[mailto:apc...@li...] On Behalf Of Mitra
Sent: Saturday, January 18, 2003 1:28 PM
To: apc...@so...
Subject: [Apc-aa-coders] Conflicts with new CVS version - and suggested
fixes


Jakub

I've done a CVS update from your mgettext version.

I successfully merged your changes with mine. I have NOT committed my 
changes yet, I don't think my code is stable enough for that, 
although its running fine on my site.

There is one  problem I've seen - apart from the missing files you
mentioned.

config.php3 contains an include for the main language file you are 
using, which no longer exists. Which file is included will of course 
vary from machine to machine.

I suggest commenting out that part of the config.php3, that way your 
change should merge cleanly with whatever each site has locally.

- Mitra


-- 
Mitra Technology Consulting -  www.mitra.biz - mi...@mi...
02-6684-8096  or 0414-648-0722

Life is a Mystery to be Lived, not a Problem to be Solved



-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts
will allow you to extend the highest allowed 128 bit encryption to all
your 
clients even if they use browsers that are limited to 40 bit encryption.

Get a guide
here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
_______________________________________________
Apc-aa-coders mailing list
Apc...@li...
https://lists.sourceforge.net/lists/listinfo/apc-aa-coders




-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts
will allow you to extend the highest allowed 128 bit encryption to all
your 
clients even if they use browsers that are limited to 40 bit encryption.

Get a guide
here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en
_______________________________________________
Apc-aa-coders mailing list
Apc...@li...
https://lists.sourceforge.net/lists/listinfo/apc-aa-coders