Thread: [Aoetools-discuss] aoe6-74 & linux-2.6.34
Brought to you by:
ecashin,
elcapitansam
From: Serge L. <ser...@gm...> - 2010-06-06 18:14:15
|
Hello, Does aoe6-74 work with linux-2.6.34? I was able to compile it only after the following patch: --- a/linux/drivers/block/aoe/aoeblk.c 2010-06-06 12:49:22.000000000 -0500 +++ b/linux/drivers/block/aoe/aoeblk.c 2010-06-06 12:51:50.000000000 -0500 @@ -378,7 +378,7 @@ q->queuedata = d; d->gd = gd; if (aoe_maxsectors) - blk_queue_max_sectors(q, aoe_maxsectors); + blk_queue_max_hw_sectors(q, aoe_maxsectors); gd->major = AOE_MAJOR; gd->first_minor = d->sysminor; gd->fops = &aoe_bdops; --- a/linux/drivers/block/aoe/aoechr.c 2010-06-06 13:00:19.000000000 -0500 +++ b/linux/drivers/block/aoe/aoechr.c 2010-06-06 13:00:59.000000000 -0500 @@ -9,6 +9,7 @@ #include <linux/init.h> #include <linux/delay.h> #include <linux/smp_lock.h> +#include <linux/slab.h> #include "aoe.h" enum { --- a/linux/drivers/block/aoe/aoemain.c 2010-06-06 13:02:09.000000000 -0500 +++ b/linux/drivers/block/aoe/aoemain.c 2010-06-06 13:02:44.000000000 -0500 @@ -9,6 +9,7 @@ #include <linux/module.h> #include <linux/moduleparam.h> #include <linux/init.h> +#include <linux/slab.h> #include "aoe.h" MODULE_LICENSE("GPL"); Error text: make -C /data/build/tmp/linux-2.6.34 CONFIG_ATA_OVER_ETH=m KDIR=/data/build/tmp/linux-2.6.34 SUBDIRS="/data/build/tmp/aoe6-74/linux/drivers/block/aoe" EXTRA_ CFLAGS="-DAOE_PARTITIONS=16 -DDEVSUBDIR='\"etherd\"' -DAOE_DYNDEVS=1" modules make[1]: Entering directory `/data/build/tmp/linux-2.6.34' CC [M] /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoeblk.o CC [M] /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.o /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.c: In function 'aoechr_error': /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.c:131: error: implicit declaration of function 'kmalloc' /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.c:131: warning: assignment makes pointer from integer without a cast /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.c: In function 'aoechr_read': /data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.c:256: error: implicit declaration of function 'kfree' make[2]: *** [/data/build/tmp/aoe6-74/linux/drivers/block/aoe/aoechr.o] Error 1 make[1]: *** [_module_/data/build/tmp/aoe6-74/linux/drivers/block/aoe] Error 2 make[1]: Leaving directory `/data/build/tmp/linux-2.6.34' make: *** [linux/drivers/block/aoe/aoe.ko] Error 2 Sincerely, Serge |
From: Ed C. <ec...@co...> - 2010-06-10 13:02:16
|
On Jun 6, 2010, at 2:14 PM, Serge Leschinsky wrote: > Hello, > > Does aoe6-74 work with linux-2.6.34? I'm looking into it, but besides the changes you did in the patch, didn't you have to disable the check in the Makefile for the include/asm symlink? I'm not sure how you would have gotten past the initial checks otherwise. Thanks for the patch. Does the patched version work fine for you? -- Ed Cashin ec...@co... |
From: Serge L. <ser...@gm...> - 2010-06-10 16:43:04
|
Ed, On 06/10/2010 06:01 AM, Ed Cashin wrote: > On Jun 6, 2010, at 2:14 PM, Serge Leschinsky wrote: > >> Hello, >> >> Does aoe6-74 work with linux-2.6.34? > > I'm looking into it, but besides the changes you did in > the patch, didn't you have to disable the check in the > Makefile for the include/asm symlink? :) I've created this symlink manually, because I thought that it's a flaw of my environment. > I'm not sure how you would have gotten past the initial checks otherwise. > You are right. There was a manual intervention. > Thanks for the patch. Does the patched version work > fine for you? > Yes, it works. But I have not tested it deeply, just a quick check - format and copy some files to the device. root@vpnc:~ # uname -r 2.6.34 --------- aoe: AoE v74 initialised. aoe: e1.1: setting 1024 byte data frames aoe: 0014d1163376 e1.1 v4014 has 122880 sectors etherd/e1.1: unknown partition table Sincerely, Serge |
From: Ed C. <ec...@co...> - 2010-06-10 16:52:13
|
On Jun 10, 2010, at 12:42 PM, Serge Leschinsky wrote: ... > :) I've created this symlink manually, because I thought that it's a flaw of my > environment. No, it appears that the arch-specific headers have moved from include/asm-foo to arch/foo/include, so the pre-build test needs updating to support that, in addition to the changes you noticed. -- Ed Cashin ec...@co... |
From: Ed C. <ec...@co...> - 2010-06-15 16:38:11
|
Serge Leschinsky, would you mind please testing the aoe6-75pre1 patch that's now on the "aoe Proving Grounds" blog? http://is.gd/cQmY1 Here is a direct link: http://support.coraid.com/support/linux/pre/aoe-prereleases/aoe6-74-75pre1.diff Anyone else interested in 2.6.34 or 2.6.33 is encouraged to try the patch, and anyone interested in older kernels are welcome to make sure that the patched driver still works with your older kernel. -- Ed Cashin ec...@co... |
From: Serge L. <ser...@gm...> - 2010-06-16 17:30:04
|
Ed, it works ( kernel 2.6.34 ) Thank you, Serge On Tue, Jun 15, 2010 at 9:37 AM, Ed Cashin <ec...@co...> wrote: > Serge Leschinsky, would you mind please testing the aoe6-75pre1 > patch that's now on the "aoe Proving Grounds" blog? > > http://is.gd/cQmY1 > > Here is a direct link: > > http://support.coraid.com/support/linux/pre/aoe-prereleases/aoe6-74-75pre1.diff > > Anyone else interested in 2.6.34 or 2.6.33 is encouraged to try the > patch, and anyone interested in older kernels are welcome to make > sure that the patched driver still works with your older kernel. > > -- > Ed Cashin > ec...@co... > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Aoetools-discuss mailing list > Aoe...@li... > https://lists.sourceforge.net/lists/listinfo/aoetools-discuss > -- Sincerely yours, Serge Leschinsky |
From: Yacine K. <ya...@al...> - 2010-06-15 17:39:55
|
FYI, 2.6.27 = KO (full details sent to support) 2.6.31 = OK On Tue, 2010-06-15 at 12:37 -0400, Ed Cashin wrote: > Serge Leschinsky, would you mind please testing the aoe6-75pre1 > patch that's now on the "aoe Proving Grounds" blog? > > http://is.gd/cQmY1 > > Here is a direct link: > > http://support.coraid.com/support/linux/pre/aoe-prereleases/aoe6-74-75pre1.diff > > Anyone else interested in 2.6.34 or 2.6.33 is encouraged to try the > patch, and anyone interested in older kernels are welcome to make > sure that the patched driver still works with your older kernel. > |
From: Ed C. <ec...@co...> - 2010-06-15 17:56:11
|
Thanks, Yacine. If the problem was that there's no file to allow modversions to work, that's a different issue that support will help you with. But if the aoe6-75pre1 doesn't build for 2.6.27 or doesn't load when you *do* have the Module.symversion file in the sources or are not using modversions, then please let me know. On Jun 15, 2010, at 1:23 PM, Yacine Kheddache wrote: > FYI, > > 2.6.27 = KO (full details sent to support) > 2.6.31 = OK > > > On Tue, 2010-06-15 at 12:37 -0400, Ed Cashin wrote: >> Serge Leschinsky, would you mind please testing the aoe6-75pre1 >> patch that's now on the "aoe Proving Grounds" blog? >> >> http://is.gd/cQmY1 >> >> Here is a direct link: >> >> http://support.coraid.com/support/linux/pre/aoe-prereleases/aoe6-74-75pre1.diff >> >> Anyone else interested in 2.6.34 or 2.6.33 is encouraged to try the >> patch, and anyone interested in older kernels are welcome to make >> sure that the patched driver still works with your older kernel. >> > > > > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Aoetools-discuss mailing list > Aoe...@li... > https://lists.sourceforge.net/lists/listinfo/aoetools-discuss > > > -- Ed Cashin ec...@co... |