Thread: [Aoetools-discuss] aoe6-68 doesn't build against 2.6.28 ...
Brought to you by:
ecashin,
elcapitansam
From: Marc - A. D. [ A. | W. G. ] <ma...@wo...> - 2009-01-19 14:08:09
|
Hello Ed, just to let you know, the build of aoe6-68 against vanilla 2.6.28 fails with the following error: 24-kv.sh Error: could not identify kernel source state I found out that device_create_drvdata was renamed to device_create in the 2.6.28 cycle. There are other things that have changed in 2.6.28 but i don't have access to my test box right now so i have to post more details on the other changes later. Just to check if we can abandon the in-house usage of aoe6 and stick to the aoe module in Mainline, let me ask the following question: What functionality is missing in mainline that is in version 68 and when will the changes and additions in functionality be merged back into mainline? Thanks in advance, Marc |
From: Ed C. <ec...@co...> - 2009-01-19 16:54:19
|
On Mon, Jan 19, 2009 at 02:45:14PM +0100, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: > Hello Ed, > > just to let you know, the build of aoe6-68 against vanilla 2.6.28 fails > with the following error: > > 24-kv.sh Error: could not identify kernel source state > > I found out that device_create_drvdata was renamed to device_create in > the 2.6.28 cycle. There are other things that have changed in 2.6.28 but > i don't have access to my test box right now so i have to post more > details on the other changes later. Ah, yes. Greg Kroah-Hartman said this change was bound to happen. This part of the kernel is the most churn-filled that the aoe compatibility system has to deal with. Since I knew the change was coming, I prepared for it and should be able to accomodate it in version 69 without too much delay. > Just to check if we can abandon the in-house usage of aoe6 and stick to > the aoe module in Mainline, let me ask the following question: > > What functionality is missing in mainline that is in version 68 and > when will the changes and additions in functionality be merged back into > mainline? You can check the NEWS file in the aoe sources to see the changes that appear after version 47. The same file is online at the URL below. http://support.coraid.com/support/linux/aoe6-Changelog -- Ed Cashin <ec...@co...> |
From: Marc - A. D. <ma...@wo...> - 2009-01-19 19:23:58
|
Ed Cashin schrieb: > On Mon, Jan 19, 2009 at 02:45:14PM +0100, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote: > >> Hello Ed, >> >> just to let you know, the build of aoe6-68 against vanilla 2.6.28 fails >> with the following error: >> >> 24-kv.sh Error: could not identify kernel source state >> >> I found out that device_create_drvdata was renamed to device_create in >> the 2.6.28 cycle. There are other things that have changed in 2.6.28 but >> i don't have access to my test box right now so i have to post more >> details on the other changes later. >> > > Ah, yes. Greg Kroah-Hartman said this change was bound to happen. > This part of the kernel is the most churn-filled that the aoe > compatibility system has to deal with. > > Since I knew the change was coming, I prepared for it and should be > able to accomodate it in version 69 without too much delay. > Some other stuff is: 'struct gendisk' lost the dev member so you have to use the disk_to_dev helper 'struct gendisk' lost the capacity member so you have to use the {get,set}_capacity helpers Also the disk_stat things are gone now, the corresponding patch is this one: https://kerneltrap.org/mailarchive/linux-kernel/2008/8/25/3067064 I don't know if other changes are needed as i didn't looked further... >> Just to check if we can abandon the in-house usage of aoe6 and stick to >> the aoe module in Mainline, let me ask the following question: >> >> What functionality is missing in mainline that is in version 68 and >> when will the changes and additions in functionality be merged back into >> mainline? >> > > You can check the NEWS file in the aoe sources to see the changes that > appear after version 47. The same file is online at the URL below. > > http://support.coraid.com/support/linux/aoe6-Changelog I found some nice additions/fixes there but was a little bit shocked by the date version 47 got released. Will there be a merger of functionality and fixes added after version 47 into mainline in the near future? Thanks, Marc |
From: Ed C. <ec...@co...> - 2009-01-21 20:12:16
|
I have to make sure the changes work on a few popular kernels before making a release, but I think this patch against version 68 resolves the compatibility issues for 2.6.28. http://support.coraid.com/support/linux/tmp/aoe6-68-69pre1.diff Please try it out and let me know how it works for you. I am going to try to make time to get the kernel.org driver caught up. The coraid.com one has been changing a lot lately, and the kernel.org development model has too, with the addition of linux-next and such. Things seem to be calming down, though. -- Ed Cashin <ec...@co...> |
From: Ed C. <ec...@co...> - 2009-01-21 22:47:15
|
On Wed, Jan 21, 2009 at 03:12:32PM -0500, Ed Cashin wrote: > I have to make sure the changes work on a few popular kernels before > making a release, but I think this patch against version 68 resolves > the compatibility issues for 2.6.28. A new prerelease fixes the conf/21 test and adds compatibility with the new ioctl-handler prototype in 2.6.28. http://support.coraid.com/support/linux/tmp/aoe6-68-69pre1.diff -- Ed Cashin <ec...@co...> |