Menu

#2 Code to compare sequence numbers will fail with large sequen

open
nobody
None
5
2010-02-01
2010-02-01
Anonymous
No

Code to compare sequence numbers is currently:
(example from aodv_rerr.c)

if((int32_t) rt->dest_seqno > (int32_t) rerr_dest_seqno){..}

This code will fail as sequence numbers rollover from 2^31-1 to 2^31

A better test would be:

if(((int32_t)(rt->dest_seqno - rerr_dest_seqno)) > 0) {..}

Discussion


Log in to post a comment.

MongoDB Logo MongoDB