From: Dale Anson <danson@ge...>  20040917 04:26:07

Well, I found the tests, but they weren't for the Math task. I'd used the Math classes as the basis for an RPN calculator plugin to jEdit, and the tests work on the Math class directly, not on the task. For the calculator, I've made quite a few changes to the Math classes to support BigDecimals and BigIntegers numbers. I'd forgotten about the calculator plugin, although I do use it fairly often, I've never submitted the source to jEdit. The Math classes in the calculator and the Math classes in antcontrib have diverged quite a bit, but the basic idea is still the same. I'll go ahead and write some test for the task, and while I'm at it I'll see if the BigDecimal and BigInteger stuff can be added in. Dale > Matt, > > Let me look around, I thought I had written a pile of tests for the Math > tasks, but I don't see them in antcontrib's cvs. > > Dale > > > >> There were some limitations in the <math> task that manifested >> themselves >> when someone tried to perform something like this: >> >> <math result="b"> >> <op op=""> >> <op op="+"> >> <num value="4"/> >> <num value="2"/> >> </op> >> <num value="2"/> >> </op> >> </math> >> >> It seems the existing MathTask always kept the numerical values seperate >> from the operations, and did operations (such as "") with the numeric >> values being the first operands, and not preserving the order in the >> xml. >> Therefore the above calculation became: 2  (4 + 2) instead of: (4+2)  >> 2 >> >> I have refactored (and put in their own package) the math classes so >> that >> this doesn't happen anymore. I will leave out the specifics of what the >> refactoring involved (you can email me directly if you're interested), >> but part of it changed the way that Math/StrictMath methods are found >> and >> executed. So keep this in mind, as we have no real test cases for Math. >> (anyone willing to write some if i don't have the time?) >> >> >> >>  >> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl >> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam >> Camcorder. More prizes in the weekly Lunch Hour Challenge. >> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m >> _______________________________________________ >> Antcontribdevelopers mailing list >> Antcontribdevelopers@... >> https://lists.sourceforge.net/lists/listinfo/antcontribdevelopers >> > > > > >  > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Antcontribdevelopers mailing list > Antcontribdevelopers@... > https://lists.sourceforge.net/lists/listinfo/antcontribdevelopers > 