andro-hacker Mailing List for Andromeda Database Development System (Page 2)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Author: ke...@se...
Date: Wed May 27 08:37:32 2009
New Revision: 1362

Modified:
    trunk/andro/clib/x6.js

Log:
Browse lookups now work much more smoothly.  When user hits a key and a  
search is in progress it correctly aborts the search and starts a new one,  
so things keep making sense even if the user types very fast.

Fixes issue 11
Status: verified

Modified: trunk/andro/clib/x6.js
==============================================================================

--- trunk/andro/clib/x6.js	(original)
+++ trunk/andro/clib/x6.js	Wed May 27 08:37:32 2009
@@ -2922,8 +2922,13 @@
          if(async) {
              this.http.onreadystatechange = function() {
                  if(this.readyState!=4) return;
-                json.processPre(false);
-                json.process();
+                // KFD 5/27/09 Google #11
+                //             When somebody is asking for a return
+                //             string, you do not want to process
+                if(!returnString) {
+                	json.processPre(false);
+                	json.process();
+                }
                  if(callBack) callBack();
              }
          }
@@ -3124,7 +3129,6 @@
  	request: function(inp,val) {
  		// First thing is to cancel current request
  		if(this.JSON) {
-			console.log("Aborting");
  			//if(this.JSON.http) {
  			//	this.JSON.http.abort();
  			//}
@@ -5155,6 +5159,57 @@
      }
  }

+// KFD 5/27/09 Google #11, create a separate object that handles
+//             grid requests, which automatically cancels
+//             previous requests.
+x6gridJSON = {
+	JSON: false,
+
+	request: function(gridObject) {
+		// First thing is to cancel current request
+		if(this.JSON) {
+			this.JSON = false;
+		}
+		
+		// The "addFilters" routine puts in all parms, but
+		// it does the very important task of figuring out
+		// if there is anything to do, and it writes the
+		// result to gridObject.doFetch.
+		//
+		// It would be nice not to create the JSON object
+		// until after the routine had determined if it were
+		// necessary, but unfortunately the routine puts the
+		// parms there if required, so that's how we have to
+		// do it.
+		this.JSON = new x6JSON('x6page',gridObject.zTable);
+		gridObject.addFilters(this.JSON);
+		if(!gridObject.doFetch) return;
+		// <<<-------- EARLY RETURN;
+		
+		x6.data.browseFetchHtml = '';
+        if(gridObject.cntNoBlank==0) {
+            $(gridObject).find('.tbody').html('');
+            return;
+        }
+        gridObject.gridParms(this.JSON);
+
+        // Add the "exact match" parm if it is part of the
+        // the grid.  Notice it is a one-timer
+        if($(gridObject).attr('x6exactPre')==1) {
+            this.JSON.addParm('x6exactPre',1);
+            $(gridObject).attr('x6exactPre',0);
+        }
+
+        var json = this.JSON;
+        this.JSON.execute(false,true,true,function() {
+        	console.log("you ran a search!");
+             
$(gridObject).find(".tbody").replaceWith(json.http.responseText);
+            $(gridObject).find('.tbody div:first').mouseover();
+        });
+    }
+}
+
+
  /***im* x6plugins/grid
  *
  * NAME
@@ -6022,38 +6077,53 @@
      */
      self.fetch = function(doFetch) {
          if(doFetch==null) doFetch=false;
+
+        // KFD 5/27/09 Google #11 Refactor if user types quickly
+        //     everything should still work smoothly, and
+        //     user should see result from very last keystroke
+        //
+        //     NOTE: The fetch(false) call comes from the keyUp()
+        //           event on the grid search inputs.
+        x6gridJSON.request(this);
+        return;
+        //
+        // KFD 5/27/09 Google #11 (END)

-        // Initialize and then scan
-        var json = new x6JSON('x6page',this.zTable);
-        this.addFilters(json);

-        if(this.doFetch) {
-            // Clear the previous results
-            x6.data.browseFetchHtml = '';
-            if(this.cntNoBlank==0) {
-                $(this).find('.tbody').html('');
-                return;
-            }
-            this.gridParms(json);
-
-            // Add the "exact match" parm if it is part of the
-            // the grid.  Notice it is a one-timer
-            if($(this).attr('x6exactPre')==1) {
-                json.addParm('x6exactPre',1);
-                $(this).attr('x6exactPre',0);
-            }
-
-            if( html = json.execute(false,false,true)) {
-                //json.process();
-                // The standard path is to take data returned
-                // by the server and render it.  This is safe
-                // even if the server does not return anything,
-                // because we initialized to an empty object.
-                $(this).find(".tbody").replaceWith(html);
-                $(this).find('.tbody div:first').mouseover();
-            }
-        }
-        delete json;
+        // KFD 5/27/09, Google #11, all code below is
+        //              now dead.  Keep it around for
+        //              a few months and then get rid of it.
+        // Initialize and then scan
+//        var json = new x6JSON('x6page',this.zTable);
+//        this.addFilters(json);
+//
+//        if(this.doFetch) {
+//            // Clear the previous results
+//            x6.data.browseFetchHtml = '';
+//            if(this.cntNoBlank==0) {
+//                $(this).find('.tbody').html('');
+//                return;
+//            }
+//            this.gridParms(json);
+//
+//            // Add the "exact match" parm if it is part of the
+//            // the grid.  Notice it is a one-timer
+//            if($(this).attr('x6exactPre')==1) {
+//                json.addParm('x6exactPre',1);
+//                $(this).attr('x6exactPre',0);
+//            }
+//
+//            if( html = json.execute(false,false,true)) {
+//                //json.process();
+//                // The standard path is to take data returned
+//                // by the server and render it.  This is safe
+//                // even if the server does not return anything,
+//                // because we initialized to an empty object.
+//                $(this).find(".tbody").replaceWith(html);
+//                $(this).find('.tbody div:first').mouseover();
+//            }
+//        }
+//        delete json;
      }

      /*




2007	Jan	Feb (1)	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec (2)
2008	Jan	Feb (58)	Mar (126)	Apr (96)	May (42)	Jun (59)	Jul (80)	Aug (95)	Sep (99)	Oct (137)	Nov (54)	Dec (138)
2009	Jan (174)	Feb (83)	Mar (36)	Apr (22)	May (16)	Jun (11)	Jul (7)	Aug	Sep	Oct	Nov	Dec

andro-hacker Mailing List for Andromeda Database Development System (Page 2)

andro-hacker — For under-the-hood topics