From: Enoch <ix...@ho...> - 2013-04-07 13:51:07
|
Hello Matthias, May I suggest renaming the new implementation of imove ( i-addr len ram -- ) at lib/ans94/core/imove.frt to icmove: imove should be a variant of move, that is: "copy the contents of u consecutive address units". icmove should be a variant of cmove, that is: "copy u consecutive characters". Also, it seems to me that your implementation may cause ram buffer overflow. Regards, Enoch. |
From: Matthias T. <mt...@we...> - 2013-04-10 18:58:37
|
Hi, > May I suggest renaming the new implementation of imove > ( i-addr len ram -- ) at lib/ans94/core/imove.frt to icmove: Uhm. The naming I'd like to delay. There are some efforts to get a consistent naming convention for memory accesses. One example is http://www.forth200x.org/memory-2010-06-26.txt > Also, it seems to me that your implementation may cause ram buffer > overflow. The code copies flash cells. That may overrun the RAM if an odd number of bytes is transferred. Thats bad indeed. Matthias |
From: Rafael G. <ast...@ya...> - 2013-04-11 12:19:56
|
mmm ... I think the 200x proposal misses EEPROM as Data space ________________________________ De: Matthias Trute <mt...@we...> Para: Everything around amforth <amf...@li...> Enviado: Miércoles 10 de abril de 2013 20:58 Asunto: Re: [Amforth] imove Hi, > May I suggest renaming the new implementation of imove > ( i-addr len ram -- ) at lib/ans94/core/imove.frt to icmove: Uhm. The naming I'd like to delay. There are some efforts to get a consistent naming convention for memory accesses. One example is http://www.forth200x.org/memory-2010-06-26.txt > Also, it seems to me that your implementation may cause ram buffer > overflow. The code copies flash cells. That may overrun the RAM if an odd number of bytes is transferred. Thats bad indeed. Matthias ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Amforth-devel mailing list for http://amforth.sf.net/ Amf...@li... https://lists.sourceforge.net/lists/listinfo/amforth-devel |
From: Enoch <ix...@ho...> - 2013-04-12 02:27:47
|
Matthias Trute <mt...@we...> writes: >> Also, it seems to me that your implementation may cause ram buffer >> overflow. > > The code copies flash cells. That may overrun the > RAM if an odd number of bytes is transferred. Thats > bad indeed. Hello Matthias, I had it fixed for my own use, so here sharing: : imove ( i-addr len ram -- ) rot rot dup 1 and >r \ ( ram i-addr len ) ( r: odd ) 2/ over + dup >r \ ( ram i-addr i-addr' ) ( r: odd i-addr' ) swap \ ( ram i-addr' i-addr ) ?do i @i over ! cell+ loop \ ( ram' ) r> r> \ ( ram' i-addr' odd ) if @i swap c! else 2drop then ; http://pastebin.com/ZqL4aWN7 Regards, Enoch. |
From: Matthias T. <mt...@we...> - 2013-04-12 17:27:57
|
Hi Enoch, > I had it fixed for my own use, so here sharing: Thanks for sharing. Fix applied :=) Matthias |
From: Enoch <ix...@ho...> - 2013-04-12 19:45:00
|
Matthias Trute <mt...@we...> writes: > Thanks for sharing. Fix applied :=) Hello Matthias, I really enjoy the experience and I should be thanking you! In your latest docs you refer to having a GIT tree, where is it based? I would like to track AmForth via GIT rather than SVN for some local kernel changes that I maintain (*). Regards, Enoch. (*) Those will be offered soon once fully tested in my application. These are issues related to the way Interrupts are handled with the intention of making AmForth Interrupt Service routines truly interruptible. |
From: Matthias T. <mt...@we...> - 2013-04-13 08:03:06
|
Hi Enoch, > In your latest docs you refer to having a GIT tree, where is it based? Its on my local desktop system. Not available for external access. > I would like to track AmForth via GIT rather than SVN for some local > kernel changes that I maintain (*) I've heart that git-svn works well. Never really tried it myself howver. Matthias |
From: Enoch <ix...@ho...> - 2013-04-14 17:53:15
|
Matthias Trute <mt...@we...> writes: > Hi Enoch, > >> In your latest docs you refer to having a GIT tree, where is it based? > > Its on my local desktop system. Not available for external access. > >> I would like to track AmForth via GIT rather than SVN for some local >> kernel changes that I maintain (*) > > I've heart that git-svn works well. Never really tried it myself howver. Hello Matthias, I took up your advice and finally I have commit rights :-) Regards, Enoch. |