Menu

#86 fix for infinite loop with amflush & inf tapecycle

open
nobody
None
2019-09-16
2018-04-28
Anonymous
No

Originally created by: flowers9
Originally owned by: chassell

If the amanda.conf setup has "tapecycle inf tapes", amflush will
get into an infinite loop in perl/Amanda/Amflush.pm::roll_amdump_logs():

my $days = getconf($CNF_TAPECYCLE) + 2;
for (my $i = $days-1; $i >= 1; $i--) {
    my $a = pop @files;
}

The simple patch for this is:

for (my $i = $days-1; @files && $i >= 1; $i--) {

This exists in 3.4.5 and 3.5.1, but not 3.3.4 (the versions I have on hand).

Related

Tickets: #116

Discussion

  • Anonymous

    Anonymous - 2019-09-16
     
  • Anonymous

    Anonymous - 2019-09-16

    Originally posted by: chassell

    putting in a PR.

     

Log in to post a comment.